From 136519370f4a3d08e5db701b894e394494056bcb Mon Sep 17 00:00:00 2001 From: simon Date: Mon, 5 Feb 2007 18:07:11 +0000 Subject: [PATCH 1/1] Avoid passing modified SVN revision numbers (of the form 1234M) to parts of the versioning code which might not like them. As a result of this checkin, bob builds from modified SVN working copies will still announce themselves as revision nnnnM in the textual version strings, but their binary version in the Windows VERSIONINFO will now be 0.0.0.0. git-svn-id: svn://svn.tartarus.org/sgt/putty@7231 cda61777-01e9-0310-a592-d414129be87e --- Buildscr | 1 + windows/version.rc2 | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/Buildscr b/Buildscr index 090e89a0..d48f5a48 100644 --- a/Buildscr +++ b/Buildscr @@ -5,6 +5,7 @@ module putty # Set up the arguments for the main make command. set Makever -DSVN_REV=$(revision) +ifneq "$(!numeric $(revision))" "yes" set Makever $(Makever) -DMODIFIED ifneq "$(RELEASE)" "" set Makever $(Makever) -DRELEASE=$(RELEASE) ifneq "$(date)" "" set Makever $(Makever) -DSNAPSHOT=$(date) set Makeargs VER="$(Makever)" diff --git a/windows/version.rc2 b/windows/version.rc2 index 049dbe53..8474a62b 100644 --- a/windows/version.rc2 +++ b/windows/version.rc2 @@ -50,7 +50,11 @@ #endif #define VERSION_TEXT "Development snapshot " STR(SNAPSHOT) ":r" STR(SVN_REV) +#ifdef MODIFIED +#define BINARY_VERSION 0,0,0,0 +#else #define BINARY_VERSION BASE_VERSION,SVN_REV,0 +#endif #elif defined RELEASE @@ -60,7 +64,11 @@ #elif defined SVN_REV #define VERSION_TEXT "Custom build r" STR(SVN_REV) +#ifdef MODIFIED +#define BINARY_VERSION 0,0,0,0 +#else #define BINARY_VERSION BASE_VERSION,SVN_REV,0 +#endif #else -- 2.11.0