u/mdw/putty
18 years agoAdd NO_MANIFESTS option to Windows build, as the manifests apparently cause
jacob [Sat, 21 May 2005 14:35:21 +0000 (14:35 +0000)]
Add NO_MANIFESTS option to Windows build, as the manifests apparently cause
trouble for 64-bit Windows builds.
Also flag the build flags that only apply to Windows.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5820 cda61777-01e9-0310-a592-d414129be87e

18 years agoUse {Get,Set}WindowLongPtr() instead of {Get,Set}WindowLong() for compatibility
jacob [Sat, 21 May 2005 14:16:43 +0000 (14:16 +0000)]
Use {Get,Set}WindowLongPtr() instead of {Get,Set}WindowLong() for compatibility
with 64-bit Windows. Untested on 64-bit, but it doesn't appear to have broken
anything on 32-bit.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5819 cda61777-01e9-0310-a592-d414129be87e

18 years agoMinor memory leak spotted by Mikhail Kruk.
jacob [Fri, 20 May 2005 21:52:07 +0000 (21:52 +0000)]
Minor memory leak spotted by Mikhail Kruk.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5815 cda61777-01e9-0310-a592-d414129be87e

18 years agoconnection_fatal() should be called after ssh_closing() and other accesses to
jacob [Mon, 16 May 2005 14:41:08 +0000 (14:41 +0000)]
connection_fatal() should be called after ssh_closing() and other accesses to
`ssh', since it potentially frees it and potentially doesn't return.
Only affected a couple of rare circumstances.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5787 cda61777-01e9-0310-a592-d414129be87e

18 years agoDon't try and set up reconfigured port-forwardings if the connection isn't yet
jacob [Mon, 16 May 2005 08:31:05 +0000 (08:31 +0000)]
Don't try and set up reconfigured port-forwardings if the connection isn't yet
ready for them. Spotted by Martin Dushkov.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5786 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd experimental support for detecting BREAK on input and propagating it as
ben [Sat, 14 May 2005 22:01:10 +0000 (22:01 +0000)]
Add experimental support for detecting BREAK on input and propagating it as
TS_BRK on output.  This is tested to the extent that other data survive the
escaping performed by PARMRK, at least on my system.  Actual passing on
of BREAK is as-yet untested.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5779 cda61777-01e9-0310-a592-d414129be87e

19 years agoUse the packet dispatch table to handle USERAUTH_BANNER messages, which should
jacob [Thu, 12 May 2005 15:09:35 +0000 (15:09 +0000)]
Use the packet dispatch table to handle USERAUTH_BANNER messages, which should
hopefully solve `drop-banner'. I haven't been able to test the failure case,
but the behaviour with OpenSSH appears no worse.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5772 cda61777-01e9-0310-a592-d414129be87e

19 years agos/public/private/ spotted by Walter Cleverly.
jacob [Mon, 9 May 2005 21:01:11 +0000 (21:01 +0000)]
s/public/private/ spotted by Walter Cleverly.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5765 cda61777-01e9-0310-a592-d414129be87e

19 years agoMake Makefile.gtk build again on Linux (assume <utmpx.h>).
jacob [Mon, 9 May 2005 13:27:51 +0000 (13:27 +0000)]
Make Makefile.gtk build again on Linux (assume <utmpx.h>).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5764 cda61777-01e9-0310-a592-d414129be87e

19 years agoFix what looks like a cut-and-paste error which was stopping Unix
simon [Sun, 8 May 2005 11:47:59 +0000 (11:47 +0000)]
Fix what looks like a cut-and-paste error which was stopping Unix
Plink building on MacOS X.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5762 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd `install-sh' to svn:ignore
jacob [Fri, 6 May 2005 10:19:34 +0000 (10:19 +0000)]
Add `install-sh' to svn:ignore

git-svn-id: svn://svn.tartarus.org/sgt/putty@5752 cda61777-01e9-0310-a592-d414129be87e

19 years agoCorrect apparent misspelling of `SIOCATMARK'.
jacob [Thu, 5 May 2005 22:47:30 +0000 (22:47 +0000)]
Correct apparent misspelling of `SIOCATMARK'.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5749 cda61777-01e9-0310-a592-d414129be87e

19 years agoImplement `bypass-ssh2-userauth', since from correspondence it sounds like
jacob [Thu, 5 May 2005 22:37:54 +0000 (22:37 +0000)]
Implement `bypass-ssh2-userauth', since from correspondence it sounds like
there are servers which could in principle operate in this mode, although I
don't know if any do in practice. (Hence, I haven't been able to test it.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5748 cda61777-01e9-0310-a592-d414129be87e

19 years agoAlso blank X authentication data when using SSH-1, and add a comment explaining
ben [Sat, 30 Apr 2005 17:08:48 +0000 (17:08 +0000)]
Also blank X authentication data when using SSH-1, and add a comment explaining
why this may not be sufficient to hide it.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5720 cda61777-01e9-0310-a592-d414129be87e

19 years agoX11 authentication data are generally sensitive, so blank them from packet
ben [Sat, 30 Apr 2005 16:13:11 +0000 (16:13 +0000)]
X11 authentication data are generally sensitive, so blank them from packet
logs by default.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5719 cda61777-01e9-0310-a592-d414129be87e

19 years agoUnlike the AES and Blowfish code, our implementations of the various DES
ben [Sat, 30 Apr 2005 14:30:07 +0000 (14:30 +0000)]
Unlike the AES and Blowfish code, our implementations of the various DES
modes of operation all took separate source and destination pointers.  They
were never called with those pointers different, though, so reduce them to
a single pointer like everything else uses.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5716 cda61777-01e9-0310-a592-d414129be87e

19 years agoFix stupid typo that probably utterly broke SSH-1 support, and caused compiles
ben [Sat, 30 Apr 2005 14:26:46 +0000 (14:26 +0000)]
Fix stupid typo that probably utterly broke SSH-1 support, and caused compiles
with GCC to fail.  Not sure how it survived long enough to test, really.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5715 cda61777-01e9-0310-a592-d414129be87e

19 years agoMinimally document 3des-ctr and blowfish-ctr.
ben [Thu, 28 Apr 2005 09:03:16 +0000 (09:03 +0000)]
Minimally document 3des-ctr and blowfish-ctr.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5703 cda61777-01e9-0310-a592-d414129be87e

19 years agoRemove comment explaining why 3des-ctr is disabled, since it isn't.
ben [Thu, 28 Apr 2005 09:00:50 +0000 (09:00 +0000)]
Remove comment explaining why 3des-ctr is disabled, since it isn't.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5702 cda61777-01e9-0310-a592-d414129be87e

19 years agoEnable blowfish-ctr by default. It's been tested and found working.
ben [Thu, 28 Apr 2005 08:56:03 +0000 (08:56 +0000)]
Enable blowfish-ctr by default.  It's been tested and found working.
Thanks to der Mouse for help with the testing.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5701 cda61777-01e9-0310-a592-d414129be87e

19 years agoIn blowfish-ctr mode, increment the counter in the correct order. Thanks to
ben [Thu, 28 Apr 2005 08:24:46 +0000 (08:24 +0000)]
In blowfish-ctr mode, increment the counter in the correct order.  Thanks to
der Mouse for spotting the same error in my 3des-ctr implementation.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5700 cda61777-01e9-0310-a592-d414129be87e

19 years agoFix two more stupid bugs in 3des-ctr:
ben [Thu, 28 Apr 2005 08:21:04 +0000 (08:21 +0000)]
Fix two more stupid bugs in 3des-ctr:
 - We were using the first word of each block of keystream block twice and the
   second not at all.
 - We were incrementing the high-order word of the counter after every block
   rather than the low-order one.

With those fixed, our 3des-ctr implementation interoperates with the one in
Moussh.  Thanks to der Mouse for his help with the testing.

3des-ctr is now enabled by default.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5699 cda61777-01e9-0310-a592-d414129be87e

19 years agoOn monochrome displays, display the cursor in reverse video so that it's
ben [Wed, 27 Apr 2005 21:42:51 +0000 (21:42 +0000)]
On monochrome displays, display the cursor in reverse video so that it's
visible on reversed out text.  This only applies to active block cursors for
now.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5698 cda61777-01e9-0310-a592-d414129be87e

19 years agoTiny manual CSE of previous commit.
ben [Wed, 27 Apr 2005 21:22:40 +0000 (21:22 +0000)]
Tiny manual CSE of previous commit.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5697 cda61777-01e9-0310-a592-d414129be87e

19 years agoOn 1bpp displays, ignore colour attributes. This makes pterm minimally useful
ben [Wed, 27 Apr 2005 21:09:45 +0000 (21:09 +0000)]
On 1bpp displays, ignore colour attributes.  This makes pterm minimally useful
there, though (e.g.) switching to using reverse video for the cursor would
probably also help.  Displays with other silly depths (e.g. 2bpp) aren't
catered for, but I suspect they're rare in the X world.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5696 cda61777-01e9-0310-a592-d414129be87e

19 years agoMake palette changes use "best match" colours too.
ben [Wed, 27 Apr 2005 20:30:47 +0000 (20:30 +0000)]
Make palette changes use "best match" colours too.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5695 cda61777-01e9-0310-a592-d414129be87e

19 years agoRather than checking for <sys/sockio.h>, just include it if our other
ben [Wed, 27 Apr 2005 15:42:10 +0000 (15:42 +0000)]
Rather than checking for <sys/sockio.h>, just include it if our other
attempts at finding SIOCATMARK have failed.  This removes one of our
Autoconf tests, which is always nice.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5690 cda61777-01e9-0310-a592-d414129be87e

19 years agoUse the correct key order for 3des-ctr.
ben [Wed, 27 Apr 2005 12:39:52 +0000 (12:39 +0000)]
Use the correct key order for 3des-ctr.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5687 cda61777-01e9-0310-a592-d414129be87e

19 years agoIn SSH-2 mode, PuTTY wasn't sending KEXINIT until it had received one from the
ben [Wed, 27 Apr 2005 11:10:54 +0000 (11:10 +0000)]
In SSH-2 mode, PuTTY wasn't sending KEXINIT until it had received one from the
server, which led to stalemate if the server did the same.  PuTTY now sends
KEXINIT proactively as soon as it's worked out that it's talking SSH-2.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5685 cda61777-01e9-0310-a592-d414129be87e

19 years agomkunxarc.sh is supposed to be silent, so I'm having it discard the
simon [Wed, 27 Apr 2005 08:09:32 +0000 (08:09 +0000)]
mkunxarc.sh is supposed to be silent, so I'm having it discard the
stderr output from mkauto.sh. (I debated discarding it within
mkauto.sh itself, but decided against it.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5684 cda61777-01e9-0310-a592-d414129be87e

19 years agoAccording to the termio(7I) on Solaris, OLCUC is overridden by OPOST, so we
ben [Tue, 26 Apr 2005 00:03:50 +0000 (00:03 +0000)]
According to the termio(7I) on Solaris, OLCUC is overridden by OPOST, so we
should send it with the SSH terminal modes too.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5680 cda61777-01e9-0310-a592-d414129be87e

19 years agoSquash OPOST locally when we're not in line-editing mode, and propagate
ben [Mon, 25 Apr 2005 23:57:45 +0000 (23:57 +0000)]
Squash OPOST locally when we're not in line-editing mode, and propagate
the other output flags with SSH.  This means that when I log into a remote
system using Plink and then run "stty -onlcr" I get the expected
stair-stepping.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5679 cda61777-01e9-0310-a592-d414129be87e

19 years agoUse pututxline() in place of pututline(), since the former is standardised by
ben [Mon, 25 Apr 2005 23:28:25 +0000 (23:28 +0000)]
Use pututxline() in place of pututline(), since the former is standardised by
X/Open and actually seems to be more common (NetBSD has it).  Also use
updwtmpx() rather than directly writing to the wtmpx file, though more for
reasons of aesthetics than anything practical.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5678 cda61777-01e9-0310-a592-d414129be87e

19 years agoAsk GDK to give us reasonable approximations if it can't get precisely the
ben [Mon, 25 Apr 2005 22:46:08 +0000 (22:46 +0000)]
Ask GDK to give us reasonable approximations if it can't get precisely the
colours we asked it for.  This means that I can run pterm on an 8-bit
PseudoColor display even if I have another program running.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5677 cda61777-01e9-0310-a592-d414129be87e

19 years agoCheck for <sys/sockio.h> and include it in uxnet.c if we find it. It's
ben [Mon, 25 Apr 2005 18:51:15 +0000 (18:51 +0000)]
Check for <sys/sockio.h> and include it in uxnet.c if we find it.  It's
necessary on Solaris if we want to use SIOCATMARK.  Using sockatmark() might
be preferable, but despite being notionally standard it's missing on
Solaris 9 and Mac OS X 10.3.9, whereas everyone seems to have SIOCATMARK
somewhere.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5676 cda61777-01e9-0310-a592-d414129be87e

19 years agouxpty.c uses non-X/Open facilities (notably strsignal()), so don't define
ben [Mon, 25 Apr 2005 17:21:08 +0000 (17:21 +0000)]
uxpty.c uses non-X/Open facilities (notably strsignal()), so don't define
_XOPEN_SOURCE.  We do still need _GNU_SOURCE in order to get grantpt()
on GNU systems.  This allows uxpty.c to compile on NetBSD.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5675 cda61777-01e9-0310-a592-d414129be87e

19 years agoMove generation of the "configure" script into its own script so that
ben [Mon, 25 Apr 2005 16:36:43 +0000 (16:36 +0000)]
Move generation of the "configure" script into its own script so that
people who check the code out of Subversion can get it to go.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5674 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd a mechanism for using autoconf to detect the quirks of Unix systems
ben [Mon, 25 Apr 2005 15:55:06 +0000 (15:55 +0000)]
Add a mechanism for using autoconf to detect the quirks of Unix systems
rather than relying on the user to edit the Makefile.  Makefile.gtk
still works as well as it ever did, but now we get a Makefile.in alongside
it.  mkunxarc.sh now relies on autoconf and friends to build the configure
script for the Unix source distribution.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5673 cda61777-01e9-0310-a592-d414129be87e

19 years agoOn some systems (NetBSD 1.6 and Solaris 9, at least), GCC doesn't understand
ben [Sun, 24 Apr 2005 14:43:00 +0000 (14:43 +0000)]
On some systems (NetBSD 1.6 and Solaris 9, at least), GCC doesn't understand
the semantics of assert(0) and believes it can return.  Add a gratuitous
exit(1) to convince it that this won't happen, and hence quell a couple of
warnings about variables' being used uninitialised.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5669 cda61777-01e9-0310-a592-d414129be87e

19 years agoNow that we've got at least some SDCTR modes working (and aes256-ctr is our
ben [Sat, 23 Apr 2005 16:22:51 +0000 (16:22 +0000)]
Now that we've got at least some SDCTR modes working (and aes256-ctr is our
default preferred cipher), add code to inject SSH_MSG_IGNOREs to randomise
the IV when using CBC-mode ciphers.  Each cipher has a flag to indicate
whether it needs this workaround, and the SSH packet output maze has gained
some extra complexity to implement it.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5659 cda61777-01e9-0310-a592-d414129be87e

19 years agoStir in process ID at start.
jacob [Fri, 22 Apr 2005 15:47:28 +0000 (15:47 +0000)]
Stir in process ID at start.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5655 cda61777-01e9-0310-a592-d414129be87e

19 years agoChange proxy-dns `Auto' default for SOCKS5 from local DNS to remote DNS.
jacob [Fri, 22 Apr 2005 00:00:49 +0000 (00:00 +0000)]
Change proxy-dns `Auto' default for SOCKS5 from local DNS to remote DNS.
SOCKS5 should always be able to do this, and I suspect our not doing so
dates from when the SOCKS proxy types were under a single configuration
option (pre-r3168).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5654 cda61777-01e9-0310-a592-d414129be87e

19 years agoFirst crack at `terminal-modes' in SSH. PuTTY now sends ERASE by default,
jacob [Thu, 21 Apr 2005 13:57:08 +0000 (13:57 +0000)]
First crack at `terminal-modes' in SSH. PuTTY now sends ERASE by default,
Unix Plink sends everything sensible it can find, and it's fully configurable
from the GUI.

I'm not entirely sure about the precise set of modes that Unix Plink should
look at; informed tweaks are welcome.

Also the Mac bits are guesses (but trivial).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5653 cda61777-01e9-0310-a592-d414129be87e

19 years agoIfdef out the actual code supporting 3des-ctr and blowfish-ctr, since GCC
ben [Wed, 20 Apr 2005 22:52:54 +0000 (22:52 +0000)]
Ifdef out the actual code supporting 3des-ctr and blowfish-ctr, since GCC
now notices that it isn't used.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5652 cda61777-01e9-0310-a592-d414129be87e

19 years agoSimon (accidentally, I think) enabled 3des-ctr and blowfish-ctr. Turn them
ben [Wed, 20 Apr 2005 22:47:29 +0000 (22:47 +0000)]
Simon (accidentally, I think) enabled 3des-ctr and blowfish-ctr.  Turn them
back off again since they're still untested.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5651 cda61777-01e9-0310-a592-d414129be87e

19 years agoMinimally document our support of aes*-ctr.
ben [Wed, 20 Apr 2005 21:29:57 +0000 (21:29 +0000)]
Minimally document our support of aes*-ctr.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5650 cda61777-01e9-0310-a592-d414129be87e

19 years agoEnable arcfour256-draft-00@putty.projects.tartarus.org, since I've now tested
ben [Wed, 20 Apr 2005 20:57:00 +0000 (20:57 +0000)]
Enable arcfour256-draft-00@putty.projects.tartarus.org, since I've now tested
it against an independent implementation.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5649 cda61777-01e9-0310-a592-d414129be87e

19 years agoInvent a way of specifying control characters numerically in ctrlparse():
jacob [Tue, 19 Apr 2005 19:18:14 +0000 (19:18 +0000)]
Invent a way of specifying control characters numerically in ctrlparse():
^<27>, ^<0x1B>, ^<033>. (This doesn't tread on any syntax that already had a
non-null behaviour.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5647 cda61777-01e9-0310-a592-d414129be87e

19 years agoPull out parsing of ^C style strings from the terminal answerback code to
jacob [Tue, 19 Apr 2005 18:58:29 +0000 (18:58 +0000)]
Pull out parsing of ^C style strings from the terminal answerback code to
its own function, since I'll be wanting it for `terminal-modes'.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5646 cda61777-01e9-0310-a592-d414129be87e

19 years agoRemove "none" from the MACs we offer to support in SSH-2. (It was at the
jacob [Tue, 19 Apr 2005 13:27:21 +0000 (13:27 +0000)]
Remove "none" from the MACs we offer to support in SSH-2. (It was at the
end, after the REQUIRED "hmac-sha1".) This has been present since SSH-2
support was introduced (r569).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5643 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd ability to construct SSH-1 packets incrementally (not used yet).
jacob [Mon, 18 Apr 2005 21:09:58 +0000 (21:09 +0000)]
Add ability to construct SSH-1 packets incrementally (not used yet).
I've added this to support `terminal-modes', but since this unifies some
SSH-1 and SSH-2 packet construction code, it saves a few hundred bytes.
Bonus.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5642 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd a comment describing `dummyitem' in prefslist and associated problems.
jacob [Mon, 18 Apr 2005 12:21:53 +0000 (12:21 +0000)]
Add a comment describing `dummyitem' in prefslist and associated problems.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5641 cda61777-01e9-0310-a592-d414129be87e

19 years agoRecent CTR mode changes stopped OS X PuTTY from compiling, because
simon [Mon, 18 Apr 2005 10:01:57 +0000 (10:01 +0000)]
Recent CTR mode changes stopped OS X PuTTY from compiling, because
-Werror objects at various static data items being defined but not
used. Ifdef some things out to restore warning-free compilability.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5640 cda61777-01e9-0310-a592-d414129be87e

19 years agoIndex "Event Log", "system menu", and "context menu" better.
ben [Fri, 15 Apr 2005 13:11:27 +0000 (13:11 +0000)]
Index "Event Log", "system menu", and "context menu" better.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5636 cda61777-01e9-0310-a592-d414129be87e

19 years agoImplement my experimental arcfour modes. The 256-bit version is disabled
ben [Thu, 14 Apr 2005 22:58:29 +0000 (22:58 +0000)]
Implement my experimental arcfour modes.  The 256-bit version is disabled
until I can test it against someone else's implementation.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5633 cda61777-01e9-0310-a592-d414129be87e

19 years agoUnify GET_32BIT()/PUT_32BIT() et al from numerous source files into misc.h.
jacob [Tue, 12 Apr 2005 20:04:56 +0000 (20:04 +0000)]
Unify GET_32BIT()/PUT_32BIT() et al from numerous source files into misc.h.
I've done a bit of testing (not exhaustive), and I don't _think_ I've broken
anything...

git-svn-id: svn://svn.tartarus.org/sgt/putty@5632 cda61777-01e9-0310-a592-d414129be87e

19 years agoComment: change "window.c" to "the front end"
jacob [Mon, 11 Apr 2005 17:37:02 +0000 (17:37 +0000)]
Comment: change "window.c" to "the front end"

git-svn-id: svn://svn.tartarus.org/sgt/putty@5628 cda61777-01e9-0310-a592-d414129be87e

19 years agoFactor out the code to read and write the Environment and PortForwardings
jacob [Mon, 11 Apr 2005 16:24:58 +0000 (16:24 +0000)]
Factor out the code to read and write the Environment and PortForwardings
mappings into two new functions.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5627 cda61777-01e9-0310-a592-d414129be87e

19 years agoRetire winctrls.c:multiedit() in favour of a new simpler function for a
jacob [Mon, 11 Apr 2005 16:23:35 +0000 (16:23 +0000)]
Retire winctrls.c:multiedit() in favour of a new simpler function for a
single full-width edit box. multiedit()'s extra functionality has been
superseded by the "columns" mechanism, and it didn't allow an edit box to
be created with no label.

Also add no-label capability to a couple of other controls.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5626 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd WS_VSCROLL style to drop-down non-combo boxes, to add a scroll bar
jacob [Sat, 9 Apr 2005 23:02:55 +0000 (23:02 +0000)]
Add WS_VSCROLL style to drop-down non-combo boxes, to add a scroll bar
if needed. (Doesn't affect the appearance of any existing controls.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5621 cda61777-01e9-0310-a592-d414129be87e

19 years agoTone down canonical-name resolution when using getaddrinfo(). Previously
jacob [Thu, 7 Apr 2005 22:33:42 +0000 (22:33 +0000)]
Tone down canonical-name resolution when using getaddrinfo(). Previously
we were doing a forward+reverse lookup, which seems above and beyond the
call of duty, especially given that getaddrinfo() can be persuaded to
return a canonical name (this is what unix/uxnet.c does).

Unfortunately, I'm unable to test this at all as Win98 doesn't have
getaddrinfo(); hopefully I'll be able to find a mug with a modern version
of Windows to check it's not completely broken.

I think the effects of this are mostly cosmetic -- the canonical name is
used for window titles (and some people have been annoyed at the new
behaviour), other displays, and probably also for proxy exclusions.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5614 cda61777-01e9-0310-a592-d414129be87e

19 years agoI always get a lot of personal mail about PuTTY when I send out a
simon [Thu, 7 Apr 2005 12:38:17 +0000 (12:38 +0000)]
I always get a lot of personal mail about PuTTY when I send out a
release announcement, because people reply directly to the
putty-announce mail. I should remember to set a Reply-To header next
time.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5613 cda61777-01e9-0310-a592-d414129be87e

19 years agoOops, forgot to credit Ahmad Khalifa of arabeyes.org for the bidi/shaping work.
jacob [Thu, 7 Apr 2005 12:00:01 +0000 (12:00 +0000)]
Oops, forgot to credit Ahmad Khalifa of arabeyes.org for the bidi/shaping work.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5612 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd keyboard accelerators for IPv4/IPv6 selections options.
jacob [Thu, 7 Apr 2005 01:42:36 +0000 (01:42 +0000)]
Add keyboard accelerators for IPv4/IPv6 selections options.
(Also for `window_border'.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5610 cda61777-01e9-0310-a592-d414129be87e

19 years agoIf a new session was saved from Change Settings, a side-effect on Windows was
jacob [Thu, 7 Apr 2005 01:36:28 +0000 (01:36 +0000)]
If a new session was saved from Change Settings, a side-effect on Windows was
that the global `sesslist' got out of sync with the saved-sessions submenu,
causing the latter to launch the wrong sessions.

Also, Change Settings wasn't getting a fresh session list, so if the set of
sessions had changed since session startup it wouldn't reflect that (at least
until a session was saved). Fixed (on all platforms).

Therefore, since the global sesslist didn't seem to be useful, I've got rid
of it; config.c creates one as needed, as do the frontends. (Not tried
compiling Mac changes.)

Also, we now build the saved-sessions submenu on demand on Windows and Unix.
(This should probably also be done on the Mac.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5609 cda61777-01e9-0310-a592-d414129be87e

19 years agoIn get_sesslist(), when freeing, set freed members to NULL on general
jacob [Thu, 7 Apr 2005 01:32:41 +0000 (01:32 +0000)]
In get_sesslist(), when freeing, set freed members to NULL on general
principles.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5608 cda61777-01e9-0310-a592-d414129be87e

19 years agoRemove support for the "rijndael256-cbc", "rijndael192-cbc", and
ben [Wed, 6 Apr 2005 23:40:30 +0000 (23:40 +0000)]
Remove support for the "rijndael256-cbc", "rijndael192-cbc", and
"rijndael128-cbc" names for AES.  These are in the IANA namespace, but
never appeared in any secsh-transport draft, and no version of OpenSSH
has supported them without also supporting the aes*-cbc names.

"rijndael-cbc@lysator.liu.se" gets to live because it's in the private
namespace.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5607 cda61777-01e9-0310-a592-d414129be87e

19 years agoImplement SDCTR modes, as defined in the newmodes draft. This adds
ben [Wed, 6 Apr 2005 23:27:08 +0000 (23:27 +0000)]
Implement SDCTR modes, as defined in the newmodes draft.  This adds
aes128-ctr, aes192-ctr, and aes256-ctr.  blowfish-ctr and 3des-ctr are
present but disabled, since I haven't tested them yet.

In addition, change the user-visible names of ciphers (as displayed in the
Event Log) to include the mode name and, in Blowfish's case, the key size.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5605 cda61777-01e9-0310-a592-d414129be87e

19 years ago`xp-wont-run': Apparently my application-manifest trims of r5534 aren't
jacob [Wed, 6 Apr 2005 22:16:42 +0000 (22:16 +0000)]
`xp-wont-run': Apparently my application-manifest trims of r5534 aren't
acceptable on all versions of XP. Bah. Revert to pre-r5534 format (but
keep version number as 0.0.0.0). People who've had this problem have
reported putty.mft to make it go away.

NB, putting these updated manifests alongside the executable (e.g. as
`putty.exe.manifest') is also reported to work.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5604 cda61777-01e9-0310-a592-d414129be87e

19 years agoVersion number and other tweakings prior to the 0.58 release.
simon [Tue, 5 Apr 2005 19:36:25 +0000 (19:36 +0000)]
Version number and other tweakings prior to the 0.58 release.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5598 cda61777-01e9-0310-a592-d414129be87e

19 years agotweak wording in "pscp -ls"
jacob [Tue, 5 Apr 2005 18:38:26 +0000 (18:38 +0000)]
tweak wording in "pscp -ls"

git-svn-id: svn://svn.tartarus.org/sgt/putty@5597 cda61777-01e9-0310-a592-d414129be87e

19 years agoadd XXX-REMOVE-BEFORE-RELEASE re uninstaller
jacob [Tue, 5 Apr 2005 18:15:41 +0000 (18:15 +0000)]
add XXX-REMOVE-BEFORE-RELEASE re uninstaller

git-svn-id: svn://svn.tartarus.org/sgt/putty@5596 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd target to build `info' file.
jacob [Tue, 5 Apr 2005 18:11:31 +0000 (18:11 +0000)]
Add target to build `info' file.
We probably already require a new enough version of Halibut that this isn't
a problem; nevertheless, I've put it in a separate target for now.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5595 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd versionid for index.
jacob [Tue, 5 Apr 2005 18:03:13 +0000 (18:03 +0000)]
Add versionid for index.
Also plumb in pgpkeys.but versionid.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5594 cda61777-01e9-0310-a592-d414129be87e

19 years agoIndex the complete PuTTY manual.
jacob [Tue, 5 Apr 2005 18:01:32 +0000 (18:01 +0000)]
Index the complete PuTTY manual.
This was a bit rushed, and could doubtless be improved.
Also fix a couple of things I noted on the way, including:
 - "pscp -ls" wasn't documented
 - Windows XP wasn't mentioned enough

git-svn-id: svn://svn.tartarus.org/sgt/putty@5593 cda61777-01e9-0310-a592-d414129be87e

19 years agoNULL needs to be cast to void * when passed to a variadic function like
ben [Mon, 4 Apr 2005 13:44:45 +0000 (13:44 +0000)]
NULL needs to be cast to void * when passed to a variadic function like
execl().  Spotted by Damien Miller.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5592 cda61777-01e9-0310-a592-d414129be87e

19 years ago#ifdef out expensive combining-character/scrollback diagnostics (for now).
jacob [Fri, 1 Apr 2005 13:25:13 +0000 (13:25 +0000)]
#ifdef out expensive combining-character/scrollback diagnostics (for now).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5589 cda61777-01e9-0310-a592-d414129be87e

19 years agosk_address_is_local() was ignoring the possibility that a SockAddr
simon [Fri, 1 Apr 2005 08:46:26 +0000 (08:46 +0000)]
sk_address_is_local() was ignoring the possibility that a SockAddr
might have an IPv4 address in `ai' rather than in `addresses'.
Thanks to Martin Prikryl for pointing this out.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5587 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd text to the troubleshooting chapter about the errors that can be
simon [Thu, 31 Mar 2005 18:52:21 +0000 (18:52 +0000)]
Add text to the troubleshooting chapter about the errors that can be
caused when an active connection times out due to outgoing data
exceeding its maximum number of retries, and mention that this can
occur even when you didn't think you'd sent anything due to rekeys
and/or keepalives.

Unix generates ETIMEDOUT in this situation. Windows, it turns out
after doing an actual experiment by disabling my firewall, generates
ECONNABORTED! So _that's_ what it means under Windows. I wish I'd
done this experiment years ago now.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5585 cda61777-01e9-0310-a592-d414129be87e

19 years agoFAQ entry on rekeys: Jacob would like to pre-emptively try to avoid
simon [Thu, 31 Mar 2005 13:45:41 +0000 (13:45 +0000)]
FAQ entry on rekeys: Jacob would like to pre-emptively try to avoid
the possibility of people falling back to SSH-1 just because it gets
rid of the irritating delays.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5584 cda61777-01e9-0310-a592-d414129be87e

19 years agoBeef up the `unfinished and experimental' warnings for the two Mac
simon [Thu, 31 Mar 2005 12:25:48 +0000 (12:25 +0000)]
Beef up the `unfinished and experimental' warnings for the two Mac
ports, mentioning in particular that even if you downloaded a
_release_ source archive these particular ports are not considered
to be of release quality.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5583 cda61777-01e9-0310-a592-d414129be87e

19 years agoXXX-REMOVE-BEFORE-RELEASE: check docs too
jacob [Thu, 31 Mar 2005 09:02:07 +0000 (09:02 +0000)]
XXX-REMOVE-BEFORE-RELEASE: check docs too

git-svn-id: svn://svn.tartarus.org/sgt/putty@5574 cda61777-01e9-0310-a592-d414129be87e

19 years agoFurther fix for lcc-win32. The PuTTY suite now compiles fine for me
simon [Wed, 30 Mar 2005 19:33:24 +0000 (19:33 +0000)]
Further fix for lcc-win32. The PuTTY suite now compiles fine for me
using lcc-win32 v3.8 (compilation date Mar 2 2005 18:40:17) provided
I pass COMPAT="-DNO_IPV6 -DNO_MULTIMON" on the command line.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5573 cda61777-01e9-0310-a592-d414129be87e

19 years agofaq-timeout: update for XP
jacob [Wed, 30 Mar 2005 10:20:31 +0000 (10:20 +0000)]
faq-timeout: update for XP

git-svn-id: svn://svn.tartarus.org/sgt/putty@5565 cda61777-01e9-0310-a592-d414129be87e

19 years ago<1112163342.018492.101240@f14g2000cwb.googlegroups.com> on
simon [Wed, 30 Mar 2005 08:27:54 +0000 (08:27 +0000)]
<1112163342.018492.101240@f14g2000cwb.googlegroups.com> on
comp.security.ssh contains a Dr Watson log which looks to me as if
`unclean-close-crash' occurred due to a rekey timer going off after
the session had closed. Hence, ssh2_timer() now avoids doing
anything if the session is already closed, and also ssh_do_close()
proactively calls expire_timer_context(). Between those I think they
ought to solve the problem.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5564 cda61777-01e9-0310-a592-d414129be87e

19 years agoSmall markup fixes I just noticed, mostly use of literal double
simon [Tue, 29 Mar 2005 14:24:14 +0000 (14:24 +0000)]
Small markup fixes I just noticed, mostly use of literal double
quotes where \q{} would be better.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5562 cda61777-01e9-0310-a592-d414129be87e

19 years agoAfter we receive EOF on stdin, we should clear ssh->send_ok so that
simon [Tue, 29 Mar 2005 13:10:33 +0000 (13:10 +0000)]
After we receive EOF on stdin, we should clear ssh->send_ok so that
we stop trying to read anything further from stdin. Otherwise we
send a continuous stream of SSH2_MSG_CHANNEL_EOF.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5561 cda61777-01e9-0310-a592-d414129be87e

19 years agoRender timing.c robust in the face of strangeness. The strangenesses
simon [Mon, 28 Mar 2005 17:48:24 +0000 (17:48 +0000)]
Render timing.c robust in the face of strangeness. The strangenesses
in question vary per OS: on Windows the problem is that WM_TIMER
sometimes goes off too early, so that GetTickCount() is right and
the callback time is wrong, whereas on Unix the problem is that my
GETTICKCOUNT implementation comes from the system clock which means
it can change suddenly and non-monotonically if the sysadmin is
messing about (meaning that the timing of callbacks from GTK or
select timeouts is _more_ likely to be right than GETTICKCOUNT).
This checkin provides band-aid workarounds for both problems, which
aren't pretty but ought to at least prevent catastrophic assertion
failure.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5556 cda61777-01e9-0310-a592-d414129be87e

19 years agoIn fact, I'll document the wrinkle with "plink -load", rather than just
jacob [Thu, 24 Mar 2005 02:22:21 +0000 (02:22 +0000)]
In fact, I'll document the wrinkle with "plink -load", rather than just
wittering about it on a mailing list.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5550 cda61777-01e9-0310-a592-d414129be87e

19 years agoFix comment re dmemdumpl()
jacob [Thu, 24 Mar 2005 01:01:24 +0000 (01:01 +0000)]
Fix comment re dmemdumpl()

git-svn-id: svn://svn.tartarus.org/sgt/putty@5549 cda61777-01e9-0310-a592-d414129be87e

19 years agoSince Markus Kuhn no longer explicitly places wcwidth.c in the public domain,
jacob [Wed, 23 Mar 2005 20:23:07 +0000 (20:23 +0000)]
Since Markus Kuhn no longer explicitly places wcwidth.c in the public domain,
it'd probably be generous to list him in the copyrights.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5548 cda61777-01e9-0310-a592-d414129be87e

19 years ago`wcwidth-upgrade': upgrade to latest wcwidth.c from Markus Kuhn
jacob [Wed, 23 Mar 2005 20:04:08 +0000 (20:04 +0000)]
`wcwidth-upgrade': upgrade to latest wcwidth.c from Markus Kuhn
<http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c>.
This is identified both internally and in HTTP headers as 2003-05-20,
for Unicode 4.0.

Only changes from upstream are to make mk_wcwidth_cjk() non-static and to
#include "putty.h" for prototypes.

The status of some code points has changed; see the wishlist item. We've
had some feedback from the CJK and Arabic communities that upgrading is
probably the right thing to do.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5547 cda61777-01e9-0310-a592-d414129be87e

19 years agoAnother fix from Hung-Te Lin; apparently in some IMEs (such as
jacob [Wed, 23 Mar 2005 01:08:18 +0000 (01:08 +0000)]
Another fix from Hung-Te Lin; apparently in some IMEs (such as
"MS NewPhonetics"), move events (arrow keys) were being doubled up,
apparently because we turned both KEYDOWN and KEYUP events into new
KEYDOWN events.

I don't claim to understand the precise effect of this patch :( but
I'm reasonably confident that it only affects IME users, and experimentally
it doesn't seem to break anything obvious, so if piaip says it makes
things better that's good enough for me :)

git-svn-id: svn://svn.tartarus.org/sgt/putty@5545 cda61777-01e9-0310-a592-d414129be87e

19 years agoFix my fix (r5539) to the `multi-changesettings-crash' fix. Ahem.
jacob [Tue, 22 Mar 2005 23:25:21 +0000 (23:25 +0000)]
Fix my fix (r5539) to the `multi-changesettings-crash' fix. Ahem.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5543 cda61777-01e9-0310-a592-d414129be87e

19 years agoAdd an option to use wcwidth_cjk() instead of wcwidth(), as several people
jacob [Tue, 22 Mar 2005 23:20:23 +0000 (23:20 +0000)]
Add an option to use wcwidth_cjk() instead of wcwidth(), as several people
have asked for it.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5542 cda61777-01e9-0310-a592-d414129be87e

19 years agoHung-Te Lin spotted that the `multi-changesettings-crash' workaround for Windows
jacob [Mon, 21 Mar 2005 22:20:22 +0000 (22:20 +0000)]
Hung-Te Lin spotted that the `multi-changesettings-crash' workaround for Windows
would prevent a user opening Change Settings if they'd cancelled a previous
Change Settings.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5539 cda61777-01e9-0310-a592-d414129be87e

19 years agoMention PUTTY.RND by name
jacob [Mon, 21 Mar 2005 17:43:59 +0000 (17:43 +0000)]
Mention PUTTY.RND by name

git-svn-id: svn://svn.tartarus.org/sgt/putty@5538 cda61777-01e9-0310-a592-d414129be87e

19 years agoMartin Trautmann spotted a bare char being passed to isspace.
simon [Mon, 21 Mar 2005 13:46:16 +0000 (13:46 +0000)]
Martin Trautmann spotted a bare char being passed to isspace.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5536 cda61777-01e9-0310-a592-d414129be87e

19 years agoTrim application manifests as much as MS' documentation and Owen's experiments
jacob [Mon, 21 Mar 2005 01:51:22 +0000 (01:51 +0000)]
Trim application manifests as much as MS' documentation and Owen's experiments
on XP allow while still having the desired effect -- this allows removal of
some fibs.
Also, change version number to 0.0.0.0 in preparation for `win-versioninfo'
(not that we found anything that took any notice of the version number
declared here).

git-svn-id: svn://svn.tartarus.org/sgt/putty@5534 cda61777-01e9-0310-a592-d414129be87e

19 years agoImprovement for IME font display from Hung-Te Lin.
jacob [Mon, 21 Mar 2005 01:05:38 +0000 (01:05 +0000)]
Improvement for IME font display from Hung-Te Lin.
Not tested, but it appears only to affect Glenn Maynard's r1406 code from
<20011006170741.A23470@zewt.org> and nothing else, so seems harmless enough.

git-svn-id: svn://svn.tartarus.org/sgt/putty@5533 cda61777-01e9-0310-a592-d414129be87e