u/mdw/putty
17 years agoCreate installations directories before installing into them, like GNU
ben [Mon, 30 Apr 2007 20:09:58 +0000 (20:09 +0000)]
Create installations directories before installing into them, like GNU
packages do.

Problem reported by Manfred Pausch.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7494 cda61777-01e9-0310-a592-d414129be87e

17 years agoUpdate version numbers for 0.60 release.
simon [Sun, 29 Apr 2007 11:28:54 +0000 (11:28 +0000)]
Update version numbers for 0.60 release.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7488 cda61777-01e9-0310-a592-d414129be87e

17 years agoAvoid creating the Session/hostport control set in mid-session.
simon [Sun, 22 Apr 2007 14:39:01 +0000 (14:39 +0000)]
Avoid creating the Session/hostport control set in mid-session.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7477 cda61777-01e9-0310-a592-d414129be87e

17 years agoCapitalisation error.
simon [Sun, 22 Apr 2007 08:56:31 +0000 (08:56 +0000)]
Capitalisation error.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7476 cda61777-01e9-0310-a592-d414129be87e

17 years agoWhen we get an error writing to a local file, stop the download rather than
ben [Tue, 10 Apr 2007 21:46:44 +0000 (21:46 +0000)]
When we get an error writing to a local file, stop the download rather than
pretending we just got -1 bytes.  Not actually tested, but it looks pretty
obvious.
Bug reported by dking wang.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7459 cda61777-01e9-0310-a592-d414129be87e

17 years agoWhen the comments say `if we're in restart mode', the code in
simon [Mon, 2 Apr 2007 08:44:00 +0000 (08:44 +0000)]
When the comments say `if we're in restart mode', the code in
question should actually be conditional on restart mode!

git-svn-id: svn://svn.tartarus.org/sgt/putty@7438 cda61777-01e9-0310-a592-d414129be87e

17 years agoIn the wake of r7415, let's have some better error reporting.
simon [Tue, 27 Mar 2007 19:10:10 +0000 (19:10 +0000)]
In the wake of r7415, let's have some better error reporting.
Instead of passing -1 to its gotdata and sentdata callbacks on
error, winhandl.c will now pass the negation of the Windows error
number; and the Plink front end will now format that into an error
message and pass it on to the user.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7416 cda61777-01e9-0310-a592-d414129be87e

17 years agoWindows apparently sends ERROR_BROKEN_PIPE when a pipe we're reading
simon [Tue, 27 Mar 2007 18:49:59 +0000 (18:49 +0000)]
Windows apparently sends ERROR_BROKEN_PIPE when a pipe we're reading
from is closed normally from the writing end. This is ludicrous; if
that situation isn't a natural EOF, _nothing_ is. So if we get that
particular error, we pretend it's EOF.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7415 cda61777-01e9-0310-a592-d414129be87e

17 years agoPatch from John Sullivan: process double-clicks in the session list
simon [Tue, 27 Mar 2007 18:16:36 +0000 (18:16 +0000)]
Patch from John Sullivan: process double-clicks in the session list
box on button-up rather than button-down. The effect of this is that
if a saved session is already selected in the list box and then you
double-click it, it will open rather than beeping annoyingly.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7414 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix a stupid one-character typo that was breaking 256-colour support on GTK.
ben [Mon, 19 Mar 2007 12:05:34 +0000 (12:05 +0000)]
Fix a stupid one-character typo that was breaking 256-colour support on GTK.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7403 cda61777-01e9-0310-a592-d414129be87e

17 years agoget_random_data() can return NULL (for instance, if we can't open /dev/random
jacob [Tue, 13 Mar 2007 14:43:14 +0000 (14:43 +0000)]
get_random_data() can return NULL (for instance, if we can't open /dev/random
on Unix), yet cmdgen failed to deal with this. Spotted by Darren Tucker.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7396 cda61777-01e9-0310-a592-d414129be87e

17 years agoProcess -t/-T later than -m, so that they can override -m's default behaviour
jacob [Wed, 28 Feb 2007 23:31:49 +0000 (23:31 +0000)]
Process -t/-T later than -m, so that they can override -m's default behaviour
of no pty.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7348 cda61777-01e9-0310-a592-d414129be87e

17 years agoPrepend \\.\ to configured serial line string, to allow easy access to ports
jacob [Wed, 28 Feb 2007 21:30:06 +0000 (21:30 +0000)]
Prepend \\.\ to configured serial line string, to allow easy access to ports
above COM9.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7345 cda61777-01e9-0310-a592-d414129be87e

17 years agoAttempt to scrub -pw's argument in argv[], to make it less obvious.
jacob [Sun, 25 Feb 2007 02:15:20 +0000 (02:15 +0000)]
Attempt to scrub -pw's argument in argv[], to make it less obvious.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7323 cda61777-01e9-0310-a592-d414129be87e

17 years agoDelay evaluating the "-pw" option, so we can criticise the user's choice of
jacob [Sun, 25 Feb 2007 00:51:38 +0000 (00:51 +0000)]
Delay evaluating the "-pw" option, so we can criticise the user's choice of
backend, bailing out if anything other than SSH is in use.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7322 cda61777-01e9-0310-a592-d414129be87e

17 years agoSince r7265, a user could not launch a PuTTY session to a specific host by
jacob [Sun, 25 Feb 2007 00:50:24 +0000 (00:50 +0000)]
Since r7265, a user could not launch a PuTTY session to a specific host by
simply specifying a hostname on the command line -- this would bring up the
config dialog. Use a slightly more sophisticated notion of whether the user
meant to launch a session.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7321 cda61777-01e9-0310-a592-d414129be87e

17 years ago"-noagent" and friends should be marked SAVEABLE, to ensure they're not
jacob [Sat, 24 Feb 2007 22:43:57 +0000 (22:43 +0000)]
"-noagent" and friends should be marked SAVEABLE, to ensure they're not
clobbered by "-load".

git-svn-id: svn://svn.tartarus.org/sgt/putty@7320 cda61777-01e9-0310-a592-d414129be87e

17 years agoGareth pointed out yesterday that the Unix terminal front end treats
simon [Sat, 24 Feb 2007 13:36:11 +0000 (13:36 +0000)]
Gareth pointed out yesterday that the Unix terminal front end treats
BELL_DISABLED as BELL_DEFAULT. How embarrassing.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7316 cda61777-01e9-0310-a592-d414129be87e

17 years agoThis reordering of the Unix Makefiles (requested by Michael Shigorin) allows
jacob [Sun, 18 Feb 2007 22:05:45 +0000 (22:05 +0000)]
This reordering of the Unix Makefiles (requested by Michael Shigorin) allows
use of -Wl,--as-needed.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7299 cda61777-01e9-0310-a592-d414129be87e

17 years agoIn controls where a list of entries is manipulated by Add/Remove buttons
jacob [Sun, 18 Feb 2007 19:56:16 +0000 (19:56 +0000)]
In controls where a list of entries is manipulated by Add/Remove buttons
(SSH tunnels, TTY modes, and environment variables), when the Remove button is
pressed, populate the edit controls from the entry that has just been deleted.

Several users have requested this, as it makes editing an entry easier (read-
modify-write) in the cases where order is unimportant, and also provides a
degree of undo-ability.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7298 cda61777-01e9-0310-a592-d414129be87e

17 years agoAllow dlg_listbox_index() to be called on multi-selection list boxes.
jacob [Sun, 18 Feb 2007 19:50:41 +0000 (19:50 +0000)]
Allow dlg_listbox_index() to be called on multi-selection list boxes.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7297 cda61777-01e9-0310-a592-d414129be87e

17 years agoBring the OS X front end up to date with recent changes to the main
simon [Sun, 18 Feb 2007 15:59:38 +0000 (15:59 +0000)]
Bring the OS X front end up to date with recent changes to the main
code base.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7296 cda61777-01e9-0310-a592-d414129be87e

17 years agoCtrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C).
jacob [Sun, 18 Feb 2007 14:02:39 +0000 (14:02 +0000)]
Ctrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C).

git-svn-id: svn://svn.tartarus.org/sgt/putty@7295 cda61777-01e9-0310-a592-d414129be87e

17 years agoUse preprocessor trickery to make the signal translation mechanism a little
ben [Sat, 17 Feb 2007 22:33:11 +0000 (22:33 +0000)]
Use preprocessor trickery to make the signal translation mechanism a little
less hideous.  The output of the preprocessor should be basically unchanged.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7294 cda61777-01e9-0310-a592-d414129be87e

17 years agossh2_set_window checks whether the channel is being closed, so there's no
ben [Sat, 17 Feb 2007 22:15:57 +0000 (22:15 +0000)]
ssh2_set_window checks whether the channel is being closed, so there's no
need to check that before calling it.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7293 cda61777-01e9-0310-a592-d414129be87e

17 years agoUnbreak "Duplicate session" on Windows, in a similar way to r7291.
jacob [Sat, 17 Feb 2007 17:44:24 +0000 (17:44 +0000)]
Unbreak "Duplicate session" on Windows, in a similar way to r7291.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7292 cda61777-01e9-0310-a592-d414129be87e

17 years agor7265 broke the legacy `putty @sessionname' construction, which I
simon [Fri, 16 Feb 2007 18:44:07 +0000 (18:44 +0000)]
r7265 broke the legacy `putty @sessionname' construction, which I
wouldn't care about except for the fact that it's still used to
implement the Saved Sessions menu item in PuTTY and Pageant.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7291 cda61777-01e9-0310-a592-d414129be87e

17 years agoLICENCE in the installer should have CP/M line endings.
jacob [Thu, 15 Feb 2007 23:27:29 +0000 (23:27 +0000)]
LICENCE in the installer should have CP/M line endings.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7290 cda61777-01e9-0310-a592-d414129be87e

17 years agoIt turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for
jacob [Tue, 13 Feb 2007 22:57:19 +0000 (22:57 +0000)]
It turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for
putting HTML Help into "single-threaded" mode. Furthermore, this requires
extra work from the application (message pumping via HH_PRETRANSLATEMESSAGE).

Thus, remove them and run Help in a secondary thread. This means that keyboard
input into the Index and Search tabs now works.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7285 cda61777-01e9-0310-a592-d414129be87e

17 years agoNote that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin.
jacob [Sun, 11 Feb 2007 20:27:05 +0000 (20:27 +0000)]
Note that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7273 cda61777-01e9-0310-a592-d414129be87e

17 years agochm.but contains $Id$ but didn't have a svn:keywords property. Fixed.
jacob [Sun, 11 Feb 2007 18:13:56 +0000 (18:13 +0000)]
chm.but contains $Id$ but didn't have a svn:keywords property. Fixed.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7272 cda61777-01e9-0310-a592-d414129be87e

17 years agoTypo.
jacob [Sun, 11 Feb 2007 18:09:03 +0000 (18:09 +0000)]
Typo.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7271 cda61777-01e9-0310-a592-d414129be87e

17 years agoSince we're now able to cope with Default Settings describing a
simon [Sat, 10 Feb 2007 17:12:06 +0000 (17:12 +0000)]
Since we're now able to cope with Default Settings describing a
launchable session without getting confused by it, we can relax the
restriction on storing a host name in DS, which has attracted a
steady stream of complaints over the past six or seven years.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7266 cda61777-01e9-0310-a592-d414129be87e

17 years agoAvoid launching a session from the Default Settings, even if they do
simon [Sat, 10 Feb 2007 17:02:41 +0000 (17:02 +0000)]
Avoid launching a session from the Default Settings, even if they do
represent a launchable session, unless the user can be construed to
have really meant it. This means:
 - starting up PuTTY when the Default Settings are launchable still
   brings up the config box, and you have to hit Open to actually
   launch that session
 - double-clicking on Default Settings from the config box will load
   them but not launch them.
On the other hand:
 - explicitly loading the Default Settings on the command line using
   `-load' _does_ still launch them.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7265 cda61777-01e9-0310-a592-d414129be87e

17 years agoMore svn:ignores. I'm constantly amazed that I keep not having put
simon [Sat, 10 Feb 2007 16:38:25 +0000 (16:38 +0000)]
More svn:ignores. I'm constantly amazed that I keep not having put
in all the useful ones yet!

git-svn-id: svn://svn.tartarus.org/sgt/putty@7264 cda61777-01e9-0310-a592-d414129be87e

17 years agoI've changed my mind about the PuTTY build script. It now delivers
simon [Thu, 8 Feb 2007 18:53:11 +0000 (18:53 +0000)]
I've changed my mind about the PuTTY build script. It now delivers
the release directory into a _subdirectory_ of the main build.out,
and delivers the link maps and sign.sh alongside it. That simplifies
both the nightly snapshot cron job (which now doesn't have to
carefully move the maps out of the release directory or go looking
in strange places for sign.sh) and my release procedure (for much
the same reasons).

git-svn-id: svn://svn.tartarus.org/sgt/putty@7258 cda61777-01e9-0310-a592-d414129be87e

17 years agoThe big payoff from bob (from my POV at least): the PuTTY release
simon [Thu, 8 Feb 2007 09:24:08 +0000 (09:24 +0000)]
The big payoff from bob (from my POV at least): the PuTTY release
procedure is now a huge amount less painful.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7249 cda61777-01e9-0310-a592-d414129be87e

17 years ago`installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in
jacob [Tue, 6 Feb 2007 22:39:15 +0000 (22:39 +0000)]
`installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in
the Windows source Zips. Rename to `puttyins.ico'.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7241 cda61777-01e9-0310-a592-d414129be87e

17 years agoWhen emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC,
ben [Tue, 6 Feb 2007 13:57:27 +0000 (13:57 +0000)]
When emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC,
remember to put an empty string in it rather than sending a completely
empty packet.  This should help with those servers (notably RomSShell)
that actually check the contents of SSH_MSG_IGNORE.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7236 cda61777-01e9-0310-a592-d414129be87e

17 years agoAhem; other half of r7232...
simon [Mon, 5 Feb 2007 20:14:17 +0000 (20:14 +0000)]
Ahem; other half of r7232...

git-svn-id: svn://svn.tartarus.org/sgt/putty@7233 cda61777-01e9-0310-a592-d414129be87e

17 years agoWhen calling TIOCSCTTY, it helps to pass it an fd that's still open,
simon [Mon, 5 Feb 2007 20:04:33 +0000 (20:04 +0000)]
When calling TIOCSCTTY, it helps to pass it an fd that's still open,
instead of one we closed two lines earlier. I apparently broke this
in r7107.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7232 cda61777-01e9-0310-a592-d414129be87e

17 years agoAvoid passing modified SVN revision numbers (of the form 1234M) to
simon [Mon, 5 Feb 2007 18:07:11 +0000 (18:07 +0000)]
Avoid passing modified SVN revision numbers (of the form 1234M) to
parts of the versioning code which might not like them.

As a result of this checkin, bob builds from modified SVN working
copies will still announce themselves as revision nnnnM in the
textual version strings, but their binary version in the Windows
VERSIONINFO will now be 0.0.0.0.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7231 cda61777-01e9-0310-a592-d414129be87e

17 years agoFiddle further with .htaccess: add some $s on the ends of the
simon [Mon, 5 Feb 2007 15:01:28 +0000 (15:01 +0000)]
Fiddle further with .htaccess: add some $s on the ends of the
regexps to stop them matching the wrong files.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7229 cda61777-01e9-0310-a592-d414129be87e

17 years agoHTTP redirects for the variably-named signatures as well as their
simon [Mon, 5 Feb 2007 14:23:34 +0000 (14:23 +0000)]
HTTP redirects for the variably-named signatures as well as their
base files. (The signatures aren't actually _generated_ by bob, of
course, but the redirects are harmless in their absence.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7228 cda61777-01e9-0310-a592-d414129be87e

17 years agoScript to generate signatures on the various PuTTY build outputs.
simon [Mon, 5 Feb 2007 13:53:48 +0000 (13:53 +0000)]
Script to generate signatures on the various PuTTY build outputs.
Saves me having to remember all the fiddly gpg arguments every time.
Should be usable for both releases (with manual passphrase input)
and snapshots (run automatically).

git-svn-id: svn://svn.tartarus.org/sgt/putty@7227 cda61777-01e9-0310-a592-d414129be87e

17 years agoFixes for snapshot building using bob. All of releases, snapshots
simon [Mon, 5 Feb 2007 12:49:24 +0000 (12:49 +0000)]
Fixes for snapshot building using bob. All of releases, snapshots
and custom svn builds should now have appropriately named Unix
source archives and installer binaries, plus .htaccess files
providing redirects to them from totally standard filenames. I
_think_ this now makes it feasible to switch the nightly builds to
using bob.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7226 cda61777-01e9-0310-a592-d414129be87e

17 years agoBe slightly more forgiving about the nature of SVN_REV; bob will be
simon [Mon, 5 Feb 2007 08:02:53 +0000 (08:02 +0000)]
Be slightly more forgiving about the nature of SVN_REV; bob will be
reliable at defining it, and it's useful to be able to pass `1234M'-
type revisions in for testing purposes.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7221 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix errors in $(Makeargs) which only occur when building development
simon [Mon, 5 Feb 2007 08:02:01 +0000 (08:02 +0000)]
Fix errors in $(Makeargs) which only occur when building development
snapshots.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7220 cda61777-01e9-0310-a592-d414129be87e

17 years agoPuTTY builds should save the map files.
simon [Sun, 4 Feb 2007 12:37:20 +0000 (12:37 +0000)]
PuTTY builds should save the map files.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7212 cda61777-01e9-0310-a592-d414129be87e

17 years agoVersion management updates for the new bob build script. There's now
simon [Sun, 4 Feb 2007 12:30:39 +0000 (12:30 +0000)]
Version management updates for the new bob build script. There's now
a fourth class of PuTTY version tags in addition to release,
snapshot and unidentified: we now have `Custom build r1234',
indicating a build made from that SVN revision in a context other
than that of a dated snapshot. The build script generates these when
it doesn't know what else to do; `unidentified builds' will now only
occur when you run nmake from the command line.

Also, the build script now generates sensible version data in the
installer to match this. So I _think_ we should now be set to use
bob to generate installer builds of the nightly snapshots, although
of course I'll have to wait until tomorrow to test one.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7211 cda61777-01e9-0310-a592-d414129be87e

17 years agoDocument \\.\COM10 faff on Windows.
jacob [Sun, 4 Feb 2007 12:12:52 +0000 (12:12 +0000)]
Document \\.\COM10 faff on Windows.
References:
<http://msdn2.microsoft.com/en-us/library/aa363858.aspx> (CreateFile() docs)
  describes the use of \\.\
<http://msdn2.microsoft.com/en-us/library/aa365247.aspx> ("Naming a File")
  lists the reserved filenames (COM1-COM9, LPT1-LPT9, CON, PRN, AUX, NUL)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7208 cda61777-01e9-0310-a592-d414129be87e

17 years agoBuild script for PuTTY using bob.
simon [Sun, 4 Feb 2007 11:17:45 +0000 (11:17 +0000)]
Build script for PuTTY using bob.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7205 cda61777-01e9-0310-a592-d414129be87e

17 years agoSwap order of `Columns' and `Rows' in the config dialog, to make it
jacob [Thu, 1 Feb 2007 23:24:30 +0000 (23:24 +0000)]
Swap order of `Columns' and `Rows' in the config dialog, to make it
consistent with sizetip.c (and more nebulous conventions).

git-svn-id: svn://svn.tartarus.org/sgt/putty@7196 cda61777-01e9-0310-a592-d414129be87e

17 years agoColin Watson has fixed the disgusting icons on GTK1. His patch
simon [Wed, 31 Jan 2007 12:30:48 +0000 (12:30 +0000)]
Colin Watson has fixed the disgusting icons on GTK1. His patch
appears to merely fix the background colour (arranging for it to
have transparency rather than being on some kind of default grey
background), but it turns out to also fix the strange blurry
behaviour I see in the GNOME Taskbar, for no very obvious reason.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7186 cda61777-01e9-0310-a592-d414129be87e

17 years agoIn the cases where Setup asks to restart the computer, explain exactly why this
jacob [Mon, 29 Jan 2007 20:10:51 +0000 (20:10 +0000)]
In the cases where Setup asks to restart the computer, explain exactly why this
is deemed necessary.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7179 cda61777-01e9-0310-a592-d414129be87e

17 years agoSwitch round the order of CFLAGS and XFLAGS, so that the latter
simon [Fri, 26 Jan 2007 19:43:15 +0000 (19:43 +0000)]
Switch round the order of CFLAGS and XFLAGS, so that the latter
comes last on the compiler command line. This makes it easier to
override the normal compile options (since conflicting command-line
options usually follow a last-wins policy) in order to compile (for
example) the Unix version -g -O0.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7170 cda61777-01e9-0310-a592-d414129be87e

17 years agoIf I'd tested under Minefield before releasing, r7168 would have
simon [Fri, 26 Jan 2007 14:11:56 +0000 (14:11 +0000)]
If I'd tested under Minefield before releasing, r7168 would have
been committed before the release. Therefore, stick it on the
checklist for next time.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7169 cda61777-01e9-0310-a592-d414129be87e

17 years agoKai Jourdan spotted a rather embarrassing double-free, and Minefield
simon [Fri, 26 Jan 2007 14:06:08 +0000 (14:06 +0000)]
Kai Jourdan spotted a rather embarrassing double-free, and Minefield
confirms that it's a real problem.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7168 cda61777-01e9-0310-a592-d414129be87e

17 years agoWe may as well update the website icon to match the other new ones.
jacob [Thu, 25 Jan 2007 00:14:01 +0000 (00:14 +0000)]
We may as well update the website icon to match the other new ones.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7153 cda61777-01e9-0310-a592-d414129be87e

17 years agoPost-release corrections to the checklist.
simon [Wed, 24 Jan 2007 21:43:11 +0000 (21:43 +0000)]
Post-release corrections to the checklist.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7151 cda61777-01e9-0310-a592-d414129be87e

17 years agoVersion number bumps, and associated changes, for the 0.59 release.
simon [Wed, 24 Jan 2007 20:16:33 +0000 (20:16 +0000)]
Version number bumps, and associated changes, for the 0.59 release.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7146 cda61777-01e9-0310-a592-d414129be87e

17 years agoAdd .CHM to the ignore property.
simon [Wed, 24 Jan 2007 20:00:19 +0000 (20:00 +0000)]
Add .CHM to the ignore property.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7145 cda61777-01e9-0310-a592-d414129be87e

17 years agoThe direct link between the terminal and the back end via
simon [Wed, 24 Jan 2007 13:53:28 +0000 (13:53 +0000)]
The direct link between the terminal and the back end via
term_provide_resize_fn() was not being broken when the back end was
destroyed on session termination, causing resizing an inactive PuTTY
to be a segfault hazard.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7143 cda61777-01e9-0310-a592-d414129be87e

17 years agofaq-xpwontrun wants tweaking before the next release.
jacob [Wed, 24 Jan 2007 11:20:14 +0000 (11:20 +0000)]
faq-xpwontrun wants tweaking before the next release.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7142 cda61777-01e9-0310-a592-d414129be87e

17 years agoMention XXX-REVIEW-BEFORE-RELEASE in the same place as
jacob [Tue, 23 Jan 2007 14:12:42 +0000 (14:12 +0000)]
Mention XXX-REVIEW-BEFORE-RELEASE in the same place as
XXX-REMOVE-BEFORE-RELEASE.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7141 cda61777-01e9-0310-a592-d414129be87e

17 years agoMention the potential networked-CHM problem in the post-installer
simon [Tue, 23 Jan 2007 11:38:11 +0000 (11:38 +0000)]
Mention the potential networked-CHM problem in the post-installer
README.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7140 cda61777-01e9-0310-a592-d414129be87e

17 years agoChecklist updates for the upcoming release, mostly to do with the
simon [Tue, 23 Jan 2007 11:15:56 +0000 (11:15 +0000)]
Checklist updates for the upcoming release, mostly to do with the
retirement of the Alpha build.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7139 cda61777-01e9-0310-a592-d414129be87e

17 years agoAdd an icon for the PuTTY installer. Design concept (and noticing
simon [Mon, 22 Jan 2007 18:02:06 +0000 (18:02 +0000)]
Add an icon for the PuTTY installer. Design concept (and noticing
that Inno Setup had an option to specify an icon) by Jacob; detailed
artwork and translation into Python by me.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7136 cda61777-01e9-0310-a592-d414129be87e

17 years agoImprove error reporting.
simon [Mon, 22 Jan 2007 14:04:33 +0000 (14:04 +0000)]
Improve error reporting.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7135 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix several bugs that stopped %proxyport from doing anything useful.
jacob [Sun, 21 Jan 2007 23:34:51 +0000 (23:34 +0000)]
Fix several bugs that stopped %proxyport from doing anything useful.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7133 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix Plink, the serial backend, and local-proxy support on Win98SE (at least),
jacob [Sun, 21 Jan 2007 23:34:35 +0000 (23:34 +0000)]
Fix Plink, the serial backend, and local-proxy support on Win98SE (at least),
which have been broken since r6797.
(At least some versions of Win9x are gratuitously picky about the arguments to
CreateThread(), requiring lpThreadId not to be NULL.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7132 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix compiles on GCC 3.3, which doesn't know about assert(0);
ben [Sat, 20 Jan 2007 20:05:46 +0000 (20:05 +0000)]
Fix compiles on GCC 3.3, which doesn't know about assert(0);

git-svn-id: svn://svn.tartarus.org/sgt/putty@7130 cda61777-01e9-0310-a592-d414129be87e

17 years agoMention more versions of Windows. (Not Vista, yet.)
jacob [Sat, 20 Jan 2007 16:14:13 +0000 (16:14 +0000)]
Mention more versions of Windows. (Not Vista, yet.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7127 cda61777-01e9-0310-a592-d414129be87e

17 years agoDon't use C99 mid-block declarations and don't do arithmetic on void *.
ben [Sat, 20 Jan 2007 14:13:57 +0000 (14:13 +0000)]
Don't use C99 mid-block declarations and don't do arithmetic on void *.
This helps with compilations on ancient Sun compilers.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7126 cda61777-01e9-0310-a592-d414129be87e

17 years agoMove README.txt into windows subdir.
jacob [Fri, 19 Jan 2007 14:33:56 +0000 (14:33 +0000)]
Move README.txt into windows subdir.
It's specific to the Windows installer, so it seems unnecessarily confusing to
have it in the top level of the source distribution alongside README.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7125 cda61777-01e9-0310-a592-d414129be87e

17 years agoFlag user cancellation of authentication as a clean exit, so that it
simon [Wed, 17 Jan 2007 18:38:45 +0000 (18:38 +0000)]
Flag user cancellation of authentication as a clean exit, so that it
will close the window even in `close window only on clean exit'
mode. Also, while I'm here, arrange a suitable exit code for
"exit-signal".

git-svn-id: svn://svn.tartarus.org/sgt/putty@7121 cda61777-01e9-0310-a592-d414129be87e

17 years agoUpdate WINVER to 0x500 to avoid build failures from Jacob's
simon [Tue, 16 Jan 2007 21:32:02 +0000 (21:32 +0000)]
Update WINVER to 0x500 to avoid build failures from Jacob's
FlashWindow changes. Also fiddle with the <multimon.h> include,
which was subtly broken in turn by that.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7120 cda61777-01e9-0310-a592-d414129be87e

17 years agoAt least, I have the technology to fix `beepind-win2k'.
jacob [Tue, 16 Jan 2007 20:54:58 +0000 (20:54 +0000)]
At least, I have the technology to fix `beepind-win2k'.
Tested on Win98, Win2K, and WinXP.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7119 cda61777-01e9-0310-a592-d414129be87e

17 years agoAdd more ifdefs to make uxser.c compile on OS X.
simon [Tue, 16 Jan 2007 19:26:24 +0000 (19:26 +0000)]
Add more ifdefs to make uxser.c compile on OS X.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7118 cda61777-01e9-0310-a592-d414129be87e

17 years agoFold up the `SSH' branch of the treeview by default; it's getting
simon [Tue, 16 Jan 2007 18:48:47 +0000 (18:48 +0000)]
Fold up the `SSH' branch of the treeview by default; it's getting
quite big and tends to hide the existence of the `Serial' config
panel.

This is implemented by folding up every branch of depth 2 or more,
which with any luck might turn out to be general enough to carry
over unchanged if other branches start expanding. Then again, we may
have to fiddle with it again when that time comes; who knows?

git-svn-id: svn://svn.tartarus.org/sgt/putty@7117 cda61777-01e9-0310-a592-d414129be87e

17 years agoI've just realised that the data-logging options only work in PuTTY proper.
jacob [Sun, 14 Jan 2007 21:50:44 +0000 (21:50 +0000)]
I've just realised that the data-logging options only work in PuTTY proper.
Document this.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7108 cda61777-01e9-0310-a592-d414129be87e

17 years agoRemove the loops that close all open fds before running a
simon [Sun, 14 Jan 2007 13:44:07 +0000 (13:44 +0000)]
Remove the loops that close all open fds before running a
subprocess. They were intended to make sure the child process didn't
inherit anything embarrassing or inconvenient from us, such as the
master end of its own pty, but now we instead do this by making sure
to set all our own fds to not-FD_CLOEXEC on creation. This should
fix Debian bug #357520.

(This doesn't seem to work _quite_ right in uxproxy.c's invocation
of a local proxy command: both ends of a GTK internal pipe end up in
the child process's fd space. This appears to be another GTK 1 bug,
inasmuch as it goes away when I build with Colin's preliminary GTK 2
patch; for the moment I think leaving that pipe lying around is
probably less harmful than hampering the proxy process's ability to
use extra fds by prior arrangement with PuTTY's parent process.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7107 cda61777-01e9-0310-a592-d414129be87e

17 years agoExperimental fix for `psftp-hang'. (Experimental only in that I haven't thought
jacob [Fri, 12 Jan 2007 23:35:46 +0000 (23:35 +0000)]
Experimental fix for `psftp-hang'. (Experimental only in that I haven't thought
about it very hard; it's a plausible fix for the observed cause of the extreme
CPU usage, being that we were asking to be notified of Windows messages and
then not dealing with them, plausibly leading to a loop. Works for me,
anyway.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7098 cda61777-01e9-0310-a592-d414129be87e

17 years agoRemove redundant sentence.
jacob [Fri, 12 Jan 2007 20:00:32 +0000 (20:00 +0000)]
Remove redundant sentence.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7097 cda61777-01e9-0310-a592-d414129be87e

17 years agoMiscellaneous updates.
jacob [Wed, 10 Jan 2007 00:54:08 +0000 (00:54 +0000)]
Miscellaneous updates.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7090 cda61777-01e9-0310-a592-d414129be87e

17 years agoAccording to Frank Dijcks, this cast makes OpenWatcom happier.
jacob [Wed, 10 Jan 2007 00:46:45 +0000 (00:46 +0000)]
According to Frank Dijcks, this cast makes OpenWatcom happier.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7089 cda61777-01e9-0310-a592-d414129be87e

17 years agoVarious SSH-related things were appearing in the PuTTYtel configuration dialog,
jacob [Wed, 10 Jan 2007 00:16:53 +0000 (00:16 +0000)]
Various SSH-related things were appearing in the PuTTYtel configuration dialog,
probably since the addition of the serial backend. Use a more robust check for
SSH support.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7088 cda61777-01e9-0310-a592-d414129be87e

17 years agoMinGW needs an extra symbol _WIN32_IE defined to a particular value before
jacob [Tue, 9 Jan 2007 23:47:15 +0000 (23:47 +0000)]
MinGW needs an extra symbol _WIN32_IE defined to a particular value before
it'll let you see an identifier (SHGFP_TYPE_CURRENT) referenced since r7082.
(Actually, you need a pretty recent w32api before it's there at all.)

Morally, this should be defined for all toolchains, not just MinGW/Cygwin, but  I'll leave that to people who have those toolchains.
<http://msdn2.microsoft.com/en-us/library/aa383745.aspx>

Also add some other comments on our use of this API (since it's a horrible one
that I suspect will come back and haunt us...)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7087 cda61777-01e9-0310-a592-d414129be87e

17 years agoGet rid of all the MSVC warnings.
simon [Tue, 9 Jan 2007 18:24:07 +0000 (18:24 +0000)]
Get rid of all the MSVC warnings.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7086 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix `puttygen-unix-perms': f_open(), PuTTY's wrapper on fopen, now
simon [Tue, 9 Jan 2007 18:14:30 +0000 (18:14 +0000)]
Fix `puttygen-unix-perms': f_open(), PuTTY's wrapper on fopen, now
takes a third argument which is TRUE if the file is being opened for
writing and wants to be created in such a way that it's readable
only to the owner. This is used when saving private keys.

While I'm here, I also use this option when writing session logs, on
the general principle that they probably contain _something_
sensitive.

The new argument is only supported on Unix, for the moment. (I think
writing owner-accessible-only files is the default on Windows.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7084 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix `win-randseed-location': use SHGetFolderPath() to find the
simon [Tue, 9 Jan 2007 18:05:17 +0000 (18:05 +0000)]
Fix `win-randseed-location': use SHGetFolderPath() to find the
Application Data directory in preference to the old-fashioned
attempt to find the user's home directory, and use the _local-
machine_ Application Data directory in preference even to that.

SHGetFolderPath() is called via GetProcAddress, so this degrades
gracefully on old Windowses. (Tested myself on Win95.)

As part of this change, we now search for a location for the seed
file separately for reading and writing, so that installing the new
PuTTY should cause a seamless migration as the old seed file is read
from the old location and then a new one written to the new location.

`putty -cleanup' attempts to delete the seed file from _all_
affected locations.

Naturally, a user-specified seed file path in the Registry still
takes priority over all other means of finding the location.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7082 cda61777-01e9-0310-a592-d414129be87e

17 years agoThe remaining issue in `win-askappend-multi' appears to have been
simon [Mon, 8 Jan 2007 19:38:39 +0000 (19:38 +0000)]
The remaining issue in `win-askappend-multi' appears to have been
caused by the MessageBox() internal message loop eating WinSock
FD_READ notifications, which then don't reappear afterwards because
you have to explicitly prod a socket in order to get a repeat
notification on it.

Hence, here's a piece of infrastructure which seems to sort it out:
a new winnet.c function called socket_reselect_all(), whose function
is to go through all currently active sockets and re-run
WSAAsyncSelect() on them, causing repeat notifications for anything
we might have missed. I call this after every call to MessageBox(),
and that seems to solve the problem.

(The problem was actually masked in very recent revisions, probably
by the reinstatement of pending_netevent in r7071. However, I don't
believe that was a complete fix. This should be.)

git-svn-id: svn://svn.tartarus.org/sgt/putty@7077 cda61777-01e9-0310-a592-d414129be87e

17 years agoHave one call to from_backend() per call to do_telnet_read(),
simon [Mon, 8 Jan 2007 18:54:49 +0000 (18:54 +0000)]
Have one call to from_backend() per call to do_telnet_read(),
instead of the previous rate of one per character. In `Flush log
file frequently' mode, the latter was causing excessive slowdown due
to fflush()ing once per byte.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7076 cda61777-01e9-0310-a592-d414129be87e

17 years agoFix ssh2-cisco-pw-pad by reverting r5122. However, I've kept the
simon [Sun, 7 Jan 2007 14:30:24 +0000 (14:30 +0000)]
Fix ssh2-cisco-pw-pad by reverting r5122. However, I've kept the
ability to easily re-enable the r5122 behaviour, in case we need to
conditionally switch between the two at a later date.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7073 cda61777-01e9-0310-a592-d414129be87e

17 years agoGreater leniency when importing private key files: accept both CRLF
simon [Sun, 7 Jan 2007 14:20:28 +0000 (14:20 +0000)]
Greater leniency when importing private key files: accept both CRLF
and LF, and don't object if the final line of the key lacks a
newline. Also, while I'm here, switch to using fgetline() throughout
so as not to have to do nasty buffer-size ad-hockery.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7072 cda61777-01e9-0310-a592-d414129be87e

17 years agoReinstate RDB's pending_netevent mechanism, which was removed in
simon [Sun, 7 Jan 2007 12:40:21 +0000 (12:40 +0000)]
Reinstate RDB's pending_netevent mechanism, which was removed in
r4906 in the process of adding the new timing code. It seems to have
been what was previously preventing spew-lockup, and still seems to
prevent it now I've put it back in.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7071 cda61777-01e9-0310-a592-d414129be87e

17 years agoTweak the icon script, and the generated icons, to more closely
simon [Sun, 7 Jan 2007 10:17:12 +0000 (10:17 +0000)]
Tweak the icon script, and the generated icons, to more closely
match the original icons. (Apparently I managed to introduce errors
while transcribing the originals for detailed analysis.)

While I'm at it, add the obviously useful `make install' target in
icons/Makefile, and fix the svn:ignore property on the icons
directory.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7068 cda61777-01e9-0310-a592-d414129be87e

17 years agoI think this change to Recipe was accidentally omitted from r7064.
jacob [Sat, 6 Jan 2007 20:01:30 +0000 (20:01 +0000)]
I think this change to Recipe was accidentally omitted from r7064.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7065 cda61777-01e9-0310-a592-d414129be87e

17 years agoNo, I tell a lie: GTK 1 _does_ support icons, at least partially. Ooh.
simon [Sat, 6 Jan 2007 18:27:00 +0000 (18:27 +0000)]
No, I tell a lie: GTK 1 _does_ support icons, at least partially. Ooh.

git-svn-id: svn://svn.tartarus.org/sgt/putty@7064 cda61777-01e9-0310-a592-d414129be87e

17 years agoShiny new script which constructs the various icons for the PuTTY
simon [Sat, 6 Jan 2007 18:15:35 +0000 (18:15 +0000)]
Shiny new script which constructs the various icons for the PuTTY
suite. In a dramatic break with tradition, I'm actually checking in
the resulting icon files as well as the script that generates them,
because the script requires Python and ImageMagick and I don't think
it's reasonable to require that much extra infrastructure on
everyone checking out from Subversion.

The new icons should be _almost_ indistinguishable from the old
ones, at least at the 32x32 resolution. The immediately visible
change is that all the icons now come in 16x16, 32x32 and 48x48
formats, in both 16 colours and monochrome, instead of an ad-hoc
mixture of whichever ones I could be bothered to draw.

The same code can also be adapted to generate icons for the GTK port
(although icons for the running programs don't seem to be supported
by GTK 1 - another reason to upgrade to GTK 2!).

git-svn-id: svn://svn.tartarus.org/sgt/putty@7063 cda61777-01e9-0310-a592-d414129be87e