From: ben Date: Thu, 28 Apr 2005 08:24:46 +0000 (+0000) Subject: In blowfish-ctr mode, increment the counter in the correct order. Thanks to X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/commitdiff_plain/be47bb502541fc654f52e1988dd832bbecfd8c7b?hp=6236e66e28beb855512418d28b0ba5303f394794 In blowfish-ctr mode, increment the counter in the correct order. Thanks to der Mouse for spotting the same error in my 3des-ctr implementation. git-svn-id: svn://svn.tartarus.org/sgt/putty@5700 cda61777-01e9-0310-a592-d414129be87e --- diff --git a/sshblowf.c b/sshblowf.c index 0ca81eba..0f00a77b 100644 --- a/sshblowf.c +++ b/sshblowf.c @@ -406,8 +406,8 @@ static void blowfish_msb_sdctr(unsigned char *blk, int len, PUT_32BIT_MSB_FIRST(blk, tmp ^ b[0]); tmp = GET_32BIT_MSB_FIRST(blk + 4); PUT_32BIT_MSB_FIRST(blk + 4, tmp ^ b[1]); - if ((iv0 = (iv0 + 1) & 0xffffffff) == 0) - iv1 = (iv1 + 1) & 0xffffffff; + if ((iv1 = (iv1 + 1) & 0xffffffff) == 0) + iv0 = (iv0 + 1) & 0xffffffff; blk += 8; len -= 8; }