From: simon <simon@cda61777-01e9-0310-a592-d414129be87e>
Date: Fri, 1 Nov 2002 13:01:14 +0000 (+0000)
Subject: Another valgrind-caught error. This one has apparently been there
X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/commitdiff_plain/704c0cbcef60a8cbe5bbd6d4bf90e00cc39b285e

Another valgrind-caught error. This one has apparently been there
since the Dawn O' Time, and consisted of me putting the two halves
of a short-circuiting bounds check the wrong way round: instead of
`p_in_range && *p', I had `*p && p_in_range'. Oops. valgrind rocks.


git-svn-id: svn://svn.tartarus.org/sgt/putty@2174 cda61777-01e9-0310-a592-d414129be87e
---

diff --git a/telnet.c b/telnet.c
index f20488e3..7e612cf6 100644
--- a/telnet.c
+++ b/telnet.c
@@ -742,7 +742,7 @@ static int telnet_send(void *handle, char *buf, int len)
     while (p < buf + len) {
 	char *q = p;
 
-	while (iswritable((unsigned char) *p) && p < buf + len)
+	while (p < buf + len && iswritable((unsigned char) *p))
 	    p++;
 	telnet->bufsize = sk_write(telnet->s, q, p - q);