X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/blobdiff_plain/d2371c812a1c62b6a258c0717f1fff263cca8ca1..8e1feb2760e62b619e3226572dca19001a192bd8:/ssh.c

diff --git a/ssh.c b/ssh.c
index 8522e3d3..f48d1426 100644
--- a/ssh.c
+++ b/ssh.c
@@ -17,7 +17,7 @@
 
 #define logevent(s) { logevent(s); \
                       if ((flags & FLAG_STDERR) && (flags & FLAG_VERBOSE)) \
-                      fprintf(stderr, "%s\n", s); }
+                      { fprintf(stderr, "%s\n", s); fflush(stderr); } }
 
 #define bombout(msg) ( ssh_state = SSH_STATE_CLOSED, \
                           (s ? sk_close(s), s = NULL : 0), \
@@ -366,8 +366,8 @@ static int ssh_channelfind(void *av, void *bv) {
 }
 
 static int alloc_channel_id(void) {
-    const int CHANNEL_NUMBER_OFFSET = 256;
-    int low, high, mid;
+    const unsigned CHANNEL_NUMBER_OFFSET = 256;
+    unsigned low, high, mid;
     int tsize;
     struct ssh_channel *c;
 
@@ -572,8 +572,8 @@ next_packet:
     if (pktin.type == SSH1_MSG_DISCONNECT) {
 	/* log reason code in disconnect message */
 	char buf[256];
-	int msglen = GET_32BIT(pktin.body);
-	int nowlen;
+	unsigned msglen = GET_32BIT(pktin.body);
+	unsigned nowlen;
 	strcpy(buf, "Remote sent disconnect: ");
 	nowlen = strlen(buf);
 	if (msglen > sizeof(buf)-nowlen-1)
@@ -726,8 +726,8 @@ next_packet:
 	/* log reason code in disconnect message */
 	char buf[256];
 	int reason = GET_32BIT(pktin.data+6);
-	int msglen = GET_32BIT(pktin.data+10);
-	int nowlen;
+	unsigned msglen = GET_32BIT(pktin.data+10);
+	unsigned nowlen;
 	if (reason > 0 && reason < lenof(ssh2_disconnect_reasons)) {
 	    sprintf(buf, "Received disconnect message (%s)",
 		    ssh2_disconnect_reasons[reason]);
@@ -2270,7 +2270,7 @@ static void ssh1_protocol(unsigned char *in, int inlen, int ispkt) {
             } else if (pktin.type == SSH1_SMSG_X11_OPEN) {
                 /* Remote side is trying to open a channel to talk to our
                  * X-Server. Give them back a local channel number. */
-                struct ssh_channel *c, *d;
+                struct ssh_channel *c;
 
 		logevent("Received X11 connect request");
 		/* Refuse if X11 forwarding is disabled. */
@@ -2304,7 +2304,6 @@ static void ssh1_protocol(unsigned char *in, int inlen, int ispkt) {
             } else if (pktin.type == SSH1_SMSG_AGENT_OPEN) {
                 /* Remote side is trying to open a channel to talk to our
                  * agent. Give them back a local channel number. */
-                unsigned i;
                 struct ssh_channel *c;
 
 		/* Refuse if agent forwarding is disabled. */
@@ -3165,7 +3164,7 @@ static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
 
 	    method = 0;
 
-	    if (!method && can_pubkey && agent_exists && !tried_agent) {
+	    if (!method && can_pubkey && agent_exists() && !tried_agent) {
 		/*
 		 * Attempt public-key authentication using Pageant.
 		 */
@@ -3920,9 +3919,6 @@ static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
                     ssh2_pkt_send();
                     sfree(c);
                 } else {
-                    struct ssh_channel *d;
-                    unsigned i;
-
                     c->localid = alloc_channel_id();
                     c->closes = 0;
                     c->v2.remwindow = ssh2_pkt_getuint32();