X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/blobdiff_plain/4bd083f7b36774602d7a3054778cf959a0cac9c1..8f1612752a89ea821dbd63491aef858f7f7e5bef:/mac/macctrls.c diff --git a/mac/macctrls.c b/mac/macctrls.c index 5a2ea4da..d49d6e6e 100644 --- a/mac/macctrls.c +++ b/mac/macctrls.c @@ -1,4 +1,4 @@ -/* $Id: macctrls.c,v 1.32 2003/04/13 13:52:44 ben Exp $ */ +/* $Id: macctrls.c,v 1.42 2003/05/10 20:51:39 ben Exp $ */ /* * Copyright (c) 2003 Ben Harris * All rights reserved. @@ -27,6 +27,7 @@ #include #include +#include #include #include #include @@ -129,6 +130,7 @@ struct mac_layoutstate { static void macctrl_layoutset(struct mac_layoutstate *, struct controlset *, WindowPtr, struct macctrls *); +static void macctrl_hideshowpanel(struct macctrls *, unsigned int, int); static void macctrl_switchtopanel(struct macctrls *, unsigned int); static void macctrl_setfocus(struct macctrls *, union macctrl *); static void macctrl_text(struct macctrls *, WindowPtr, @@ -213,6 +215,18 @@ static int macctrl_cmp_byctrl_find(void *av, void *bv) return 0; } +static union control panellist; + +static void panellist_handler(union control *ctrl, void *dlg, void *data, + int event) +{ + struct macctrls *mcs = dlg; + + /* XXX what if there's no selection? */ + if (event == EVENT_SELCHANGE) + macctrl_switchtopanel(mcs, dlg_listbox_index(ctrl, dlg) + 1); +} + void macctrl_layoutbox(struct controlbox *cb, WindowPtr window, struct macctrls *mcs) { @@ -222,16 +236,13 @@ void macctrl_layoutbox(struct controlbox *cb, WindowPtr window, Rect rect; macctrl_init(); + if (mac_gestalts.apprvers >= 0x100) + CreateRootControl(window, &root); #if TARGET_API_MAC_CARBON GetPortBounds(GetWindowPort(window), &rect); #else rect = window->portRect; #endif - curstate.pos.h = rect.left + 13; - curstate.pos.v = rect.bottom - 33; - curstate.width = rect.right - rect.left - (13 * 2); - if (mac_gestalts.apprvers >= 0x100) - CreateRootControl(window, &root); mcs->window = window; mcs->byctrl = newtree234(macctrl_cmp_byctrl); mcs->focus = NULL; @@ -245,16 +256,32 @@ void macctrl_layoutbox(struct controlbox *cb, WindowPtr window, mcs->panels = snewn(mcs->npanels, union macctrl *); memset(mcs->panels, 0, sizeof(*mcs->panels) * mcs->npanels); curstate.panelnum = 0; + + curstate.pos.h = rect.left + 13; + curstate.pos.v = rect.top + 13; + curstate.width = 160; + panellist.listbox.type = CTRL_LISTBOX; + panellist.listbox.handler = &panellist_handler; + panellist.listbox.height = 20; + panellist.listbox.percentwidth = 100; + macctrl_listbox(mcs, window, &curstate, &panellist); + /* XXX Start with panel 1 active */ + + curstate.pos.h = rect.left + 13 + 160 + 13; + curstate.pos.v = rect.bottom - 33; + curstate.width = rect.right - (rect.left + 13 + 160) - (13 * 2); for (i = 0; i < cb->nctrlsets; i++) { if (i > 0 && strcmp(cb->ctrlsets[i]->pathname, cb->ctrlsets[i-1]->pathname)) { curstate.pos.v = rect.top + 13; curstate.panelnum++; assert(curstate.panelnum < mcs->npanels); + dlg_listbox_add(&panellist, mcs, cb->ctrlsets[i]->pathname); } macctrl_layoutset(&curstate, cb->ctrlsets[i], window, mcs); } macctrl_switchtopanel(mcs, 1); + macctrl_hideshowpanel(mcs, 0, TRUE); /* 14 = proxies, 19 = portfwd, 20 = SSH bugs */ } @@ -264,43 +291,20 @@ static void macctrl_layoutset(struct mac_layoutstate *curstate, struct controlset *s, WindowPtr window, struct macctrls *mcs) { - unsigned int i, j, ncols, colstart; - struct mac_layoutstate cols[MAXCOLS]; - - fprintf(stderr, "--- begin set ---\n"); - fprintf(stderr, "pathname = %s\n", s->pathname); - if (s->boxname && *s->boxname) - fprintf(stderr, "boxname = %s\n", s->boxname); - if (s->boxtitle) - fprintf(stderr, "boxtitle = %s\n", s->boxtitle); + unsigned int i, j, ncols, colstart, colspan; + struct mac_layoutstate cols[MAXCOLS], pos; cols[0] = *curstate; ncols = 1; for (i = 0; i < s->ncontrols; i++) { union control *ctrl = s->ctrls[i]; - char const *s; colstart = COLUMN_START(ctrl->generic.column); - switch (ctrl->generic.type) { - case CTRL_TEXT: s = "text"; break; - case CTRL_EDITBOX: s = "editbox"; break; - case CTRL_RADIO: s = "radio"; break; - case CTRL_CHECKBOX: s = "checkbox"; break; - case CTRL_BUTTON: s = "button"; break; - case CTRL_LISTBOX: s = "listbox"; break; - case CTRL_COLUMNS: s = "columns"; break; - case CTRL_FILESELECT: s = "fileselect"; break; - case CTRL_FONTSELECT: s = "fontselect"; break; - case CTRL_TABDELAY: s = "tabdelay"; break; - default: s = "unknown"; break; - } - fprintf(stderr, " control: %s\n", s); - switch (ctrl->generic.type) { - case CTRL_COLUMNS: + colspan = COLUMN_SPAN(ctrl->generic.column); + if (ctrl->generic.type == CTRL_COLUMNS) { if (ctrl->columns.ncols != 1) { ncols = ctrl->columns.ncols; - fprintf(stderr, " split to %d\n", ncols); assert(ncols <= MAXCOLS); for (j = 0; j < ncols; j++) { cols[j] = cols[0]; @@ -314,35 +318,46 @@ static void macctrl_layoutset(struct mac_layoutstate *curstate, ctrl->columns.percentages[j] / 100 - 6; } } else { - fprintf(stderr, " join\n"); for (j = 0; j < ncols; j++) if (cols[j].pos.v > cols[0].pos.v) cols[0].pos.v = cols[j].pos.v; cols[0].width = curstate->width; ncols = 1; } - break; - case CTRL_TEXT: - macctrl_text(mcs, window, &cols[colstart], ctrl); - break; - case CTRL_EDITBOX: - macctrl_editbox(mcs, window, &cols[colstart], ctrl); - break; - case CTRL_RADIO: - macctrl_radio(mcs, window, &cols[colstart], ctrl); - break; - case CTRL_CHECKBOX: - macctrl_checkbox(mcs, window, &cols[colstart], ctrl); - break; - case CTRL_BUTTON: - macctrl_button(mcs, window, &cols[colstart], ctrl); - break; - case CTRL_LISTBOX: - if (ctrl->listbox.height == 0) - macctrl_popup(mcs, window, &cols[colstart], ctrl); - else - macctrl_listbox(mcs, window, &cols[colstart], ctrl); - break; + } else { + pos = cols[colstart]; + pos.width = cols[colstart + colspan - 1].width + + (cols[colstart + colspan - 1].pos.h - cols[colstart].pos.h); + + for (j = colstart; j < colstart + colspan; j++) + if (pos.pos.v < cols[j].pos.v) + pos.pos.v = cols[j].pos.v; + + switch (ctrl->generic.type) { + case CTRL_TEXT: + macctrl_text(mcs, window, &pos, ctrl); + break; + case CTRL_EDITBOX: + macctrl_editbox(mcs, window, &pos, ctrl); + break; + case CTRL_RADIO: + macctrl_radio(mcs, window, &pos, ctrl); + break; + case CTRL_CHECKBOX: + macctrl_checkbox(mcs, window, &pos, ctrl); + break; + case CTRL_BUTTON: + macctrl_button(mcs, window, &pos, ctrl); + break; + case CTRL_LISTBOX: + if (ctrl->listbox.height == 0) + macctrl_popup(mcs, window, &pos, ctrl); + else + macctrl_listbox(mcs, window, &pos, ctrl); + break; + } + for (j = colstart; j < colstart + colspan; j++) + cols[j].pos.v = pos.pos.v; } } for (j = 0; j < ncols; j++) @@ -350,61 +365,69 @@ static void macctrl_layoutset(struct mac_layoutstate *curstate, curstate->pos.v = cols[j].pos.v; } -static void macctrl_switchtopanel(struct macctrls *mcs, unsigned int which) +static void macctrl_hideshowpanel(struct macctrls *mcs, unsigned int panel, + int showit) { - unsigned int i, j; union macctrl *mc; + int j; #define hideshow(c) do { \ - if (i == which) ShowControl(c); else HideControl(c); \ + if (showit) ShowControl(c); else HideControl(c); \ } while (0) - mcs->curpanel = which; - /* Panel 0 is special and always visible. */ - for (i = 1; i < mcs->npanels; i++) - for (mc = mcs->panels[i]; mc != NULL; mc = mc->generic.next) { + for (mc = mcs->panels[panel]; mc != NULL; mc = mc->generic.next) { #if !TARGET_API_MAC_CARBON - if (mcs->focus == mc) - macctrl_setfocus(mcs, NULL); + if (mcs->focus == mc) + macctrl_setfocus(mcs, NULL); #endif - switch (mc->generic.type) { - case MACCTRL_TEXT: - hideshow(mc->text.tbctrl); - break; - case MACCTRL_EDITBOX: - hideshow(mc->editbox.tbctrl); - if (mc->editbox.tblabel != NULL) - hideshow(mc->editbox.tblabel); - break; - case MACCTRL_RADIO: - for (j = 0; j < mc->generic.ctrl->radio.nbuttons; j++) - hideshow(mc->radio.tbctrls[j]); - if (mc->radio.tblabel != NULL) - hideshow(mc->radio.tblabel); - break; - case MACCTRL_CHECKBOX: - hideshow(mc->checkbox.tbctrl); - break; - case MACCTRL_BUTTON: - hideshow(mc->button.tbctrl); - break; - case MACCTRL_LISTBOX: - hideshow(mc->listbox.tbctrl); - /* - * At least under Mac OS 8.1, hiding a list box - * doesn't hide its scroll bars. - */ + switch (mc->generic.type) { + case MACCTRL_TEXT: + hideshow(mc->text.tbctrl); + break; + case MACCTRL_EDITBOX: + hideshow(mc->editbox.tbctrl); + if (mc->editbox.tblabel != NULL) + hideshow(mc->editbox.tblabel); + break; + case MACCTRL_RADIO: + for (j = 0; j < mc->generic.ctrl->radio.nbuttons; j++) + hideshow(mc->radio.tbctrls[j]); + if (mc->radio.tblabel != NULL) + hideshow(mc->radio.tblabel); + break; + case MACCTRL_CHECKBOX: + hideshow(mc->checkbox.tbctrl); + break; + case MACCTRL_BUTTON: + hideshow(mc->button.tbctrl); + if (mc->button.tbring != NULL) + hideshow(mc->button.tbring); + break; + case MACCTRL_LISTBOX: + hideshow(mc->listbox.tbctrl); + /* + * At least under Mac OS 8.1, hiding a list box + * doesn't hide its scroll bars. + */ #if TARGET_API_MAC_CARBON - hideshow(GetListVerticalScrollBar(mc->listbox.list)); + hideshow(GetListVerticalScrollBar(mc->listbox.list)); #else - hideshow((*mc->listbox.list)->vScroll); + hideshow((*mc->listbox.list)->vScroll); #endif - break; - case MACCTRL_POPUP: - hideshow(mc->popup.tbctrl); - break; - } + break; + case MACCTRL_POPUP: + hideshow(mc->popup.tbctrl); + break; } + } +} + +static void macctrl_switchtopanel(struct macctrls *mcs, unsigned int which) +{ + + macctrl_hideshowpanel(mcs, mcs->curpanel, FALSE); + macctrl_hideshowpanel(mcs, which, TRUE); + mcs->curpanel = which; } #if !TARGET_API_MAC_CARBON @@ -455,7 +478,6 @@ static void macctrl_text(struct macctrls *mcs, WindowPtr window, SInt16 height; assert(ctrl->text.label != NULL); - fprintf(stderr, " label = %s\n", ctrl->text.label); mc->generic.type = MACCTRL_TEXT; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -466,7 +488,7 @@ static void macctrl_text(struct macctrls *mcs, WindowPtr window, if (mac_gestalts.apprvers >= 0x100) { Size olen; - mc->text.tbctrl = NewControl(window, &bounds, NULL, TRUE, 0, 0, 0, + mc->text.tbctrl = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, kControlStaticTextProc, (long)mc); SetControlData(mc->text.tbctrl, kControlEntireControl, kControlStaticTextTextTag, @@ -479,14 +501,13 @@ static void macctrl_text(struct macctrls *mcs, WindowPtr window, else { TEHandle te; - mc->text.tbctrl = NewControl(window, &bounds, NULL, TRUE, 0, 0, 0, + mc->text.tbctrl = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, SYS7_TEXT_PROC, (long)mc); te = (TEHandle)(*mc->text.tbctrl)->contrlData; TESetText(ctrl->text.label, strlen(ctrl->text.label), te); height = TEGetHeight(1, (*te)->nLines, te); } #endif - fprintf(stderr, " height = %d\n", height); SizeControl(mc->text.tbctrl, curstate->width, height); curstate->pos.v += height + 6; add234(mcs->byctrl, mc); @@ -501,11 +522,6 @@ static void macctrl_editbox(struct macctrls *mcs, WindowPtr window, union macctrl *mc = snew(union macctrl); Rect lbounds, bounds; - if (ctrl->editbox.label != NULL) - fprintf(stderr, " label = %s\n", ctrl->editbox.label); - fprintf(stderr, " percentwidth = %d\n", ctrl->editbox.percentwidth); - if (ctrl->editbox.password) fprintf(stderr, " password\n"); - if (ctrl->editbox.has_list) fprintf(stderr, " has list\n"); mc->generic.type = MACCTRL_EDITBOX; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -532,7 +548,7 @@ static void macctrl_editbox(struct macctrls *mcs, WindowPtr window, if (ctrl->editbox.label == NULL) mc->editbox.tblabel = NULL; else { - mc->editbox.tblabel = NewControl(window, &lbounds, NULL, TRUE, + mc->editbox.tblabel = NewControl(window, &lbounds, NULL, FALSE, 0, 0, 0, kControlStaticTextProc, (long)mc); SetControlData(mc->editbox.tblabel, kControlEntireControl, @@ -540,7 +556,7 @@ static void macctrl_editbox(struct macctrls *mcs, WindowPtr window, strlen(ctrl->editbox.label), ctrl->editbox.label); } InsetRect(&bounds, 3, 3); - mc->editbox.tbctrl = NewControl(window, &bounds, NULL, TRUE, 0, 0, 0, + mc->editbox.tbctrl = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, ctrl->editbox.password ? kControlEditTextPasswordProc : kControlEditTextProc, (long)mc); @@ -550,13 +566,13 @@ static void macctrl_editbox(struct macctrls *mcs, WindowPtr window, if (ctrl->editbox.label == NULL) mc->editbox.tblabel = NULL; else { - mc->editbox.tblabel = NewControl(window, &lbounds, NULL, TRUE, + mc->editbox.tblabel = NewControl(window, &lbounds, NULL, FALSE, 0, 0, 0, SYS7_TEXT_PROC, (long)mc); TESetText(ctrl->editbox.label, strlen(ctrl->editbox.label), (TEHandle)(*mc->editbox.tblabel)->contrlData); } - mc->editbox.tbctrl = NewControl(window, &bounds, NULL, TRUE, 0, 0, 0, + mc->editbox.tbctrl = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, SYS7_EDITBOX_PROC, (long)mc); } #endif @@ -601,6 +617,7 @@ static pascal SInt32 macctrl_sys7_editbox_cdef(SInt16 variant, FrameRect(&rect); InsetRect(&rect, 3, 3); } + EraseRect(&rect); (*(TEHandle)(*control)->contrlData)->viewRect = rect; TEUpdate(&rect, (TEHandle)(*control)->contrlData); } @@ -643,8 +660,6 @@ static void macctrl_radio(struct macctrls *mcs, WindowPtr window, Str255 title; unsigned int i, colwidth; - if (ctrl->radio.label != NULL) - fprintf(stderr, " label = %s\n", ctrl->radio.label); mc->generic.type = MACCTRL_RADIO; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -658,7 +673,7 @@ static void macctrl_radio(struct macctrls *mcs, WindowPtr window, mc->radio.tblabel = NULL; else { if (mac_gestalts.apprvers >= 0x100) { - mc->radio.tblabel = NewControl(window, &bounds, NULL, TRUE, + mc->radio.tblabel = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, kControlStaticTextProc, (long)mc); SetControlData(mc->radio.tblabel, kControlEntireControl, @@ -667,7 +682,7 @@ static void macctrl_radio(struct macctrls *mcs, WindowPtr window, } #if !TARGET_API_MAC_CARBON else { - mc->radio.tblabel = NewControl(window, &bounds, NULL, TRUE, + mc->radio.tblabel = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, SYS7_TEXT_PROC, (long)mc); TESetText(ctrl->radio.label, strlen(ctrl->radio.label), (TEHandle)(*mc->radio.tblabel)->contrlData); @@ -676,7 +691,6 @@ static void macctrl_radio(struct macctrls *mcs, WindowPtr window, curstate->pos.v += 18; } for (i = 0; i < ctrl->radio.nbuttons; i++) { - fprintf(stderr, " button = %s\n", ctrl->radio.buttons[i]); bounds.top = curstate->pos.v - 2; bounds.bottom = bounds.top + 18; bounds.left = curstate->pos.h + colwidth * (i % ctrl->radio.ncolumns); @@ -687,7 +701,7 @@ static void macctrl_radio(struct macctrls *mcs, WindowPtr window, } else bounds.right = bounds.left + colwidth - 13; c2pstrcpy(title, ctrl->radio.buttons[i]); - mc->radio.tbctrls[i] = NewControl(window, &bounds, title, TRUE, + mc->radio.tbctrls[i] = NewControl(window, &bounds, title, FALSE, 0, 0, 1, radioButProc, (long)mc); } curstate->pos.v += 4; @@ -706,7 +720,6 @@ static void macctrl_checkbox(struct macctrls *mcs, WindowPtr window, Str255 title; assert(ctrl->checkbox.label != NULL); - fprintf(stderr, " label = %s\n", ctrl->checkbox.label); mc->generic.type = MACCTRL_CHECKBOX; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -715,7 +728,7 @@ static void macctrl_checkbox(struct macctrls *mcs, WindowPtr window, bounds.top = curstate->pos.v; bounds.bottom = bounds.top + 16; c2pstrcpy(title, ctrl->checkbox.label); - mc->checkbox.tbctrl = NewControl(window, &bounds, title, TRUE, 0, 0, 1, + mc->checkbox.tbctrl = NewControl(window, &bounds, title, FALSE, 0, 0, 1, checkBoxProc, (long)mc); add234(mcs->byctrl, mc); curstate->pos.v += 22; @@ -733,9 +746,6 @@ static void macctrl_button(struct macctrls *mcs, WindowPtr window, Str255 title; assert(ctrl->button.label != NULL); - fprintf(stderr, " label = %s\n", ctrl->button.label); - if (ctrl->button.isdefault) - fprintf(stderr, " is default\n"); mc->generic.type = MACCTRL_BUTTON; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -744,7 +754,7 @@ static void macctrl_button(struct macctrls *mcs, WindowPtr window, bounds.top = curstate->pos.v; bounds.bottom = bounds.top + 20; c2pstrcpy(title, ctrl->button.label); - mc->button.tbctrl = NewControl(window, &bounds, title, TRUE, 0, 0, 1, + mc->button.tbctrl = NewControl(window, &bounds, title, FALSE, 0, 0, 1, pushButProc, (long)mc); mc->button.tbring = NULL; if (mac_gestalts.apprvers >= 0x100) { @@ -755,7 +765,7 @@ static void macctrl_button(struct macctrls *mcs, WindowPtr window, sizeof(isdefault), &isdefault); } else if (ctrl->button.isdefault) { InsetRect(&bounds, -4, -4); - mc->button.tbring = NewControl(window, &bounds, title, TRUE, 0, 0, 1, + mc->button.tbring = NewControl(window, &bounds, title, FALSE, 0, 0, 1, SYS7_DEFAULT_PROC, (long)mc); } if (mac_gestalts.apprvers >= 0x110) { @@ -829,14 +839,7 @@ static void macctrl_listbox(struct macctrls *mcs, WindowPtr window, Rect bounds; Size olen; - if (ctrl->listbox.label != NULL) - fprintf(stderr, " label = %s\n", ctrl->listbox.label); - fprintf(stderr, " height = %d\n", ctrl->listbox.height); - if (ctrl->listbox.draglist) - fprintf(stderr, " draglist\n"); - if (ctrl->listbox.multisel) - fprintf(stderr, " multisel\n"); - fprintf(stderr, " ncols = %d\n", ctrl->listbox.ncols); + /* XXX Use label */ assert(ctrl->listbox.percentwidth == 100); mc->generic.type = MACCTRL_LISTBOX; mc->generic.ctrl = ctrl; @@ -847,11 +850,11 @@ static void macctrl_listbox(struct macctrls *mcs, WindowPtr window, bounds.left = curstate->pos.h; bounds.right = bounds.left + curstate->width; bounds.top = curstate->pos.v; - bounds.bottom = bounds.top + 20 * ctrl->listbox.height; + bounds.bottom = bounds.top + 16 * ctrl->listbox.height + 2; if (mac_gestalts.apprvers >= 0x100) { InsetRect(&bounds, 3, 3); - mc->listbox.tbctrl = NewControl(window, &bounds, NULL, TRUE, + mc->listbox.tbctrl = NewControl(window, &bounds, NULL, FALSE, ldes_Default, 0, 0, kControlListBoxProc, (long)mc); if (GetControlData(mc->listbox.tbctrl, kControlEntireControl, @@ -866,7 +869,7 @@ static void macctrl_listbox(struct macctrls *mcs, WindowPtr window, #if !TARGET_API_MAC_CARBON else { InsetRect(&bounds, -3, -3); - mc->listbox.tbctrl = NewControl(window, &bounds, NULL, TRUE, + mc->listbox.tbctrl = NewControl(window, &bounds, NULL, FALSE, 0, 0, 0, SYS7_LISTBOX_PROC, (long)mc); mc->listbox.list = (ListHandle)(*mc->listbox.tbctrl)->contrlData; @@ -881,10 +884,15 @@ static void macctrl_listbox(struct macctrls *mcs, WindowPtr window, #endif } add234(mcs->byctrl, mc); - curstate->pos.v += 6 + 20 * ctrl->listbox.height; + curstate->pos.v += 6 + 16 * ctrl->listbox.height + 2; mc->generic.next = mcs->panels[curstate->panelnum]; mcs->panels[curstate->panelnum] = mc; ctrlevent(mcs, mc, EVENT_REFRESH); +#if TARGET_API_MAC_CARBON + HideControl(GetListVerticalScrollBar(mc->listbox.list)); +#else + HideControl((*mc->listbox.list)->vScroll); +#endif } #if !TARGET_API_MAC_CARBON @@ -1000,10 +1008,6 @@ static void macctrl_popup(struct macctrls *mcs, WindowPtr window, assert(!ctrl->listbox.draglist); assert(!ctrl->listbox.multisel); - if (ctrl->listbox.label != NULL) - fprintf(stderr, " label = %s\n", ctrl->listbox.label); - fprintf(stderr, " percentwidth = %d\n", ctrl->listbox.percentwidth); - mc->generic.type = MACCTRL_POPUP; mc->generic.ctrl = ctrl; mc->generic.privdata = NULL; @@ -1029,7 +1033,7 @@ static void macctrl_popup(struct macctrls *mcs, WindowPtr window, bounds.bottom = bounds.top + 20; /* XXX handle percentwidth == 100 */ labelwidth = curstate->width * (100 - ctrl->listbox.percentwidth) / 100; - mc->popup.tbctrl = NewControl(window, &bounds, title, TRUE, + mc->popup.tbctrl = NewControl(window, &bounds, title, FALSE, popupTitleLeftJust, menuid, labelwidth, popupMenuProc + popupFixedWidth, (long)mc); add234(mcs->byctrl, mc); @@ -1131,8 +1135,6 @@ void macctrl_click(WindowPtr window, EventRecord *event) else #endif mc = (union macctrl *)GetControlReference(control); - fprintf(stderr, "control = %p, part = %d, mc = %p\n", - control, part, mc); if (mac_gestalts.apprvers >= 0x100) { if (GetControlFeatures(control, &features) == noErr && (features & kControlSupportsFocus) && @@ -1156,7 +1158,6 @@ void macctrl_click(WindowPtr window, EventRecord *event) (control == mc->listbox.tbctrl || control == (*mc->listbox.list)->vScroll)) { - fprintf(stderr, "list = %p\n", mc->listbox.list); macctrl_setfocus(mcs, mc); if (LClick(mouse, event->modifiers, mc->listbox.list)) /* double-click */ @@ -1242,7 +1243,14 @@ void macctrl_key(WindowPtr window, EventRecord *event) HandleControlKey(control, (event->message & keyCodeMask) >> 8, event->message & charCodeMask, event->modifiers); mc = (union macctrl *)GetControlReference(control); - ctrlevent(mcs, mc, EVENT_VALCHANGE); + switch (mc->generic.type) { + case MACCTRL_LISTBOX: + ctrlevent(mcs, mc, EVENT_SELCHANGE); + break; + default: + ctrlevent(mcs, mc, EVENT_VALCHANGE); + break; + } } } #if !TARGET_API_MAC_CARBON @@ -1560,7 +1568,6 @@ void dlg_editbox_get(union control *ctrl, void *dlg, char *buffer, int length) } #endif buffer[olen] = '\0'; - fprintf(stderr, "dlg_editbox_get: %s\n", buffer); } @@ -1576,7 +1583,6 @@ static void dlg_macpopup_clear(union control *ctrl, void *dlg) unsigned int i, n; if (mc == NULL) return; - fprintf(stderr, " popup_clear\n"); n = CountMenuItems(menu); for (i = 0; i < n; i++) DeleteMenuItem(menu, n - i); @@ -1592,7 +1598,6 @@ static void dlg_maclist_clear(union control *ctrl, void *dlg) union macctrl *mc = findbyctrl(mcs, ctrl); if (mc == NULL) return; - fprintf(stderr, " maclist_clear\n"); LDelRow(0, 0, mc->listbox.list); mc->listbox.nids = 0; sfree(mc->listbox.ids); @@ -1620,7 +1625,6 @@ static void dlg_macpopup_del(union control *ctrl, void *dlg, int index) MenuRef menu = mc->popup.menu; if (mc == NULL) return; - fprintf(stderr, " popup_del %d\n", index); DeleteMenuItem(menu, index + 1); if (mc->popup.ids != NULL) memcpy(mc->popup.ids + index, mc->popup.ids + index + 1, @@ -1634,7 +1638,6 @@ static void dlg_maclist_del(union control *ctrl, void *dlg, int index) union macctrl *mc = findbyctrl(mcs, ctrl); if (mc == NULL) return; - fprintf(stderr, " maclist_del %d\n", index); LDelRow(1, index, mc->listbox.list); if (mc->listbox.ids != NULL) memcpy(mc->listbox.ids + index, mc->listbox.ids + index + 1, @@ -1663,7 +1666,6 @@ static void dlg_macpopup_add(union control *ctrl, void *dlg, char const *text) Str255 itemstring; if (mc == NULL) return; - fprintf(stderr, " popup_add %s\n", text); assert(text[0] != '\0'); c2pstrcpy(itemstring, text); AppendMenu(menu, "\pdummy"); @@ -1680,7 +1682,6 @@ static void dlg_maclist_add(union control *ctrl, void *dlg, char const *text) Cell cell = { 0, 0 }; if (mc == NULL) return; - fprintf(stderr, " maclist_add %s\n", text); #if TARGET_API_MAC_CARBON GetListDataBounds(mc->listbox.list, &bounds); #else @@ -1714,7 +1715,6 @@ static void dlg_macpopup_addwithid(union control *ctrl, void *dlg, unsigned int index; if (mc == NULL) return; - fprintf(stderr, " popup_addwthid %s, %d\n", text, id); dlg_macpopup_add(ctrl, dlg, text); index = CountMenuItems(menu) - 1; if (mc->popup.nids <= index) { @@ -1733,7 +1733,6 @@ static void dlg_maclist_addwithid(union control *ctrl, void *dlg, int index; if (mc == NULL) return; - fprintf(stderr, " maclist_addwithid %s %d\n", text, id); dlg_maclist_add(ctrl, dlg, text); #if TARGET_API_MAC_CARBON GetListDataBounds(mc->listbox.list, &bounds); @@ -1917,14 +1916,34 @@ void printer_finish_enum(printer_enum *pe) void dlg_coloursel_start(union control *ctrl, void *dlg, int r, int g, int b) { + struct macctrls *mcs = dlg; + union macctrl *mc = findbyctrl(mcs, ctrl); + Point where = {-1, -1}; /* Screen with greatest colour depth */ + RGBColor incolour; + if (HAVE_COLOR_QD()) { + incolour.red = r * 0x0101; + incolour.green = g * 0x0101; + incolour.blue = b * 0x0101; + mcs->gotcolour = GetColor(where, "\pModify Colour:", &incolour, + &mcs->thecolour); + ctrlevent(mcs, mc, EVENT_CALLBACK); + } else + dlg_beep(dlg); } int dlg_coloursel_results(union control *ctrl, void *dlg, int *r, int *g, int *b) { + struct macctrls *mcs = dlg; - return 0; + if (mcs->gotcolour) { + *r = mcs->thecolour.red >> 8; + *g = mcs->thecolour.green >> 8; + *b = mcs->thecolour.blue >> 8; + return 1; + } else + return 0; } /*