X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/blobdiff_plain/25d39ef60aed5cbfcc11f2dd064a3964a8c6ca3b..8ce72d2c1c7651def2425be607ef623e6b0b9bd2:/raw.c?ds=sidebyside diff --git a/raw.c b/raw.c index ff37b6d0..05e453aa 100644 --- a/raw.c +++ b/raw.c @@ -150,14 +150,22 @@ static int raw_msg (WPARAM wParam, LPARAM lParam) { int ret; char buf[256]; - if (s == INVALID_SOCKET) /* how the hell did we get here?! */ - return -5000; + /* + * Because reading less than the whole of the available pending + * data can generate an FD_READ event, we need to allow for the + * possibility that FD_READ may arrive with FD_CLOSE already in + * the queue; so it's possible that we can get here even with s + * invalid. If so, we return 1 and don't worry about it. + */ + if (s == INVALID_SOCKET) + return 1; if (WSAGETSELECTERROR(lParam) != 0) return -WSAGETSELECTERROR(lParam); switch (WSAGETSELECTEVENT(lParam)) { case FD_READ: + case FD_CLOSE: ret = recv(s, buf, sizeof(buf), 0); if (ret < 0 && WSAGetLastError() == WSAEWOULDBLOCK) return 1; @@ -165,7 +173,7 @@ static int raw_msg (WPARAM wParam, LPARAM lParam) { return -10000-WSAGetLastError(); if (ret == 0) { s = INVALID_SOCKET; - return 0; /* can't happen, in theory */ + return 0; } c_write( buf, ret ); return 1; @@ -184,9 +192,6 @@ static int raw_msg (WPARAM wParam, LPARAM lParam) { if (outbuf_head != outbuf_reap) try_write(); return 1; - case FD_CLOSE: - s = INVALID_SOCKET; - return 0; } return 1; /* shouldn't happen, but WTF */ }