X-Git-Url: https://git.distorted.org.uk/u/mdw/putty/blobdiff_plain/12994a99cafd5cf7800fffeecd3dd9e76456b286..c5e438ecf3f6d7b8caab10e43a452f3555149309:/settings.c

diff --git a/settings.c b/settings.c
index 71ae49e4..bce2a62e 100644
--- a/settings.c
+++ b/settings.c
@@ -349,7 +349,23 @@ void load_settings(char *section, int do_host, Config * cfg)
 	    break;
 	}
 
-    gppi(sesskey, "CloseOnExit", COE_NORMAL, &cfg->close_on_exit);
+    /*
+     * CloseOnExit defaults to closing only on a clean exit - but
+     * unfortunately not on Unix (pterm). On Unix, the exit code of
+     * a shell is the last exit code of one of its child processes,
+     * even if it's an interactive shell - so some pterms will
+     * close and some will not for no particularly good reason. The
+     * mode is still useful for specialist purposes (running a
+     * single command in its own pterm), but I don't think it's a
+     * sane default, unfortunately.
+     */
+    gppi(sesskey, "CloseOnExit",
+#ifdef _WINDOWS
+         COE_NORMAL,
+#else
+         COE_ALWAYS,
+#endif
+         &cfg->close_on_exit);
     gppi(sesskey, "WarnOnClose", 1, &cfg->warn_on_close);
     {
 	/* This is two values for backward compatibility with 0.50/0.51 */
@@ -643,10 +659,9 @@ static int sessioncmp(const void *av, const void *bv)
     return strcmp(a, b);	       /* otherwise, compare normally */
 }
 
-void get_sesslist(int allocate)
+void get_sesslist(struct sesslist *list, int allocate)
 {
-    static char otherbuf[2048];
-    static char *buffer;
+    char otherbuf[2048];
     int buflen, bufsize, i;
     char *p, *ret;
     void *handle;
@@ -654,7 +669,7 @@ void get_sesslist(int allocate)
     if (allocate) {
 
 	buflen = bufsize = 0;
-	buffer = NULL;
+	list->buffer = NULL;
 	if ((handle = enum_settings_start())) {
 	    do {
 		ret = enum_settings_next(handle, otherbuf, sizeof(otherbuf));
@@ -662,16 +677,16 @@ void get_sesslist(int allocate)
 		    int len = strlen(otherbuf) + 1;
 		    if (bufsize < buflen + len) {
 			bufsize = buflen + len + 2048;
-			buffer = srealloc(buffer, bufsize);
+			list->buffer = srealloc(list->buffer, bufsize);
 		    }
-		    strcpy(buffer + buflen, otherbuf);
-		    buflen += strlen(buffer + buflen) + 1;
+		    strcpy(list->buffer + buflen, otherbuf);
+		    buflen += strlen(list->buffer + buflen) + 1;
 		}
 	    } while (ret);
 	    enum_settings_finish(handle);
 	}
-	buffer = srealloc(buffer, buflen + 1);
-	buffer[buflen] = '\0';
+	list->buffer = srealloc(list->buffer, buflen + 1);
+	list->buffer[buflen] = '\0';
 
 	/*
 	 * Now set up the list of sessions. Note that "Default
@@ -679,31 +694,31 @@ void get_sesslist(int allocate)
 	 * doesn't really.
 	 */
 
-	p = buffer;
-	nsessions = 1;		       /* "Default Settings" counts as one */
+	p = list->buffer;
+	list->nsessions = 1;	       /* "Default Settings" counts as one */
 	while (*p) {
 	    if (strcmp(p, "Default Settings"))
-		nsessions++;
+		list->nsessions++;
 	    while (*p)
 		p++;
 	    p++;
 	}
 
-	sessions = smalloc((nsessions + 1) * sizeof(char *));
-	sessions[0] = "Default Settings";
-	p = buffer;
+	list->sessions = smalloc((list->nsessions + 1) * sizeof(char *));
+	list->sessions[0] = "Default Settings";
+	p = list->buffer;
 	i = 1;
 	while (*p) {
 	    if (strcmp(p, "Default Settings"))
-		sessions[i++] = p;
+		list->sessions[i++] = p;
 	    while (*p)
 		p++;
 	    p++;
 	}
 
-	qsort(sessions, i, sizeof(char *), sessioncmp);
+	qsort(list->sessions, i, sizeof(char *), sessioncmp);
     } else {
-	sfree(buffer);
-	sfree(sessions);
+	sfree(list->buffer);
+	sfree(list->sessions);
     }
 }