Accelerators and wording change in Pageant systray menu
[u/mdw/putty] / pageant.c
index 6639275..c8979cc 100644 (file)
--- a/pageant.c
+++ b/pageant.c
@@ -3,6 +3,7 @@
  */
 
 #include <windows.h>
+#include <aclapi.h>
 #include <stdio.h> /* FIXME */
 #include "putty.h" /* FIXME */
 #include "ssh.h"
 #define WM_XUSER     (WM_USER + 0x2000)
 #define WM_SYSTRAY   (WM_XUSER + 6)
 #define WM_SYSTRAY2  (WM_XUSER + 7)
-#define WM_CLOSEMEM  (WM_XUSER + 10)
+
+#define AGENT_COPYDATA_ID 0x804e50ba   /* random goop */
+
+/*
+ * FIXME: maybe some day we can sort this out ...
+ */
+#define AGENT_MAX_MSGLEN  8192
 
 #define IDM_CLOSE    0x0010
 #define IDM_VIEWKEYS 0x0020
@@ -37,6 +44,13 @@ HMENU systray_menu;
 
 tree234 *rsakeys;
 
+int has_security;
+typedef DWORD (WINAPI *gsi_fn_t)
+    (HANDLE, SE_OBJECT_TYPE, SECURITY_INFORMATION,
+                                 PSID *, PSID *, PACL *, PACL *,
+                                 PSECURITY_DESCRIPTOR *);
+gsi_fn_t getsecurityinfo;
+
 /*
  * We need this to link with the RSA code, because rsaencrypt()
  * pads its data with random bytes. Since we only use rsadecrypt(),
@@ -120,7 +134,8 @@ void add_keyfile(char *filename) {
     int ret;
     int attempts;
 
-    needs_pass = rsakey_encrypted(filename);
+    /* FIXME: we can acquire comment here and use it in dialog */
+    needs_pass = rsakey_encrypted(filename, NULL);
     attempts = 0;
     key = malloc(sizeof(*key));
     do {
@@ -151,26 +166,17 @@ void add_keyfile(char *filename) {
 /*
  * This is the main agent function that answers messages.
  */
-void answer_msg(void *in, int inlen, void **out, int *outlen) {
-    unsigned char *ret;
-    unsigned char *p = in;
+void answer_msg(void *msg) {
+    unsigned char *p = msg;
+    unsigned char *ret = msg;
     int type;
 
-    *out = NULL;                       /* default `no go' response */
-
-    /*
-     * Basic sanity checks. len >= 5, and len[0:4] holds len-4.
-     */
-    if (inlen < 5 || GET_32BIT(p) != (unsigned long)(inlen-4))
-        return;
-
     /*
      * Get the message type.
      */
     type = p[4];
 
     p += 5;
-
     switch (type) {
       case SSH_AGENTC_REQUEST_RSA_IDENTITIES:
         /*
@@ -198,20 +204,20 @@ void answer_msg(void *in, int inlen, void **out, int *outlen) {
              * bytes for the key count.
              */
             len += 5 + 4;
-            if ((ret = malloc(len)) != NULL) {
-                PUT_32BIT(ret, len-4);
-                ret[4] = SSH_AGENT_RSA_IDENTITIES_ANSWER;
-                PUT_32BIT(ret+5, nkeys);
-                p = ret + 5 + 4;
-                for (key = first234(rsakeys, &e); key; key = next234(&e)) {
-                    PUT_32BIT(p, ssh1_bignum_bitcount(key->modulus));
-                    p += 4;
-                    p += ssh1_write_bignum(p, key->exponent);
-                    p += ssh1_write_bignum(p, key->modulus);
-                    PUT_32BIT(p, strlen(key->comment));
-                    memcpy(p+4, key->comment, strlen(key->comment));
-                    p += 4 + strlen(key->comment);
-                }
+            if (len > AGENT_MAX_MSGLEN)
+                goto failure;          /* aaargh! too much stuff! */
+            PUT_32BIT(ret, len-4);
+            ret[4] = SSH_AGENT_RSA_IDENTITIES_ANSWER;
+            PUT_32BIT(ret+5, nkeys);
+            p = ret + 5 + 4;
+            for (key = first234(rsakeys, &e); key; key = next234(&e)) {
+                PUT_32BIT(p, ssh1_bignum_bitcount(key->modulus));
+                p += 4;
+                p += ssh1_write_bignum(p, key->exponent);
+                p += ssh1_write_bignum(p, key->modulus);
+                PUT_32BIT(p, strlen(key->comment));
+                memcpy(p+4, key->comment, strlen(key->comment));
+                p += 4 + strlen(key->comment);
             }
         }
         break;
@@ -258,11 +264,9 @@ void answer_msg(void *in, int inlen, void **out, int *outlen) {
              * bytes of MD5.
              */
             len = 5 + 16;
-            if ((ret = malloc(len)) != NULL) {
-                PUT_32BIT(ret, len-4);
-                ret[4] = SSH_AGENT_RSA_RESPONSE;
-                memcpy(ret+5, response_md5, 16);
-            }
+            PUT_32BIT(ret, len-4);
+            ret[4] = SSH_AGENT_RSA_RESPONSE;
+            memcpy(ret+5, response_md5, 16);
         }
         break;
 #if 0 /* FIXME: implement these */
@@ -285,17 +289,10 @@ void answer_msg(void *in, int inlen, void **out, int *outlen) {
         /*
          * Unrecognised message. Return SSH_AGENT_FAILURE.
          */
-        if ((ret = malloc(5)) != NULL) {
-            PUT_32BIT(ret, 1);
-            ret[4] = SSH_AGENT_FAILURE;
-        }
+        PUT_32BIT(ret, 1);
+        ret[4] = SSH_AGENT_FAILURE;
         break;
     }
-
-    if (ret) {
-        *out = ret;
-        *outlen = 4 + GET_32BIT(ret);
-    }
 }
 
 /*
@@ -431,6 +428,9 @@ static LRESULT CALLBACK WndProc (HWND hwnd, UINT message,
             POINT cursorpos;
             GetCursorPos(&cursorpos);
             PostMessage(hwnd, WM_SYSTRAY2, cursorpos.x, cursorpos.y);
+        } else if (lParam == WM_LBUTTONDBLCLK) {
+            /* Equivalent to IDM_VIEWKEYS. */
+            PostMessage(hwnd, WM_COMMAND, IDM_VIEWKEYS, 0);
         }
         break;
       case WM_SYSTRAY2:
@@ -455,6 +455,13 @@ static LRESULT CALLBACK WndProc (HWND hwnd, UINT message,
                 keylist = CreateDialog (instance, MAKEINTRESOURCE(211),
                                         NULL, KeyListProc);
                 ShowWindow (keylist, SW_SHOWNORMAL);
+                /* 
+                 * Sometimes the window comes up minimised / hidden
+                 * for no obvious reason. Prevent this.
+                 */
+                SetForegroundWindow(keylist);
+                SetWindowPos (keylist, HWND_TOP, 0, 0, 0, 0,
+                              SWP_NOMOVE | SWP_NOSIZE | SWP_SHOWWINDOW);
             }
             break;
         }
@@ -465,45 +472,83 @@ static LRESULT CALLBACK WndProc (HWND hwnd, UINT message,
       case WM_COPYDATA:
         {
             COPYDATASTRUCT *cds;
-            void *in, *out, *ret;
-            int inlen, outlen;
-            HANDLE filemap;
-            char mapname[64];
-            int id;
+            char *mapname;
+            void *p;
+            HANDLE filemap, proc;
+            PSID mapowner, procowner;
+            PSECURITY_DESCRIPTOR psd1 = NULL, psd2 = NULL;
+            int ret = 0;
 
             cds = (COPYDATASTRUCT *)lParam;
-            /*
-             * FIXME: use dwData somehow.
-             */
-            in = cds->lpData;
-            inlen = cds->cbData;
-            answer_msg(in, inlen, &out, &outlen);
-            if (out) {
-                id = 0;
-                do {
-                    sprintf(mapname, "PageantReply%08x", ++id);
-                   filemap = CreateFileMapping(INVALID_HANDLE_VALUE,
-                                                NULL, PAGE_READWRITE,
-                                               0, outlen+sizeof(int),
-                                                mapname);
-                } while (filemap == INVALID_HANDLE_VALUE);
-                ret = MapViewOfFile(filemap, FILE_MAP_WRITE, 0, 0,
-                                    outlen+sizeof(int));
-                if (ret) {
-                    *((int *)ret) = outlen;
-                    memcpy(((int *)ret)+1, out, outlen);
-                    UnmapViewOfFile(ret);
-                    return id;
+            if (cds->dwData != AGENT_COPYDATA_ID)
+                return 0;              /* not our message, mate */
+            mapname = (char *)cds->lpData;
+            if (mapname[cds->cbData - 1] != '\0')
+                return 0;              /* failure to be ASCIZ! */
+#ifdef DEBUG_IPC
+            debug(("mapname is :%s:\r\n", mapname));
+#endif
+            filemap = OpenFileMapping(FILE_MAP_ALL_ACCESS, FALSE, mapname);
+#ifdef DEBUG_IPC
+            debug(("filemap is %p\r\n", filemap));
+#endif
+            if (filemap != NULL && filemap != INVALID_HANDLE_VALUE) {
+                int rc;
+                if (has_security) {
+                    if ((proc = OpenProcess(MAXIMUM_ALLOWED, FALSE,
+                                            GetCurrentProcessId())) == NULL) {
+#ifdef DEBUG_IPC
+                        debug(("couldn't get handle for process\r\n"));
+#endif
+                        return 0;
+                    }
+                    if (getsecurityinfo(proc, SE_KERNEL_OBJECT,
+                                        OWNER_SECURITY_INFORMATION,
+                                        &procowner, NULL, NULL, NULL,
+                                        &psd2) != ERROR_SUCCESS) {
+#ifdef DEBUG_IPC
+                        debug(("couldn't get owner info for process\r\n"));
+#endif
+                        CloseHandle(proc);
+                        return 0;          /* unable to get security info */
+                    }
+                    CloseHandle(proc);
+                    if ((rc = getsecurityinfo(filemap, SE_KERNEL_OBJECT,
+                                              OWNER_SECURITY_INFORMATION,
+                                              &mapowner, NULL, NULL, NULL,
+                                              &psd1) != ERROR_SUCCESS)) {
+#ifdef DEBUG_IPC
+                        debug(("couldn't get owner info for filemap: %d\r\n", rc));
+#endif
+                        return 0;
+                    }
+#ifdef DEBUG_IPC
+                    debug(("got security stuff\r\n"));
+#endif
+                    if (!EqualSid(mapowner, procowner))
+                        return 0;          /* security ID mismatch! */
+#ifdef DEBUG_IPC
+                    debug(("security stuff matched\r\n"));
+#endif
+                    LocalFree(psd1);
+                    LocalFree(psd2);
+                } else {
+#ifdef DEBUG_IPC
+                    debug(("security APIs not present\r\n"));
+#endif
                 }
-            } else
-                return 0;              /* invalid request */
+                p = MapViewOfFile(filemap, FILE_MAP_WRITE, 0, 0, 0);
+#ifdef DEBUG_IPC
+                debug(("p is %p\r\n", p));
+                {int i; for(i=0;i<5;i++)debug(("p[%d]=%02x\r\n", i, ((unsigned char *)p)[i]));}
+#endif
+                answer_msg(p);
+                ret = 1;
+                UnmapViewOfFile(p);
+            }
+            CloseHandle(filemap);
+            return ret;
         }
-        break;
-      case WM_CLOSEMEM:
-        /*
-         * FIXME!
-         */
-        break;
     }
 
     return DefWindowProc (hwnd, message, wParam, lParam);
@@ -512,6 +557,45 @@ static LRESULT CALLBACK WndProc (HWND hwnd, UINT message,
 int WINAPI WinMain(HINSTANCE inst, HINSTANCE prev, LPSTR cmdline, int show) {
     WNDCLASS wndclass;
     MSG msg;
+    OSVERSIONINFO osi;
+    HMODULE advapi;
+
+    /*
+     * Determine whether we're an NT system (should have security
+     * APIs) or a non-NT system (don't do security).
+     */
+    memset(&osi, 0, sizeof(OSVERSIONINFO));
+    osi.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
+    if (GetVersionEx(&osi) && osi.dwPlatformId==VER_PLATFORM_WIN32_NT) {
+        has_security = TRUE;
+    } else
+        has_security = FALSE;
+
+    if (has_security) {
+        /*
+         * Attempt to ge the security API we need.
+         */
+        advapi = LoadLibrary("ADVAPI32.DLL");
+        getsecurityinfo = (gsi_fn_t)GetProcAddress(advapi, "GetSecurityInfo");
+        if (!getsecurityinfo) {
+            MessageBox(NULL,
+                       "Unable to access security APIs. Pageant will\n"
+                       "not run, in case it causes a security breach.",
+                       "Pageant Fatal Error", MB_ICONERROR | MB_OK);
+            return 1;
+        }
+    } else
+        advapi = NULL;
+
+    /*
+     * First bomb out totally if we are already running.
+     */
+    if (FindWindow("Pageant", "Pageant")) {
+        MessageBox(NULL, "Pageant is already running", "Pageant Error",
+                   MB_ICONERROR | MB_OK);
+        if (advapi) FreeLibrary(advapi);
+        return 0;
+    }
 
     instance = inst;
 
@@ -563,8 +647,8 @@ int WINAPI WinMain(HINSTANCE inst, HINSTANCE prev, LPSTR cmdline, int show) {
             DestroyIcon(hicon); 
 
         systray_menu = CreatePopupMenu();
-        AppendMenu (systray_menu, MF_ENABLED, IDM_VIEWKEYS, "View Keys");
-        AppendMenu (systray_menu, MF_ENABLED, IDM_CLOSE, "Terminate");
+        AppendMenu (systray_menu, MF_ENABLED, IDM_VIEWKEYS, "&View Keys");
+        AppendMenu (systray_menu, MF_ENABLED, IDM_CLOSE, "E&xit");
     }
 
     ShowWindow (hwnd, SW_HIDE);
@@ -576,16 +660,28 @@ int WINAPI WinMain(HINSTANCE inst, HINSTANCE prev, LPSTR cmdline, int show) {
 
     /*
      * Process the command line and add RSA keys as listed on it.
-     * FIXME: we don't support spaces in filenames here. We should.
      */
     {
-        char *p = cmdline;
+        char *p;
+        int inquotes = 0;
+        p = cmdline;
         while (*p) {
             while (*p && isspace(*p)) p++;
             if (*p && !isspace(*p)) {
-                char *q = p;
-                while (*p && !isspace(*p)) p++;
-                if (*p) *p++ = '\0';
+                char *q = p, *pp = p;
+                while (*p && (inquotes || !isspace(*p)))
+                {
+                    if (*p == '"') {
+                        inquotes = !inquotes;
+                        p++;
+                        continue;
+                    }
+                    *pp++ = *p++;
+                }
+                if (*pp) {
+                    if (*p) p++;
+                    *pp++ = '\0';
+                }
                 add_keyfile(q);
             }
         }
@@ -612,5 +708,6 @@ int WINAPI WinMain(HINSTANCE inst, HINSTANCE prev, LPSTR cmdline, int show) {
         DestroyMenu(systray_menu);
     }
 
+    if (advapi) FreeLibrary(advapi);
     exit(msg.wParam);
 }