projects
/
u
/
mdw
/
putty
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Add another missing bounds check in the SSH-1 private key loader.
[u/mdw/putty]
/
ssharcf.c
diff --git
a/ssharcf.c
b/ssharcf.c
index
2381d88
..
06f235c
100644
(file)
--- a/
ssharcf.c
+++ b/
ssharcf.c
@@
-19,7
+19,7
@@
static void arcfour_block(void *handle, unsigned char *blk, int len)
s = ctx->s;
i = ctx->i; j = ctx->j;
s = ctx->s;
i = ctx->i; j = ctx->j;
- for (k = 0; k < len; k++) {
+ for (k = 0;
(int)
k < len; k++) {
i = (i + 1) & 0xff;
j = (j + s[i]) & 0xff;
tmp = s[i]; s[i] = s[j]; s[j] = tmp;
i = (i + 1) & 0xff;
j = (j + s[i]) & 0xff;
tmp = s[i]; s[i] = s[j]; s[j] = tmp;
@@
-75,7
+75,7
@@
static void arcfour_stir(ArcfourContext *ctx)
unsigned char *junk = snewn(1536, unsigned char);
memset(junk, 0, 1536);
arcfour_block(ctx, junk, 1536);
unsigned char *junk = snewn(1536, unsigned char);
memset(junk, 0, 1536);
arcfour_block(ctx, junk, 1536);
-
memset(junk, 0
, 1536);
+
smemclr(junk
, 1536);
sfree(junk);
}
sfree(junk);
}