When we fail to get a response from Pageant, we should log the fact.

[u/mdw/putty] / ssh.c

diff --git a/ssh.c b/ssh.c
index 95fa2f2..05530fe 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -3744,7 +3744,9 @@ static int do_ssh1_login(Ssh ssh, unsigned char *in, int inlen,
                sfree(s->response);
                if (s->publickey_blob && !s->tried_publickey)
                    logevent("Configured key file not in Pageant");
-           }
+           } else {
+                logevent("Failed to get reply from Pageant");
+            }
            if (s->authed)
                break;
        }
@@ -7500,6 +7502,8 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen,
                        s->nkeys = 0;
                    }
                }
+           } else {
+                logevent("Failed to get reply from Pageant");
            }
        }
 
@@ -9131,10 +9135,9 @@ static void ssh2_msg_debug(Ssh ssh, struct Packet *pktin)
     /* log the debug message */
     char *msg;
     int msglen;
-    int always_display;
 
-    /* XXX maybe we should actually take notice of this */
-    always_display = ssh2_pkt_getbool(pktin);
+    /* XXX maybe we should actually take notice of the return value */
+    ssh2_pkt_getbool(pktin);
     ssh_pkt_getstring(pktin, &msg, &msglen);
 
     logeventf(ssh, "Remote debug message: %.*s", msglen, msg);