Robustness fixes for KEXINIT handling and others. In particular, I've

[u/mdw/putty] / rlogin.c

diff --git a/rlogin.c b/rlogin.c
index 942a07e..b43804d 100644 (file)
--- a/rlogin.c
+++ b/rlogin.c
@@ -121,9 +121,10 @@ static char *rlogin_init(void *frontend_handle, void **backend_handle,
      * Try to find host.
      */
     {
-       char buf[200];
-       sprintf(buf, "Looking up host \"%.170s\"", host);
+       char *buf;
+       buf = dupprintf("Looking up host \"%s\"", host);
        logevent(rlogin->frontend, buf);
+       sfree(buf);
     }
     addr = sk_namelookup(host, realhost);
     if ((err = sk_addr_error(addr)))
@@ -136,10 +137,11 @@ static char *rlogin_init(void *frontend_handle, void **backend_handle,
      * Open socket.
      */
     {
-       char buf[200], addrbuf[100];
+       char *buf, addrbuf[100];
        sk_getaddr(addr, addrbuf, 100);
-       sprintf(buf, "Connecting to %.100s port %d", addrbuf, port);
+       buf = dupprintf("Connecting to %s port %d", addrbuf, port);
        logevent(rlogin->frontend, buf);
+       sfree(buf);
     }
     rlogin->s = new_connection(addr, *realhost, port, 1, 0,
                               nodelay, (Plug) rlogin);