Colin's const-fixing Patch Of Death. Seems to build fine on Windows
[u/mdw/putty] / ssh.c
diff --git a/ssh.c b/ssh.c
index 6abdb28..337cfa8 100644 (file)
--- a/ssh.c
+++ b/ssh.c
@@ -322,6 +322,8 @@ static unsigned char *ssh2_mpint_fmt(Bignum b, int *len);
 static void ssh2_pkt_addmp(Ssh, Bignum b);
 static int ssh2_pkt_construct(Ssh);
 static void ssh2_pkt_send(Ssh);
+static int do_ssh1_login(Ssh ssh, unsigned char *in, int inlen, int ispkt);
+static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt);
 
 /*
  * Buffer management constants. There are several of these for
@@ -515,6 +517,7 @@ static void ssh2_add_channel_data(struct ssh_channel *c, char *buf, int len);
 static void ssh_throttle_all(Ssh ssh, int enable, int bufsize);
 static void ssh2_set_window(struct ssh_channel *c, unsigned newwin);
 static int ssh_sendbuffer(void *handle);
+static void ssh_do_close(Ssh ssh);
 
 struct rdpkt1_state_tag {
     long len, pad, biglen, to_read;
@@ -648,12 +651,18 @@ struct ssh_tag {
      * potentially reconfigure port forwardings etc in mid-session.
      */
     Config cfg;
+
+    /*
+     * Used to transfer data back from async agent callbacks.
+     */
+    void *agent_response;
+    int agent_response_len;
 };
 
 #define logevent(s) logevent(ssh->frontend, s)
 
 /* logevent, only printf-formatted. */
-static void logeventf(Ssh ssh, char *fmt, ...)
+static void logeventf(Ssh ssh, const char *fmt, ...)
 {
     va_list ap;
     char *buf;
@@ -668,8 +677,7 @@ static void logeventf(Ssh ssh, char *fmt, ...)
 #define bombout(msg) \
     do { \
         char *text = dupprintf msg; \
-        ssh->state = SSH_STATE_CLOSED; \
-        if (ssh->s) { sk_close(ssh->s); ssh->s = NULL; } \
+       ssh_do_close(ssh); \
         logevent(text); \
         connection_fatal(ssh->frontend, "%s", text); \
         sfree(text); \
@@ -2037,19 +2045,47 @@ static void ssh_gotdata(Ssh ssh, unsigned char *data, int datalen)
     crFinishV;
 }
 
-static int ssh_closing(Plug plug, char *error_msg, int error_code,
-                      int calling_back)
+static void ssh_do_close(Ssh ssh)
 {
-    Ssh ssh = (Ssh) plug;
+    int i;
+    struct ssh_channel *c;
+
     ssh->state = SSH_STATE_CLOSED;
     if (ssh->s) {
         sk_close(ssh->s);
         ssh->s = NULL;
     }
+    /*
+     * Now we must shut down any port and X forwardings going
+     * through this connection.
+     */
+    if (ssh->channels) {
+       for (i = 0; NULL != (c = index234(ssh->channels, i)); i++) {
+           switch (c->type) {
+             case CHAN_X11:
+               x11_close(c->u.x11.s);
+               break;
+             case CHAN_SOCKDATA:
+               pfd_close(c->u.pfd.s);
+               break;
+           }
+           del234(ssh->channels, c);
+           if (ssh->version == 2)
+               bufchain_clear(&c->v.v2.outbuffer);
+           sfree(c);
+       }
+    }
+}
+
+static int ssh_closing(Plug plug, const char *error_msg, int error_code,
+                      int calling_back)
+{
+    Ssh ssh = (Ssh) plug;
+    ssh_do_close(ssh);
     if (error_msg) {
        /* A socket error has occurred. */
        logevent(error_msg);
-       connection_fatal(ssh->frontend, error_msg);
+       connection_fatal(ssh->frontend, "%s", error_msg);
     } else {
        /* Otherwise, the remote side closed the connection normally. */
     }
@@ -2061,10 +2097,7 @@ static int ssh_receive(Plug plug, int urgent, char *data, int len)
     Ssh ssh = (Ssh) plug;
     ssh_gotdata(ssh, (unsigned char *)data, len);
     if (ssh->state == SSH_STATE_CLOSED) {
-       if (ssh->s) {
-           sk_close(ssh->s);
-           ssh->s = NULL;
-       }
+       ssh_do_close(ssh);
        return 0;
     }
     return 1;
@@ -2087,8 +2120,8 @@ static void ssh_sent(Plug plug, int bufsize)
  * Also places the canonical host name into `realhost'. It must be
  * freed by the caller.
  */
-static char *connect_to_host(Ssh ssh, char *host, int port,
-                            char **realhost, int nodelay)
+static const char *connect_to_host(Ssh ssh, char *host, int port,
+                                  char **realhost, int nodelay)
 {
     static const struct plug_function_table fn_table = {
        ssh_closing,
@@ -2098,7 +2131,7 @@ static char *connect_to_host(Ssh ssh, char *host, int port,
     };
 
     SockAddr addr;
-    char *err;
+    const char *err;
 
     ssh->savedhost = snewn(1 + strlen(host), char);
     if (!ssh->savedhost)
@@ -2180,7 +2213,7 @@ static void ssh_throttle_all(Ssh ssh, int enable, int bufsize)
            /* Agent channels require no buffer management. */
            break;
          case CHAN_SOCKDATA:
-           pfd_override_throttle(c->u.x11.s, enable);
+           pfd_override_throttle(c->u.pfd.s, enable);
            break;
        }
     }
@@ -2258,6 +2291,44 @@ static int process_userpass_input(Ssh ssh, unsigned char *in, int inlen)
     return 0;
 }
 
+void ssh_agent_callback(void *sshv, void *reply, int replylen)
+{
+    Ssh ssh = (Ssh) sshv;
+
+    ssh->agent_response = reply;
+    ssh->agent_response_len = replylen;
+
+    if (ssh->version == 1)
+       do_ssh1_login(ssh, NULL, -1, 0);
+    else
+       do_ssh2_authconn(ssh, NULL, -1, 0);
+}
+
+void ssh_agentf_callback(void *cv, void *reply, int replylen)
+{
+    struct ssh_channel *c = (struct ssh_channel *)cv;
+    Ssh ssh = c->ssh;
+    void *sentreply = reply;
+
+    if (!sentreply) {
+       /* Fake SSH_AGENT_FAILURE. */
+       sentreply = "\0\0\0\1\5";
+       replylen = 5;
+    }
+    if (ssh->version == 2) {
+       ssh2_add_channel_data(c, sentreply, replylen);
+       ssh2_try_send(c);
+    } else {
+       send_packet(ssh, SSH1_MSG_CHANNEL_DATA,
+                   PKT_INT, c->remoteid,
+                   PKT_INT, replylen,
+                   PKT_DATA, sentreply, replylen,
+                   PKT_END);
+    }
+    if (reply)
+       sfree(reply);
+}
+
 /*
  * Handle the key exchange and user authentication phases.
  */
@@ -2544,7 +2615,19 @@ static int do_ssh1_login(Ssh ssh, unsigned char *in, int inlen, int ispkt)
            /* Request the keys held by the agent. */
            PUT_32BIT(s->request, 1);
            s->request[4] = SSH1_AGENTC_REQUEST_RSA_IDENTITIES;
-           agent_query(s->request, 5, &r, &s->responselen);
+           if (!agent_query(s->request, 5, &r, &s->responselen,
+                            ssh_agent_callback, ssh)) {
+               do {
+                   crReturn(0);
+                   if (ispkt) {
+                       bombout(("Unexpected data from server while waiting"
+                                " for agent response"));
+                       crStop(0);
+                   }
+               } while (ispkt || inlen > 0);
+               r = ssh->agent_response;
+               s->responselen = ssh->agent_response_len;
+           }
            s->response = (unsigned char *) r;
            if (s->response && s->responselen >= 5 &&
                s->response[4] == SSH1_AGENT_RSA_IDENTITIES_ANSWER) {
@@ -2606,9 +2689,23 @@ static int do_ssh1_login(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                        memcpy(q, s->session_id, 16);
                        q += 16;
                        PUT_32BIT(q, 1);        /* response format */
-                       agent_query(agentreq, len + 4, &vret, &retlen);
+                       if (!agent_query(agentreq, len + 4, &vret, &retlen,
+                                        ssh_agent_callback, ssh)) {
+                           sfree(agentreq);
+                           do {
+                               crReturn(0);
+                               if (ispkt) {
+                                   bombout(("Unexpected data from server"
+                                            " while waiting for agent"
+                                            " response"));
+                                   crStop(0);
+                               }
+                           } while (ispkt || inlen > 0);
+                           vret = ssh->agent_response;
+                           retlen = ssh->agent_response_len;
+                       } else
+                           sfree(agentreq);
                        ret = vret;
-                       sfree(agentreq);
                        if (ret) {
                            if (ret[4] == SSH1_AGENT_RSA_RESPONSE) {
                                logevent("Sending Pageant's response");
@@ -2992,6 +3089,11 @@ void sshfwd_close(struct ssh_channel *c)
 {
     Ssh ssh = c->ssh;
 
+    if (ssh->state != SSH_STATE_SESSION) {
+       assert(ssh->state == SSH_STATE_CLOSED);
+       return;
+    }
+
     if (c && !c->closes) {
        /*
         * If the channel's remoteid is -1, we have sent
@@ -3026,6 +3128,11 @@ int sshfwd_write(struct ssh_channel *c, char *buf, int len)
 {
     Ssh ssh = c->ssh;
 
+    if (ssh->state != SSH_STATE_SESSION) {
+       assert(ssh->state == SSH_STATE_CLOSED);
+       return 0;
+    }
+
     if (ssh->version == 1) {
        send_packet(ssh, SSH1_MSG_CHANNEL_DATA,
                    PKT_INT, c->remoteid,
@@ -3048,6 +3155,11 @@ void sshfwd_unthrottle(struct ssh_channel *c, int bufsize)
 {
     Ssh ssh = c->ssh;
 
+    if (ssh->state != SSH_STATE_SESSION) {
+       assert(ssh->state == SSH_STATE_CLOSED);
+       return;
+    }
+
     if (ssh->version == 1) {
        if (c->v.v1.throttling && bufsize < SSH1_BUFFER_LIMIT) {
            c->v.v1.throttling = 0;
@@ -3416,7 +3528,8 @@ static void ssh1_protocol(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                struct ssh_rportfwd pf;
                int hostsize, port;
                char host[256], buf[1024];
-               char *p, *h, *e;
+               char *p, *h;
+               const char *e;
                c = snew(struct ssh_channel);
                c->ssh = ssh;
 
@@ -3589,25 +3702,13 @@ static void ssh1_protocol(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                                c->u.a.lensofar += l;
                            }
                            if (c->u.a.lensofar == c->u.a.totallen) {
-                               void *reply, *sentreply;
+                               void *reply;
                                int replylen;
-                               agent_query(c->u.a.message,
-                                           c->u.a.totallen, &reply,
-                                           &replylen);
-                               if (reply)
-                                   sentreply = reply;
-                               else {
-                                   /* Fake SSH_AGENT_FAILURE. */
-                                   sentreply = "\0\0\0\1\5";
-                                   replylen = 5;
-                               }
-                               send_packet(ssh, SSH1_MSG_CHANNEL_DATA,
-                                           PKT_INT, c->remoteid,
-                                           PKT_INT, replylen,
-                                           PKT_DATA, sentreply, replylen,
-                                           PKT_END);
-                               if (reply)
-                                   sfree(reply);
+                               if (agent_query(c->u.a.message,
+                                               c->u.a.totallen,
+                                               &reply, &replylen,
+                                               ssh_agentf_callback, c))
+                                   ssh_agentf_callback(c, reply, replylen);
                                sfree(c->u.a.message);
                                c->u.a.lensofar = 0;
                            }
@@ -4633,7 +4734,19 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                /* Request the keys held by the agent. */
                PUT_32BIT(s->request, 1);
                s->request[4] = SSH2_AGENTC_REQUEST_IDENTITIES;
-               agent_query(s->request, 5, &r, &s->responselen);
+               if (!agent_query(s->request, 5, &r, &s->responselen,
+                                ssh_agent_callback, ssh)) {
+                   do {
+                       crReturnV;
+                       if (ispkt) {
+                           bombout(("Unexpected data from server while"
+                                    " waiting for agent response"));
+                           crStopV;
+                       }
+                   } while (ispkt || inlen > 0);
+                   r = ssh->agent_response;
+                   s->responselen = ssh->agent_response_len;
+               }
                s->response = (unsigned char *) r;
                if (s->response && s->responselen >= 5 &&
                    s->response[4] == SSH2_AGENT_IDENTITIES_ANSWER) {
@@ -4737,7 +4850,21 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                        s->q += ssh->pktout.length - 5;
                        /* And finally the (zero) flags word. */
                        PUT_32BIT(s->q, 0);
-                       agent_query(s->agentreq, s->len + 4, &vret, &s->retlen);
+                       if (!agent_query(s->agentreq, s->len + 4,
+                                        &vret, &s->retlen,
+                                        ssh_agent_callback, ssh)) {
+                           do {
+                               crReturnV;
+                               if (ispkt) {
+                                   bombout(("Unexpected data from server"
+                                            " while waiting for agent"
+                                            " response"));
+                                   crStopV;
+                               }
+                           } while (ispkt || inlen > 0);
+                           vret = ssh->agent_response;
+                           s->retlen = ssh->agent_response_len;
+                       }
                        s->ret = vret;
                        sfree(s->agentreq);
                        if (s->ret) {
@@ -5592,22 +5719,13 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                                c->u.a.lensofar += l;
                            }
                            if (c->u.a.lensofar == c->u.a.totallen) {
-                               void *reply, *sentreply;
+                               void *reply;
                                int replylen;
-                               agent_query(c->u.a.message,
-                                           c->u.a.totallen, &reply,
-                                           &replylen);
-                               if (reply)
-                                   sentreply = reply;
-                               else {
-                                   /* Fake SSH_AGENT_FAILURE. */
-                                   sentreply = "\0\0\0\1\5";
-                                   replylen = 5;
-                               }
-                               ssh2_add_channel_data(c, sentreply, replylen);
-                               s->try_send = TRUE;
-                               if (reply)
-                                   sfree(reply);
+                               if (agent_query(c->u.a.message,
+                                               c->u.a.totallen,
+                                               &reply, &replylen,
+                                               ssh_agentf_callback, c))
+                                   ssh_agentf_callback(c, reply, replylen);
                                sfree(c->u.a.message);
                                c->u.a.lensofar = 0;
                            }
@@ -5883,8 +6001,10 @@ static void do_ssh2_authconn(Ssh ssh, unsigned char *in, int inlen, int ispkt)
                    if (realpf == NULL) {
                        error = "Remote port is not recognised";
                    } else {
-                       char *e = pfd_newconnect(&c->u.pfd.s, realpf->dhost,
-                                                realpf->dport, c, &ssh->cfg);
+                       const char *e = pfd_newconnect(&c->u.pfd.s,
+                                                      realpf->dhost,
+                                                      realpf->dport, c,
+                                                      &ssh->cfg);
                        logeventf(ssh, "Received remote port open request"
                                  " for %s:%d", realpf->dhost, realpf->dport);
                        if (e != NULL) {
@@ -5993,11 +6113,11 @@ static void ssh2_protocol(Ssh ssh, unsigned char *in, int inlen, int ispkt)
  *
  * Returns an error message, or NULL on success.
  */
-static char *ssh_init(void *frontend_handle, void **backend_handle,
-                     Config *cfg,
-                     char *host, int port, char **realhost, int nodelay)
+static const char *ssh_init(void *frontend_handle, void **backend_handle,
+                           Config *cfg,
+                           char *host, int port, char **realhost, int nodelay)
 {
-    char *p;
+    const char *p;
     Ssh ssh;
 
     ssh = snew(struct ssh_tag);
@@ -6141,7 +6261,7 @@ static void ssh_free(void *handle)
     sfree(ssh->do_ssh2_authconn_state);
     
     if (ssh->s)
-       sk_close(ssh->s);
+       ssh_do_close(ssh);
     sfree(ssh);
 }