projects
/
u
/
mdw
/
putty
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Implement MD5 MAC for the benefit of old SSH2 servers
[u/mdw/putty]
/
ssh.c
diff --git
a/ssh.c
b/ssh.c
index
f0a26aa
..
342bc53
100644
(file)
--- a/
ssh.c
+++ b/
ssh.c
@@
-25,7
+25,7
@@
if ((flags & FLAG_STDERR) && (flags & FLAG_VERBOSE)) \
fprintf(stderr, "%s\n", s); }
if ((flags & FLAG_STDERR) && (flags & FLAG_VERBOSE)) \
fprintf(stderr, "%s\n", s); }
-#define bombout(msg) ( ssh_state =
=
SSH_STATE_CLOSED, closesocket(s), \
+#define bombout(msg) ( ssh_state = SSH_STATE_CLOSED, closesocket(s), \
s = INVALID_SOCKET, connection_fatal msg )
#define SSH1_MSG_DISCONNECT 1 /* 0x1 */
s = INVALID_SOCKET, connection_fatal msg )
#define SSH1_MSG_DISCONNECT 1 /* 0x1 */
@@
-167,7
+167,7
@@
const static struct ssh_kex *kex_algs[] = { &ssh_diffiehellman };
extern const struct ssh_hostkey ssh_dss;
const static struct ssh_hostkey *hostkey_algs[] = { &ssh_dss };
extern const struct ssh_hostkey ssh_dss;
const static struct ssh_hostkey *hostkey_algs[] = { &ssh_dss };
-extern const struct ssh_mac ssh_
sha1
;
+extern const struct ssh_mac ssh_
md5, ssh_sha1, ssh_sha1_buggy
;
static void nullmac_key(unsigned char *key) { }
static void nullmac_generate(unsigned char *blk, int len, unsigned long seq) { }
static void nullmac_key(unsigned char *key) { }
static void nullmac_generate(unsigned char *blk, int len, unsigned long seq) { }
@@
-175,7
+175,10
@@
static int nullmac_verify(unsigned char *blk, int len, unsigned long seq) { retu
const static struct ssh_mac ssh_mac_none = {
nullmac_key, nullmac_key, nullmac_generate, nullmac_verify, "none", 0
};
const static struct ssh_mac ssh_mac_none = {
nullmac_key, nullmac_key, nullmac_generate, nullmac_verify, "none", 0
};
-const static struct ssh_mac *macs[] = { &ssh_sha1, &ssh_mac_none };
+const static struct ssh_mac *macs[] = {
+ &ssh_sha1, &ssh_md5, &ssh_mac_none };
+const static struct ssh_mac *buggymacs[] = {
+ &ssh_sha1_buggy, &ssh_md5, &ssh_mac_none };
const static struct ssh_compress ssh_comp_none = {
"none"
const static struct ssh_compress ssh_comp_none = {
"none"
@@
-1828,6
+1831,8
@@
static int do_ssh2_transport(unsigned char *in, int inlen, int ispkt)
static int i, len;
static char *str;
static Bignum e, f, K;
static int i, len;
static char *str;
static Bignum e, f, K;
+ static const struct ssh_mac **maclist;
+ static int nmacs;
static const struct ssh_cipher *cscipher_tobe = NULL;
static const struct ssh_cipher *sccipher_tobe = NULL;
static const struct ssh_mac *csmac_tobe = NULL;
static const struct ssh_cipher *cscipher_tobe = NULL;
static const struct ssh_cipher *sccipher_tobe = NULL;
static const struct ssh_mac *csmac_tobe = NULL;
@@
-1858,6
+1863,14
@@
static int do_ssh2_transport(unsigned char *in, int inlen, int ispkt)
preferred_cipher = &ssh_3des_ssh2;
}
preferred_cipher = &ssh_3des_ssh2;
}
+ /*
+ * Be prepared to work around the buggy MAC problem.
+ */
+ if (cfg.buggymac)
+ maclist = buggymacs, nmacs = lenof(buggymacs);
+ else
+ maclist = macs, nmacs = lenof(macs);
+
begin_key_exchange:
/*
* Construct and send our key exchange packet.
begin_key_exchange:
/*
* Construct and send our key exchange packet.
@@
-1897,16
+1910,16
@@
static int do_ssh2_transport(unsigned char *in, int inlen, int ispkt)
}
/* List client->server MAC algorithms. */
ssh2_pkt_addstring_start();
}
/* List client->server MAC algorithms. */
ssh2_pkt_addstring_start();
- for (i = 0; i <
lenof(macs)
; i++) {
- ssh2_pkt_addstring_str(mac
s
[i]->name);
- if (i <
lenof(macs)
-1)
+ for (i = 0; i <
nmacs
; i++) {
+ ssh2_pkt_addstring_str(mac
list
[i]->name);
+ if (i <
nmacs
-1)
ssh2_pkt_addstring_str(",");
}
/* List server->client MAC algorithms. */
ssh2_pkt_addstring_start();
ssh2_pkt_addstring_str(",");
}
/* List server->client MAC algorithms. */
ssh2_pkt_addstring_start();
- for (i = 0; i <
lenof(macs)
; i++) {
- ssh2_pkt_addstring_str(mac
s
[i]->name);
- if (i <
lenof(macs)
-1)
+ for (i = 0; i <
nmacs
; i++) {
+ ssh2_pkt_addstring_str(mac
list
[i]->name);
+ if (i <
nmacs
-1)
ssh2_pkt_addstring_str(",");
}
/* List client->server compression algorithms. */
ssh2_pkt_addstring_str(",");
}
/* List client->server compression algorithms. */
@@
-1979,16
+1992,16
@@
static int do_ssh2_transport(unsigned char *in, int inlen, int ispkt)
}
}
ssh2_pkt_getstring(&str, &len); /* client->server mac */
}
}
ssh2_pkt_getstring(&str, &len); /* client->server mac */
- for (i = 0; i <
lenof(macs)
; i++) {
- if (in_commasep_string(mac
s
[i]->name, str, len)) {
- csmac_tobe = mac
s
[i];
+ for (i = 0; i <
nmacs
; i++) {
+ if (in_commasep_string(mac
list
[i]->name, str, len)) {
+ csmac_tobe = mac
list
[i];
break;
}
}
ssh2_pkt_getstring(&str, &len); /* server->client mac */
break;
}
}
ssh2_pkt_getstring(&str, &len); /* server->client mac */
- for (i = 0; i <
lenof(macs)
; i++) {
- if (in_commasep_string(mac
s
[i]->name, str, len)) {
- scmac_tobe = mac
s
[i];
+ for (i = 0; i <
nmacs
; i++) {
+ if (in_commasep_string(mac
list
[i]->name, str, len)) {
+ scmac_tobe = mac
list
[i];
break;
}
}
break;
}
}
@@
-2275,7
+2288,7
@@
static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
ssh2_pkt_init(SSH2_MSG_CHANNEL_OPEN);
ssh2_pkt_addstring("session");
ssh2_pkt_adduint32(mainchan->localid);
ssh2_pkt_init(SSH2_MSG_CHANNEL_OPEN);
ssh2_pkt_addstring("session");
ssh2_pkt_adduint32(mainchan->localid);
- ssh2_pkt_adduint32(0x
7FFFFFFF
UL); /* our window size */
+ ssh2_pkt_adduint32(0x
8000
UL); /* our window size */
ssh2_pkt_adduint32(0x4000UL); /* our max pkt size */
ssh2_pkt_send();
crWaitUntilV(ispkt);
ssh2_pkt_adduint32(0x4000UL); /* our max pkt size */
ssh2_pkt_send();
crWaitUntilV(ispkt);
@@
-2419,6
+2432,9
@@
static void do_ssh2_authconn(unsigned char *in, int inlen, int ispkt)
logevent("All channels closed. Disconnecting");
ssh2_pkt_init(SSH2_MSG_DISCONNECT);
ssh2_pkt_send();
logevent("All channels closed. Disconnecting");
ssh2_pkt_init(SSH2_MSG_DISCONNECT);
ssh2_pkt_send();
+ ssh_state = SSH_STATE_CLOSED;
+ closesocket(s);
+ s = INVALID_SOCKET;
}
continue; /* remote sends close; ignore (FIXME) */
} else if (pktin.type == SSH2_MSG_CHANNEL_WINDOW_ADJUST) {
}
continue; /* remote sends close; ignore (FIXME) */
} else if (pktin.type == SSH2_MSG_CHANNEL_WINDOW_ADJUST) {
@@
-2611,6
+2627,14
@@
static void ssh_special (Telnet_Special code) {
ssh2_pkt_send();
}
logevent("Sent EOF message");
ssh2_pkt_send();
}
logevent("Sent EOF message");
+ } else if (code == TS_PING) {
+ if (ssh_version == 1) {
+ send_packet(SSH1_MSG_IGNORE, PKT_STR, "", PKT_END);
+ } else {
+ ssh2_pkt_init(SSH2_MSG_IGNORE);
+ ssh2_pkt_addstring_start();
+ ssh2_pkt_send();
+ }
} else {
/* do nothing */
}
} else {
/* do nothing */
}