Slight improvement to cursor blink timing: since the cursor doesn't
[u/mdw/putty] / terminal.c
index 281d2d2..9003cc4 100644 (file)
 
 #define TM_PUTTY       (0xFFFF)
 
+#define UPDATE_DELAY    ((TICKSPERSEC+49)/50)/* ticks to defer window update */
+#define TBLINK_DELAY    ((TICKSPERSEC*9+19)/20)/* ticks between text blinks*/
+#define CBLINK_DELAY    (CURSORBLINK) /* ticks between cursor blinks */
+#define VBELL_DELAY     (VBELL_TIMEOUT) /* visual bell timeout in ticks */
+
 #define compatibility(x) \
     if ( ((CL_##x)&term->compatibility_level) == 0 ) {         \
        term->termstate=TOPLEVEL;                       \
@@ -177,6 +182,8 @@ static void cc_check(termline *line)
        j += (flags[i] != 0);
 
     assert(j == line->size);
+
+    sfree(flags);
 }
 
 /*
@@ -433,6 +440,9 @@ static void makerle(struct buf *b, termline *ldata,
                hdrpos = b->len;
                hdrsize = 0;
                add(b, 0);
+               /* And ensure this run doesn't interfere with the next. */
+               prevlen = prevpos = 0;
+               prev2 = FALSE;
 
                continue;
            } else {
@@ -634,6 +644,9 @@ static unsigned char *compressline(termline *ldata)
     /*
      * Diagnostics: ensure that the compressed data really does
      * decompress to the right thing.
+     * 
+     * XXX-REMOVE-BEFORE-RELEASE: This is a bit performance-heavy
+     * to be leaving in production code.
      */
 #ifndef CHECK_SB_COMPRESSION
     {
@@ -845,9 +858,12 @@ static termline *decompressline(unsigned char *data, int *bytes_used)
  */
 static void resizeline(Terminal *term, termline *line, int cols)
 {
-    int i, oldlen;
+    int i, oldcols;
 
     if (line->cols != cols) {
+
+       oldcols = line->cols;
+
        /*
         * This line is the wrong length, which probably means it
         * hasn't been accessed since a resize. Resize it now.
@@ -856,24 +872,36 @@ static void resizeline(Terminal *term, termline *line, int cols)
         * out in the resize (if we're shrinking the line) and
         * return their cc lists to the cc free list.
         */
-       for (i = cols; i < line->cols; i++)
+       for (i = cols; i < oldcols; i++)
            clear_cc(line, i);
 
        /*
+        * If we're shrinking the line, we now bodily move the
+        * entire cc section from where it started to where it now
+        * needs to be. (We have to do this before the resize, so
+        * that the data we're copying is still there. However, if
+        * we're expanding, we have to wait until _after_ the
+        * resize so that the space we're copying into is there.)
+        */
+       if (cols < oldcols)
+           memmove(line->chars + cols, line->chars + oldcols,
+                   (line->size - line->cols) * TSIZE);
+
+       /*
         * Now do the actual resize, leaving the _same_ amount of
         * cc space as there was to begin with.
         */
-       oldlen = line->cols;
-       line->size += cols - oldlen;
+       line->size += cols - oldcols;
        line->chars = sresize(line->chars, line->size, TTYPE);
        line->cols = cols;
 
        /*
-        * Bodily move the entire cc section from where it started
-        * to where it now needs to be.
+        * If we're expanding the line, _now_ we move the cc
+        * section.
         */
-       memmove(line->chars + line->cols, line->chars + oldlen,
-               (line->size - line->cols) * TSIZE);
+       if (cols > oldcols)
+           memmove(line->chars + cols, line->chars + oldcols,
+                   (line->size - line->cols) * TSIZE);
 
        /*
         * Go through what's left of the original line, and adjust
@@ -882,18 +910,18 @@ static void resizeline(Terminal *term, termline *line, int cols)
         * relative offsets within the cc block.) Also do the same
         * to the head of the cc_free list.
         */
-       for (i = 0; i < oldlen && i < line->cols; i++)
+       for (i = 0; i < oldcols && i < cols; i++)
            if (line->chars[i].cc_next)
-               line->chars[i].cc_next += cols - oldlen;
+               line->chars[i].cc_next += cols - oldcols;
        if (line->cc_free)
-           line->cc_free += cols - oldlen;
+           line->cc_free += cols - oldcols;
 
        /*
         * And finally fill in the new space with erase chars. (We
         * don't have to worry about cc lists here, because we
         * _know_ the erase char doesn't have one.)
         */
-       for (i = oldlen; i < cols; i++)
+       for (i = oldcols; i < cols; i++)
            line->chars[i] = term->basic_erase_char;
 
        cc_check(line);                /* XXX-REMOVE-BEFORE-RELEASE */
@@ -964,6 +992,115 @@ static termline *lineptr(Terminal *term, int y, int lineno, int screen)
 #define lineptr(x) (lineptr)(term,x,__LINE__,FALSE)
 #define scrlineptr(x) (lineptr)(term,x,__LINE__,TRUE)
 
+static void term_schedule_tblink(Terminal *term);
+static void term_schedule_cblink(Terminal *term);
+
+static void term_timer(void *ctx, long now)
+{
+    Terminal *term = (Terminal *)ctx;
+    int update = FALSE;
+
+    if (term->tblink_pending && now - term->next_tblink >= 0) {
+       term->tblinker = !term->tblinker;
+       term->tblink_pending = FALSE;
+       term_schedule_tblink(term);
+       update = TRUE;
+    }
+
+    if (term->cblink_pending && now - term->next_cblink >= 0) {
+       term->cblinker = !term->cblinker;
+       term->cblink_pending = FALSE;
+       term_schedule_cblink(term);
+       update = TRUE;
+    }
+
+    if (term->in_vbell && now - term->vbell_end >= 0) {
+       term->in_vbell = FALSE;
+       update = TRUE;
+    }
+
+    if (update ||
+       (term->window_update_pending && now - term->next_update >= 0))
+       term_update(term);
+}
+
+/*
+ * Call this whenever the terminal window state changes, to queue
+ * an update.
+ */
+static void seen_disp_event(Terminal *term)
+{
+    term->seen_disp_event = TRUE;      /* for scrollback-reset-on-activity */
+    if (!term->window_update_pending) {
+       term->window_update_pending = TRUE;
+       term->next_update = schedule_timer(UPDATE_DELAY, term_timer, term);
+    }
+}
+
+/*
+ * Call when the terminal's blinking-text settings change, or when
+ * a text blink has just occurred.
+ */
+static void term_schedule_tblink(Terminal *term)
+{
+    if (term->blink_is_real) {
+       if (!term->tblink_pending)
+           term->next_tblink = schedule_timer(TBLINK_DELAY, term_timer, term);
+       term->tblink_pending = TRUE;
+    } else {
+       term->tblinker = 1;            /* reset when not in use */
+       term->tblink_pending = FALSE;
+    }
+}
+
+/*
+ * Likewise with cursor blinks.
+ */
+static void term_schedule_cblink(Terminal *term)
+{
+    if (term->cfg.blink_cur && term->has_focus) {
+       if (!term->cblink_pending)
+           term->next_cblink = schedule_timer(CBLINK_DELAY, term_timer, term);
+       term->cblink_pending = TRUE;
+    } else {
+       term->cblinker = 1;            /* reset when not in use */
+       term->cblink_pending = FALSE;
+    }
+}
+
+/*
+ * Call to reset cursor blinking on new output.
+ */
+static void term_reset_cblink(Terminal *term)
+{
+    seen_disp_event(term);
+    term->cblinker = 1;
+    term->cblink_pending = FALSE;
+    term_schedule_cblink(term);
+}
+
+/*
+ * Call to begin a visual bell.
+ */
+static void term_schedule_vbell(Terminal *term, int already_started,
+                               long startpoint)
+{
+    long ticks_already_gone;
+
+    if (already_started)
+       ticks_already_gone = GETTICKCOUNT() - startpoint;
+    else
+       ticks_already_gone = 0;
+
+    if (ticks_already_gone < VBELL_DELAY) {
+       term->in_vbell = TRUE;
+       term->vbell_end = schedule_timer(VBELL_DELAY - ticks_already_gone,
+                                        term_timer, term);
+    } else {
+       term->in_vbell = FALSE;
+    }
+}
+
 /*
  * Set up power-on settings for the terminal.
  */
@@ -1015,6 +1152,8 @@ static void power_on(Terminal *term)
        swap_screen(term, 0, FALSE, FALSE);
        erase_lots(term, FALSE, TRUE, TRUE);
     }
+    term_schedule_tblink(term);
+    term_schedule_cblink(term);
 }
 
 /*
@@ -1023,6 +1162,9 @@ static void power_on(Terminal *term)
 void term_update(Terminal *term)
 {
     Context ctx;
+
+    term->window_update_pending = FALSE;
+
     ctx = get_ctx(term->frontend);
     if (ctx) {
        int need_sbar_update = term->seen_disp_event;
@@ -1067,7 +1209,7 @@ void term_seen_key_event(Terminal *term)
      */
     if (term->cfg.scroll_on_key) {
        term->disptop = 0;             /* return to main screen */
-       term->seen_disp_event = 1;
+       seen_disp_event(term);
     }
 }
 
@@ -1107,18 +1249,34 @@ void term_reconfig(Terminal *term, Config *cfg)
      * default one. The full list is: Auto wrap mode, DEC Origin
      * Mode, BCE, blinking text, character classes.
      */
-    int reset_wrap, reset_decom, reset_bce, reset_blink, reset_charclass;
+    int reset_wrap, reset_decom, reset_bce, reset_tblink, reset_charclass;
     int i;
 
     reset_wrap = (term->cfg.wrap_mode != cfg->wrap_mode);
     reset_decom = (term->cfg.dec_om != cfg->dec_om);
     reset_bce = (term->cfg.bce != cfg->bce);
-    reset_blink = (term->cfg.blinktext != cfg->blinktext);
+    reset_tblink = (term->cfg.blinktext != cfg->blinktext);
     reset_charclass = 0;
     for (i = 0; i < lenof(term->cfg.wordness); i++)
        if (term->cfg.wordness[i] != cfg->wordness[i])
            reset_charclass = 1;
 
+    /*
+     * If the bidi or shaping settings have changed, flush the bidi
+     * cache completely.
+     */
+    if (term->cfg.arabicshaping != cfg->arabicshaping ||
+       term->cfg.bidi != cfg->bidi) {
+       for (i = 0; i < term->bidi_cache_size; i++) {
+           sfree(term->pre_bidi_cache[i].chars);
+           sfree(term->post_bidi_cache[i].chars);
+           term->pre_bidi_cache[i].width = -1;
+           term->pre_bidi_cache[i].chars = NULL;
+           term->post_bidi_cache[i].width = -1;
+           term->post_bidi_cache[i].chars = NULL;
+       }
+    }
+
     term->cfg = *cfg;                 /* STRUCTURE COPY */
 
     if (reset_wrap)
@@ -1129,8 +1287,9 @@ void term_reconfig(Terminal *term, Config *cfg)
        term->use_bce = term->cfg.bce;
        set_erase_char(term);
     }
-    if (reset_blink)
+    if (reset_tblink) {
        term->blink_is_real = term->cfg.blinktext;
+    }
     if (reset_charclass)
        for (i = 0; i < 256; i++)
            term->wordness[i] = term->cfg.wordness[i];
@@ -1149,6 +1308,8 @@ void term_reconfig(Terminal *term, Config *cfg)
     if (!*term->cfg.printer) {
        term_print_finish(term);
     }
+    term_schedule_tblink(term);
+    term_schedule_cblink(term);
 }
 
 /*
@@ -1185,7 +1346,7 @@ Terminal *term_init(Config *mycfg, struct unicode_data *ucsdata,
     term->logctx = NULL;
     term->compatibility_level = TM_PUTTY;
     strcpy(term->id_string, "\033[?6c");
-    term->last_blink = term->last_tblink = 0;
+    term->cblink_pending = term->tblink_pending = FALSE;
     term->paste_buffer = NULL;
     term->paste_len = 0;
     term->last_paste = 0;
@@ -1198,7 +1359,7 @@ Terminal *term_init(Config *mycfg, struct unicode_data *ucsdata,
     term->seen_disp_event = FALSE;
     term->xterm_mouse = term->mouse_is_down = FALSE;
     term->reset_132 = FALSE;
-    term->blinker = term->tblinker = 0;
+    term->cblinker = term->tblinker = 0;
     term->has_focus = 1;
     term->repeat_off = FALSE;
     term->termstate = TOPLEVEL;
@@ -1232,6 +1393,8 @@ Terminal *term_init(Config *mycfg, struct unicode_data *ucsdata,
     term->wcTo = NULL;
     term->wcFromTo_size = 0;
 
+    term->window_update_pending = FALSE;
+
     term->bidi_cache_size = 0;
     term->pre_bidi_cache = term->post_bidi_cache = NULL;
 
@@ -1279,12 +1442,14 @@ void term_free(Terminal *term)
     sfree(term->wcTo);
 
     for (i = 0; i < term->bidi_cache_size; i++) {
-       sfree(term->pre_bidi_cache[i]);
-       sfree(term->post_bidi_cache[i]);
+       sfree(term->pre_bidi_cache[i].chars);
+       sfree(term->post_bidi_cache[i].chars);
     }
     sfree(term->pre_bidi_cache);
     sfree(term->post_bidi_cache);
 
+    expire_timer_context(term);
+
     sfree(term);
 }
 
@@ -1394,7 +1559,7 @@ void term_size(Terminal *term, int newrows, int newcols, int newsavelines)
     for (i = 0; i < newrows; i++) {
        newdisp[i] = newline(term, newcols, FALSE);
        for (j = 0; j < newcols; j++)
-           newdisp[i]->chars[i].attr = ATTR_INVALID;
+           newdisp[i]->chars[j].attr = ATTR_INVALID;
     }
     if (term->disptext) {
        for (i = 0; i < oldrows; i++)
@@ -1633,7 +1798,7 @@ static void scroll(Terminal *term, int topline, int botline, int lines, int sb)
 
                addpos234(term->scrollback, compressline(line), sblen);
 
-               line = newline(term, term->cols, TRUE);
+               /* now `line' itself can be reused as the bottom line */
 
                /*
                 * If the user is currently looking at part of the
@@ -2005,8 +2170,6 @@ static void insch(Terminal *term, int n)
  */
 static void toggle_mode(Terminal *term, int mode, int query, int state)
 {
-    unsigned long ticks;
-
     if (query)
        switch (mode) {
          case 1:                      /* DECCKM: application cursor keys */
@@ -2020,6 +2183,7 @@ static void toggle_mode(Terminal *term, int mode, int query, int state)
            } else {
                term->blink_is_real = term->cfg.blinktext;
            }
+           term_schedule_tblink(term);
            break;
          case 3:                      /* DECCOLM: 80/132 columns */
            deselect(term);
@@ -2038,27 +2202,15 @@ static void toggle_mode(Terminal *term, int mode, int query, int state)
             * effective visual bell, so that ESC[?5hESC[?5l will
             * always be an actually _visible_ visual bell.
             */
-           ticks = GETTICKCOUNT();
-           /* turn off a previous vbell to avoid inconsistencies */
-           if (ticks - term->vbell_startpoint >= VBELL_TIMEOUT)
-               term->in_vbell = FALSE;
-           if (term->rvideo && !state &&    /* we're turning it off... */
-               (ticks - term->rvbell_startpoint) < VBELL_TIMEOUT) {/*...soon*/
-               /* If there's no vbell timeout already, or this one lasts
-                * longer, replace vbell_timeout with ours. */
-               if (!term->in_vbell ||
-                   (term->rvbell_startpoint - term->vbell_startpoint <
-                    VBELL_TIMEOUT))
-                   term->vbell_startpoint = term->rvbell_startpoint;
-               term->in_vbell = TRUE; /* may clear rvideo but set in_vbell */
+           if (term->rvideo && !state) {
+               /* This is an OFF, so set up a vbell */
+               term_schedule_vbell(term, TRUE, term->rvbell_startpoint);
            } else if (!term->rvideo && state) {
                /* This is an ON, so we notice the time and save it. */
-               term->rvbell_startpoint = ticks;
+               term->rvbell_startpoint = GETTICKCOUNT();
            }
            term->rvideo = state;
-           term->seen_disp_event = TRUE;
-           if (state)
-               term_update(term);
+           seen_disp_event(term);
            break;
          case 6:                      /* DECOM: DEC origin mode */
            term->dec_om = state;
@@ -2077,7 +2229,7 @@ static void toggle_mode(Terminal *term, int mode, int query, int state)
          case 25:                     /* DECTCEM: enable/disable cursor */
            compatibility2(OTHER, VT220);
            term->cursor_on = state;
-           term->seen_disp_event = TRUE;
+           seen_disp_event(term);
            break;
          case 47:                     /* alternate screen */
            compatibility(OTHER);
@@ -2102,12 +2254,12 @@ static void toggle_mode(Terminal *term, int mode, int query, int state)
          case 1048:                   /* save/restore cursor */
            if (!term->cfg.no_alt_screen)
                 save_cursor(term, state);
-           if (!state) term->seen_disp_event = TRUE;
+           if (!state) seen_disp_event(term);
            break;
          case 1049:                   /* cursor & alternate screen */
            if (state && !term->cfg.no_alt_screen)
                save_cursor(term, state);
-           if (!state) term->seen_disp_event = TRUE;
+           if (!state) seen_disp_event(term);
            compatibility(OTHER);
            deselect(term);
            swap_screen(term, term->cfg.no_alt_screen ? 0 : state, TRUE, FALSE);
@@ -2215,7 +2367,7 @@ static void term_print_finish(Terminal *term)
  * in-memory display. There's a big state machine in here to
  * process escape sequences...
  */
-void term_out(Terminal *term)
+static void term_out(Terminal *term)
 {
     unsigned long c;
     int unget;
@@ -2430,6 +2582,8 @@ void term_out(Terminal *term)
            term->wrapnext = FALSE;
            /* destructive backspace might be disabled */
            if (!term->cfg.no_dbackspace) {
+               check_boundary(term, term->curs.x, term->curs.y);
+               check_boundary(term, term->curs.x+1, term->curs.y);
                copy_termchar(scrlineptr(term->curs.y),
                              term->curs.x, &term->erase_char);
            }
@@ -2526,13 +2680,12 @@ void term_out(Terminal *term)
                     */
                    if (!term->cfg.bellovl || !term->beep_overloaded) {
                        beep(term->frontend, term->cfg.beep);
+
                        if (term->cfg.beep == BELL_VISUAL) {
-                           term->in_vbell = TRUE;
-                           term->vbell_startpoint = ticks;
-                           term_update(term);
+                           term_schedule_vbell(term, FALSE, 0);
                        }
                    }
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                }
                break;
              case '\b':              /* BS: Back space */
@@ -2545,7 +2698,7 @@ void term_out(Terminal *term)
                    term->wrapnext = FALSE;
                else
                    term->curs.x--;
-               term->seen_disp_event = TRUE;
+               seen_disp_event(term);
                break;
              case '\016':            /* LS1: Locking-shift one */
                compatibility(VT100);
@@ -2567,7 +2720,7 @@ void term_out(Terminal *term)
              case '\015':            /* CR: Carriage return */
                term->curs.x = 0;
                term->wrapnext = FALSE;
-               term->seen_disp_event = TRUE;
+               seen_disp_event(term);
                term->paste_hold = 0;
                if (term->logctx)
                    logtraffic(term->logctx, (unsigned char) c, LGTYP_ASCII);
@@ -2578,7 +2731,7 @@ void term_out(Terminal *term)
                    erase_lots(term, FALSE, FALSE, TRUE);
                    term->disptop = 0;
                    term->wrapnext = FALSE;
-                   term->seen_disp_event = 1;
+                   seen_disp_event(term);
                    break;
                }
              case '\013':            /* VT: Line tabulation */
@@ -2591,7 +2744,7 @@ void term_out(Terminal *term)
                if (term->cfg.lfhascr)
                    term->curs.x = 0;
                term->wrapnext = FALSE;
-               term->seen_disp_event = 1;
+               seen_disp_event(term);
                term->paste_hold = 0;
                if (term->logctx)
                    logtraffic(term->logctx, (unsigned char) c, LGTYP_ASCII);
@@ -2616,7 +2769,7 @@ void term_out(Terminal *term)
 
                    check_selection(term, old_curs, term->curs);
                }
-               term->seen_disp_event = TRUE;
+               seen_disp_event(term);
                break;
            }
        } else
@@ -2640,6 +2793,7 @@ void term_out(Terminal *term)
                            term->curs.y++;
                        term->curs.x = 0;
                        term->wrapnext = FALSE;
+                       cline = scrlineptr(term->curs.y);
                    }
                    if (term->insert && width > 0)
                        insch(term, width);
@@ -2716,7 +2870,26 @@ void term_out(Terminal *term)
 
                        break;
                      case 0:
-                       add_cc(cline, term->curs.x - !term->wrapnext, c);
+                       if (term->curs.x > 0) {
+                           int x = term->curs.x - 1;
+
+                           /* If we're in wrapnext state, the character
+                            * to combine with is _here_, not to our left. */
+                           if (term->wrapnext)
+                               x++;
+
+                           /*
+                            * If the previous character is
+                            * UCSWIDE, back up another one.
+                            */
+                           if (cline->chars[x].chr == UCSWIDE) {
+                               assert(x > 0);
+                               x--;
+                           }
+
+                           add_cc(cline, x, c);
+                           seen_disp_event(term);
+                       }
                        continue;
                      default:
                        continue;
@@ -2735,7 +2908,7 @@ void term_out(Terminal *term)
                            term->wrapnext = FALSE;
                        }
                    }
-                   term->seen_disp_event = 1;
+                   seen_disp_event(term);
                }
                break;
 
@@ -2780,7 +2953,7 @@ void term_out(Terminal *term)
                  case '8':             /* DECRC: restore cursor */
                    compatibility(VT100);
                    save_cursor(term, FALSE);
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                    break;
                  case '=':             /* DECKPAM: Keypad application mode */
                    compatibility(VT100);
@@ -2797,7 +2970,7 @@ void term_out(Terminal *term)
                    else if (term->curs.y < term->rows - 1)
                        term->curs.y++;
                    term->wrapnext = FALSE;
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                    break;
                  case 'E':            /* NEL: exactly equivalent to CR-LF */
                    compatibility(VT100);
@@ -2807,7 +2980,7 @@ void term_out(Terminal *term)
                    else if (term->curs.y < term->rows - 1)
                        term->curs.y++;
                    term->wrapnext = FALSE;
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                    break;
                  case 'M':            /* RI: reverse index - backwards LF */
                    compatibility(VT100);
@@ -2816,7 +2989,7 @@ void term_out(Terminal *term)
                    else if (term->curs.y > 0)
                        term->curs.y--;
                    term->wrapnext = FALSE;
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                    break;
                  case 'Z':            /* DECID: terminal type query */
                    compatibility(VT100);
@@ -2835,7 +3008,7 @@ void term_out(Terminal *term)
                        term->reset_132 = 0;
                    }
                    term->disptop = 0;
-                   term->seen_disp_event = TRUE;
+                   seen_disp_event(term);
                    break;
                  case 'H':            /* HTS: set a tab */
                    compatibility(VT100);
@@ -2859,7 +3032,7 @@ void term_out(Terminal *term)
                            ldata->lattr = LATTR_NORM;
                        }
                        term->disptop = 0;
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        scrtop.x = scrtop.y = 0;
                        scrbot.x = 0;
                        scrbot.y = term->rows;
@@ -2975,7 +3148,7 @@ void term_out(Terminal *term)
                      case 'A':       /* CUU: move up N lines */
                        move(term, term->curs.x,
                             term->curs.y - def(term->esc_args[0], 1), 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'e':         /* VPR: move down N lines */
                        compatibility(ANSI);
@@ -2983,7 +3156,7 @@ void term_out(Terminal *term)
                      case 'B':         /* CUD: Cursor down */
                        move(term, term->curs.x,
                             term->curs.y + def(term->esc_args[0], 1), 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case ANSI('c', '>'):      /* DA: report xterm version */
                        compatibility(OTHER);
@@ -2998,31 +3171,31 @@ void term_out(Terminal *term)
                      case 'C':         /* CUF: Cursor right */ 
                        move(term, term->curs.x + def(term->esc_args[0], 1),
                             term->curs.y, 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'D':       /* CUB: move left N cols */
                        move(term, term->curs.x - def(term->esc_args[0], 1),
                             term->curs.y, 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'E':       /* CNL: move down N lines and CR */
                        compatibility(ANSI);
                        move(term, 0,
                             term->curs.y + def(term->esc_args[0], 1), 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'F':       /* CPL: move up N lines and CR */
                        compatibility(ANSI);
                        move(term, 0,
                             term->curs.y - def(term->esc_args[0], 1), 1);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'G':       /* CHA */
                      case '`':       /* HPA: set horizontal posn */
                        compatibility(ANSI);
                        move(term, def(term->esc_args[0], 1) - 1,
                             term->curs.y, 0);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'd':       /* VPA: set vertical posn */
                        compatibility(ANSI);
@@ -3030,7 +3203,7 @@ void term_out(Terminal *term)
                             ((term->dec_om ? term->marg_t : 0) +
                              def(term->esc_args[0], 1) - 1),
                             (term->dec_om ? 2 : 0));
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'H':      /* CUP */
                      case 'f':      /* HVP: set horz and vert posns at once */
@@ -3040,7 +3213,7 @@ void term_out(Terminal *term)
                             ((term->dec_om ? term->marg_t : 0) +
                              def(term->esc_args[0], 1) - 1),
                             (term->dec_om ? 2 : 0));
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'J':       /* ED: erase screen or parts of it */
                        {
@@ -3050,7 +3223,7 @@ void term_out(Terminal *term)
                            erase_lots(term, FALSE, !!(i & 2), !!(i & 1));
                        }
                        term->disptop = 0;
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'K':       /* EL: erase line or parts of it */
                        {
@@ -3059,14 +3232,14 @@ void term_out(Terminal *term)
                                i = 0;
                            erase_lots(term, TRUE, !!(i & 2), !!(i & 1));
                        }
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'L':       /* IL: insert lines */
                        compatibility(VT102);
                        if (term->curs.y <= term->marg_b)
                            scroll(term, term->curs.y, term->marg_b,
                                   -def(term->esc_args[0], 1), FALSE);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'M':       /* DL: delete lines */
                        compatibility(VT102);
@@ -3074,18 +3247,18 @@ void term_out(Terminal *term)
                            scroll(term, term->curs.y, term->marg_b,
                                   def(term->esc_args[0], 1),
                                   TRUE);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case '@':       /* ICH: insert chars */
                        /* XXX VTTEST says this is vt220, vt510 manual says vt102 */
                        compatibility(VT102);
                        insch(term, def(term->esc_args[0], 1));
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'P':       /* DCH: delete chars */
                        compatibility(VT102);
                        insch(term, -def(term->esc_args[0], 1));
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'c':       /* DA: terminal type query */
                        compatibility(VT100);
@@ -3183,7 +3356,7 @@ void term_out(Terminal *term)
                                 */
                                term->curs.y = (term->dec_om ?
                                                term->marg_t : 0);
-                               term->seen_disp_event = TRUE;
+                               seen_disp_event(term);
                            }
                        }
                        break;
@@ -3241,6 +3414,7 @@ void term_out(Terminal *term)
                                    compatibility(SCOANSI);
                                    term->blink_is_real = FALSE;
                                    term->curr_attr |= ATTR_BLINK;
+                                   term_schedule_tblink(term);
                                    break;
                                  case 7:       /* enable reverse video */
                                    term->curr_attr |= ATTR_REVERSE;
@@ -3345,7 +3519,7 @@ void term_out(Terminal *term)
                        break;
                      case 'u':       /* restore cursor */
                        save_cursor(term, FALSE);
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 't': /* DECSLPP: set page size - ie window height */
                        /*
@@ -3487,14 +3661,14 @@ void term_out(Terminal *term)
                        scroll(term, term->marg_t, term->marg_b,
                               def(term->esc_args[0], 1), TRUE);
                        term->wrapnext = FALSE;
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case 'T':         /* SD: Scroll down */
                        compatibility(SCOANSI);
                        scroll(term, term->marg_t, term->marg_b,
                               -def(term->esc_args[0], 1), TRUE);
                        term->wrapnext = FALSE;
-                       term->seen_disp_event = TRUE;
+                       seen_disp_event(term);
                        break;
                      case ANSI('|', '*'): /* DECSNLS */
                        /* 
@@ -3547,7 +3721,7 @@ void term_out(Terminal *term)
                            while (n--)
                                copy_termchar(cline, p++,
                                              &term->erase_char);
-                           term->seen_disp_event = TRUE;
+                           seen_disp_event(term);
                        }
                        break;
                      case 'x':       /* DECREQTPARM: report terminal characteristics */
@@ -3611,6 +3785,7 @@ void term_out(Terminal *term)
                      case ANSI('D', '='):
                        compatibility(SCOANSI);
                        term->blink_is_real = FALSE;
+                       term_schedule_tblink(term);
                        if (term->esc_args[0]>=1)
                            term->curr_attr |= ATTR_BLINK;
                        else
@@ -3619,6 +3794,7 @@ void term_out(Terminal *term)
                      case ANSI('E', '='):
                        compatibility(SCOANSI);
                        term->blink_is_real = (term->esc_args[0] >= 1);
+                       term_schedule_tblink(term);
                        break;
                      case ANSI('F', '='):      /* set normal foreground */
                        compatibility(SCOANSI);
@@ -3849,7 +4025,7 @@ void term_out(Terminal *term)
                break;
              case VT52_ESC:
                term->termstate = TOPLEVEL;
-               term->seen_disp_event = TRUE;
+               seen_disp_event(term);
                switch (c) {
                  case 'A':
                    move(term, term->curs.x, term->curs.y - 1, 1);
@@ -3957,6 +4133,7 @@ void term_out(Terminal *term)
                     */
                    term->vt52_mode = FALSE;
                    term->blink_is_real = term->cfg.blinktext;
+                   term_schedule_tblink(term);
                    break;
 #if 0
                  case '^':
@@ -4126,11 +4303,14 @@ static int term_bidi_cache_hit(Terminal *term, int line,
     if (line >= term->bidi_cache_size)
        return FALSE;                  /* cache doesn't have this many lines */
 
-    if (!term->pre_bidi_cache[line])
+    if (!term->pre_bidi_cache[line].chars)
        return FALSE;                  /* cache doesn't contain _this_ line */
 
+    if (term->pre_bidi_cache[line].width != width)
+       return FALSE;                  /* line is wrong width */
+
     for (i = 0; i < width; i++)
-       if (!termchars_equal(term->pre_bidi_cache[line] + i, lbefore + i))
+       if (!termchars_equal(term->pre_bidi_cache[line].chars+i, lbefore+i))
            return FALSE;              /* line doesn't match cache */
 
     return TRUE;                      /* it didn't match. */
@@ -4144,24 +4324,29 @@ static void term_bidi_cache_store(Terminal *term, int line, termchar *lbefore,
        term->bidi_cache_size = line+1;
        term->pre_bidi_cache = sresize(term->pre_bidi_cache,
                                       term->bidi_cache_size,
-                                      termchar *);
+                                      struct bidi_cache_entry);
        term->post_bidi_cache = sresize(term->post_bidi_cache,
                                        term->bidi_cache_size,
-                                       termchar *);
+                                       struct bidi_cache_entry);
        while (j < term->bidi_cache_size) {
-           term->pre_bidi_cache[j] = term->post_bidi_cache[j] = NULL;
+           term->pre_bidi_cache[j].chars =
+               term->post_bidi_cache[j].chars = NULL;
+           term->pre_bidi_cache[j].width =
+               term->post_bidi_cache[j].width = -1;
            j++;
        }
     }
 
-    sfree(term->pre_bidi_cache[line]);
-    sfree(term->post_bidi_cache[line]);
+    sfree(term->pre_bidi_cache[line].chars);
+    sfree(term->post_bidi_cache[line].chars);
 
-    term->pre_bidi_cache[line] = snewn(width, termchar);
-    term->post_bidi_cache[line] = snewn(width, termchar);
+    term->pre_bidi_cache[line].width = width;
+    term->pre_bidi_cache[line].chars = snewn(width, termchar);
+    term->post_bidi_cache[line].width = width;
+    term->post_bidi_cache[line].chars = snewn(width, termchar);
 
-    memcpy(term->pre_bidi_cache[line], lbefore, width * TSIZE);
-    memcpy(term->post_bidi_cache[line], lafter, width * TSIZE);
+    memcpy(term->pre_bidi_cache[line].chars, lbefore, width * TSIZE);
+    memcpy(term->post_bidi_cache[line].chars, lafter, width * TSIZE);
 }
 
 /*
@@ -4176,7 +4361,6 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
     wchar_t *ch;
     int chlen;
     termchar cursor_background;
-    unsigned long ticks;
 #ifdef OPTIMISE_SCROLL
     struct scrollregion *sr;
 #endif /* OPTIMISE_SCROLL */
@@ -4186,28 +4370,19 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
     chlen = 1024;
     ch = snewn(chlen, wchar_t);
 
-    /*
-     * Check the visual bell state.
-     */
-    if (term->in_vbell) {
-       ticks = GETTICKCOUNT();
-       if (ticks - term->vbell_startpoint >= VBELL_TIMEOUT)
-           term->in_vbell = FALSE;
-    }
-
     rv = (!term->rvideo ^ !term->in_vbell ? ATTR_REVERSE : 0);
 
     /* Depends on:
      * screen array, disptop, scrtop,
      * selection, rv, 
      * cfg.blinkpc, blink_is_real, tblinker, 
-     * curs.y, curs.x, blinker, cfg.blink_cur, cursor_on, has_focus, wrapnext
+     * curs.y, curs.x, cblinker, cfg.blink_cur, cursor_on, has_focus, wrapnext
      */
 
     /* Has the cursor position or type changed ? */
     if (term->cursor_on) {
        if (term->has_focus) {
-           if (term->blinker || !term->cfg.blink_cur)
+           if (term->cblinker || !term->cfg.blink_cur)
                cursor = TATTR_ACTCURS;
            else
                cursor = 0;
@@ -4364,7 +4539,7 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
 
                lchars = term->ltemp;
            } else {
-               lchars = term->post_bidi_cache[i];
+               lchars = term->post_bidi_cache[i].chars;
            }
        } else
            lchars = ldata->chars;
@@ -4378,6 +4553,10 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
            tchar = d->chr;
            tattr = d->attr;
 
+            if (!term->cfg.ansi_colour)
+                tattr = (tattr & ~(ATTR_FGMASK | ATTR_BGMASK)) | 
+                ATTR_DEFFG | ATTR_DEFBG;
+
            switch (tchar & CSET_MASK) {
              case CSET_ASCII:
                tchar = term->ucsdata->unitab_line[tchar & 0xFF];
@@ -4559,6 +4738,7 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
        if (i == our_curs_y && (term->curstype != cursor || updated_line)) {
            ch[0] = (wchar_t) cursor_background.chr;
            attr = cursor_background.attr | cursor;
+           ccount = 1;
 
            if (cursor_background.cc_next) {
                termchar *dd = ldata->chars + cursor_background.cc_next;
@@ -4594,7 +4774,7 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
                attr |= TATTR_COMBINING;
            }
 
-           do_cursor(ctx, our_curs_x, i, ch, 1, attr, ldata->lattr);
+           do_cursor(ctx, our_curs_x, i, ch, ccount, attr, ldata->lattr);
            term->curstype = cursor;
        }
 
@@ -4605,39 +4785,6 @@ static void do_paint(Terminal *term, Context ctx, int may_optimise)
 }
 
 /*
- * Flick the switch that says if blinking things should be shown or hidden.
- */
-
-void term_blink(Terminal *term, int flg)
-{
-    long now, blink_diff;
-
-    now = GETTICKCOUNT();
-    blink_diff = now - term->last_tblink;
-
-    /* Make sure the text blinks no more than 2Hz; we'll use 0.45 s period. */
-    if (blink_diff < 0 || blink_diff > (TICKSPERSEC * 9 / 20)) {
-       term->last_tblink = now;
-       term->tblinker = !term->tblinker;
-    }
-
-    if (flg) {
-       term->blinker = 1;
-       term->last_blink = now;
-       return;
-    }
-
-    blink_diff = now - term->last_blink;
-
-    /* Make sure the cursor blinks no faster than system blink rate */
-    if (blink_diff >= 0 && blink_diff < (long) CURSORBLINK)
-       return;
-
-    term->last_blink = now;
-    term->blinker = !term->blinker;
-}
-
-/*
  * Invalidate the whole screen so it will be repainted in full.
  */
 void term_invalidate(Terminal *term)
@@ -4662,7 +4809,7 @@ void term_paint(Terminal *term, Context ctx,
     if (bottom >= term->rows) bottom = term->rows-1;
 
     for (i = top; i <= bottom && i < term->rows; i++) {
-       if (term->disptext[i]->lattr == LATTR_NORM)
+       if ((term->disptext[i]->lattr & LATTR_MODE) == LATTR_NORM)
            for (j = left; j <= right && j < term->cols; j++)
                term->disptext[i]->chars[j].attr = ATTR_INVALID;
        else
@@ -4670,12 +4817,14 @@ void term_paint(Terminal *term, Context ctx,
                term->disptext[i]->chars[j].attr = ATTR_INVALID;
     }
 
-    /* This should happen soon enough, also for some reason it sometimes 
-     * fails to actually do anything when re-sizing ... painting the wrong
-     * window perhaps ?
-     */
-    if (immediately)
+    if (immediately) {
         do_paint (term, ctx, FALSE);
+    } else {
+       if (!term->window_update_pending) {
+           term->window_update_pending = TRUE;
+           term->next_update = schedule_timer(UPDATE_DELAY, term_timer, term);
+       }
+    }
 }
 
 /*
@@ -4741,6 +4890,7 @@ static void clipme(Terminal *term, pos top, pos bottom, int rect, int desel)
         */
        if (!(ldata->lattr & LATTR_WRAPPED)) {
            while (IS_SPACE_CHR(ldata->chars[nlpos.x - 1].chr) &&
+                  !ldata->chars[nlpos.x - 1].cc_next &&
                   poslt(top, nlpos))
                decpos(nlpos);
            if (poslt(nlpos, bottom))
@@ -5013,7 +5163,8 @@ static pos sel_spread_half(Terminal *term, pos p, int dir)
         */
        if (!(ldata->lattr & LATTR_WRAPPED)) {
            termchar *q = ldata->chars + term->cols;
-           while (q > ldata->chars && IS_SPACE_CHR(q[-1].chr))
+           while (q > ldata->chars &&
+                  IS_SPACE_CHR(q[-1].chr) && !q[-1].cc_next)
                q--;
            if (q == ldata->chars + term->cols)
                q--;
@@ -5884,8 +6035,14 @@ int term_data(Terminal *term, int is_stderr, const char *data, int len)
 
     if (!term->in_term_out) {
        term->in_term_out = TRUE;
-       term_blink(term, 1);
-       term_out(term);
+       term_reset_cblink(term);
+       /*
+        * During drag-selects, we do not process terminal input,
+        * because the user will want the screen to hold still to
+        * be selected.
+        */
+       if (term->selstate != DRAGGING)
+           term_out(term);
        term->in_term_out = FALSE;
     }
 
@@ -5915,3 +6072,9 @@ void term_provide_logctx(Terminal *term, void *logctx)
 {
     term->logctx = logctx;
 }
+
+void term_set_focus(Terminal *term, int has_focus)
+{
+    term->has_focus = has_focus;
+    term_schedule_cblink(term);
+}