Consistent indenting in option specs
[u/mdw/putty] / config.c
index 1dbdfac..0f71201 100644 (file)
--- a/config.c
+++ b/config.c
@@ -92,7 +92,7 @@ static void cipherlist_handler(union control *ctrl, void *dlg,
            { "3DES",                   CIPHER_3DES },
            { "Blowfish",               CIPHER_BLOWFISH },
            { "DES",                    CIPHER_DES },
-           { "AES (SSH 2 only)",       CIPHER_AES },
+           { "AES (SSH-2 only)",       CIPHER_AES },
            { "-- warn below here --",  CIPHER_WARN }
        };
 
@@ -402,7 +402,7 @@ static void sessionsaver_handler(union control *ctrl, void *dlg,
                /* If at this point we have a valid session, go! */
                if (*cfg2.host) {
                    *cfg = cfg2;       /* structure copy */
-                   cfg->remote_cmd_ptr = cfg->remote_cmd; /* nasty */
+                   cfg->remote_cmd_ptr = NULL;
                    dlg_end(dlg, 1);
                } else
                    dlg_beep(dlg);
@@ -666,6 +666,9 @@ static void environ_handler(union control *ctrl, void *dlg,
 struct portfwd_data {
     union control *addbutton, *rembutton, *listbox;
     union control *sourcebox, *destbox, *direction;
+#ifndef NO_IPV6
+    union control *addressfamily;
+#endif
 };
 
 static void portfwd_handler(union control *ctrl, void *dlg,
@@ -690,28 +693,46 @@ static void portfwd_handler(union control *ctrl, void *dlg,
             * Default is Local.
             */
            dlg_radiobutton_set(ctrl, dlg, 0);
+#ifndef NO_IPV6
+       } else if (ctrl == pfd->addressfamily) {
+           dlg_radiobutton_set(ctrl, dlg, 0);
+#endif
        }
     } else if (event == EVENT_ACTION) {
        if (ctrl == pfd->addbutton) {
            char str[sizeof(cfg->portfwd)];
            char *p;
-           int whichbutton = dlg_radiobutton_get(pfd->direction, dlg);
+           int i, type;
+           int whichbutton;
+
+           i = 0;
+#ifndef NO_IPV6
+           whichbutton = dlg_radiobutton_get(pfd->addressfamily, dlg);
+           if (whichbutton == 1)
+               str[i++] = '4';
+           else if (whichbutton == 2)
+               str[i++] = '6';
+#endif
+
+           whichbutton = dlg_radiobutton_get(pfd->direction, dlg);
            if (whichbutton == 0)
-               str[0] = 'L';
+               type = 'L';
            else if (whichbutton == 1)
-               str[0] = 'R';
+               type = 'R';
            else
-               str[0] = 'D';
-           dlg_editbox_get(pfd->sourcebox, dlg, str+1, sizeof(str) - 2);
-           if (!str[1]) {
+               type = 'D';
+           str[i++] = type;
+
+           dlg_editbox_get(pfd->sourcebox, dlg, str+i, sizeof(str) - i);
+           if (!str[i]) {
                dlg_error_msg(dlg, "You need to specify a source port number");
                return;
            }
            p = str + strlen(str);
-           if (str[0] != 'D') {
+           if (type != 'D') {
                *p++ = '\t';
                dlg_editbox_get(pfd->destbox, dlg, p,
-                               sizeof(str)-1 - (p - str));
+                               sizeof(str) - (p - str));
                if (!*p || !strchr(p, ':')) {
                    dlg_error_msg(dlg,
                                  "You need to specify a destination address\n"
@@ -726,7 +747,7 @@ static void portfwd_handler(union control *ctrl, void *dlg,
                    p++;
                p++;
            }
-           if ((p - cfg->portfwd) + strlen(str) + 2 <
+           if ((p - cfg->portfwd) + strlen(str) + 2 <=
                sizeof(cfg->portfwd)) {
                strcpy(p, str);
                p[strlen(str) + 1] = '\0';
@@ -853,6 +874,7 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
      * The Load/Save panel is available even in mid-session.
      */
     s = ctrl_getset(b, "Session", "savedsessions",
+                   midsession ? "Save the current session settings" :
                    "Load, save or delete a stored session");
     ctrl_columns(s, 2, 75, 25);
     ssd->sesslist = sesslist;
@@ -1344,9 +1366,54 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
     if (protocol >= 0) {
        ctrl_settitle(b, "Connection", "Options controlling the connection");
 
+       s = ctrl_getset(b, "Connection", "keepalive",
+                       "Sending of null packets to keep session active");
+       ctrl_editbox(s, "Seconds between keepalives (0 to turn off)", 'k', 20,
+                    HELPCTX(connection_keepalive),
+                    dlg_stdeditbox_handler, I(offsetof(Config,ping_interval)),
+                    I(-1));
+
        if (!midsession) {
-           s = ctrl_getset(b, "Connection", "data",
-                           "Data to send to the server");
+           s = ctrl_getset(b, "Connection", "tcp",
+                           "Low-level TCP connection options");
+           ctrl_checkbox(s, "Disable Nagle's algorithm (TCP_NODELAY option)",
+                         'n', HELPCTX(connection_nodelay),
+                         dlg_stdcheckbox_handler,
+                         I(offsetof(Config,tcp_nodelay)));
+           ctrl_checkbox(s, "Enable TCP keepalives (SO_KEEPALIVE option)",
+                         'p', HELPCTX(connection_tcpkeepalive),
+                         dlg_stdcheckbox_handler,
+                         I(offsetof(Config,tcp_keepalives)));
+#ifndef NO_IPV6
+           s = ctrl_getset(b, "Connection", "ipversion",
+                         "Internet protocol version");
+           ctrl_radiobuttons(s, NULL, NO_SHORTCUT, 3,
+                         HELPCTX(connection_ipversion),
+                         dlg_stdradiobutton_handler,
+                         I(offsetof(Config, addressfamily)),
+                         "Auto", NO_SHORTCUT, I(ADDRTYPE_UNSPEC),
+                         "IPv4", NO_SHORTCUT, I(ADDRTYPE_IPV4),
+                         "IPv6", NO_SHORTCUT, I(ADDRTYPE_IPV6),
+                         NULL);
+#endif
+       }
+
+       /*
+        * A sub-panel Connection/Data, containing options that
+        * decide on data to send to the server.
+        */
+       if (!midsession) {
+           ctrl_settitle(b, "Connection/Data", "Data to send to the server");
+
+           s = ctrl_getset(b, "Connection/Data", "login",
+                           "Login details");
+           ctrl_editbox(s, "Auto-login username", 'u', 50,
+                        HELPCTX(connection_username),
+                        dlg_stdeditbox_handler, I(offsetof(Config,username)),
+                        I(sizeof(((Config *)0)->username)));
+
+           s = ctrl_getset(b, "Connection/Data", "term",
+                           "Terminal details");
            ctrl_editbox(s, "Terminal-type string", 't', 50,
                         HELPCTX(connection_termtype),
                         dlg_stdeditbox_handler, I(offsetof(Config,termtype)),
@@ -1355,12 +1422,9 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                         HELPCTX(connection_termspeed),
                         dlg_stdeditbox_handler, I(offsetof(Config,termspeed)),
                         I(sizeof(((Config *)0)->termspeed)));
-           ctrl_editbox(s, "Auto-login username", 'u', 50,
-                        HELPCTX(connection_username),
-                        dlg_stdeditbox_handler, I(offsetof(Config,username)),
-                        I(sizeof(((Config *)0)->username)));
 
-           ctrl_text(s, "Environment variables:", HELPCTX(telnet_environ));
+           s = ctrl_getset(b, "Connection/Data", "env",
+                           "Environment variables");
            ctrl_columns(s, 2, 80, 20);
            ed = (struct environ_data *)
                ctrl_alloc(b, sizeof(struct environ_data));
@@ -1391,26 +1455,6 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
            ed->listbox->listbox.percentages[1] = 70;
        }
 
-       s = ctrl_getset(b, "Connection", "keepalive",
-                       "Sending of null packets to keep session active");
-       ctrl_editbox(s, "Seconds between keepalives (0 to turn off)", 'k', 20,
-                    HELPCTX(connection_keepalive),
-                    dlg_stdeditbox_handler, I(offsetof(Config,ping_interval)),
-                    I(-1));
-
-       if (!midsession) {
-           s = ctrl_getset(b, "Connection", "tcp",
-                           "Low-level TCP connection options");
-           ctrl_checkbox(s, "Disable Nagle's algorithm (TCP_NODELAY option)",
-                         'n', HELPCTX(connection_nodelay),
-                         dlg_stdcheckbox_handler,
-                         I(offsetof(Config,tcp_nodelay)));
-           ctrl_checkbox(s, "Enable TCP keepalives (SO_KEEPALIVE option)",
-                         'p', HELPCTX(connection_tcpkeepalive),
-                         dlg_stdcheckbox_handler,
-                         I(offsetof(Config,tcp_keepalives)));
-       }
-
     }
 
     if (!midsession) {
@@ -1547,7 +1591,7 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
        ctrl_settitle(b, "Connection/SSH",
                      "Options controlling SSH connections");
 
-       if (midsession) {
+       if (midsession && protcfginfo == 1) {
            s = ctrl_getset(b, "Connection/SSH", "disclaimer", NULL);
            ctrl_text(s, "Nothing on this panel may be reconfigured in mid-"
                      "session; it is only here so that sub-panels of it can "
@@ -1572,10 +1616,20 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                          HELPCTX(ssh_noshell),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,ssh_no_shell)));
+       }
+
+       if (!midsession || protcfginfo != 1) {
+           s = ctrl_getset(b, "Connection/SSH", "protocol", "Protocol options");
+
            ctrl_checkbox(s, "Enable compression", 'e',
                          HELPCTX(ssh_compress),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,compression)));
+       }
+
+       if (!midsession) {
+           s = ctrl_getset(b, "Connection/SSH", "protocol", "Protocol options");
+
            ctrl_radiobuttons(s, "Preferred SSH protocol version:", NO_SHORTCUT, 4,
                              HELPCTX(ssh_protocol),
                              dlg_stdradiobutton_handler,
@@ -1584,14 +1638,16 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                              "1", '1', I(1),
                              "2", '2', I(2),
                              "2 only", 'y', I(3), NULL);
+       }
 
+       if (!midsession || protcfginfo != 1) {
            s = ctrl_getset(b, "Connection/SSH", "encryption", "Encryption options");
            c = ctrl_draglist(s, "Encryption cipher selection policy:", 's',
                              HELPCTX(ssh_ciphers),
                              cipherlist_handler, P(NULL));
            c->listbox.height = 6;
 
-           ctrl_checkbox(s, "Enable legacy use of single-DES in SSH 2", 'i',
+           ctrl_checkbox(s, "Enable legacy use of single-DES in SSH-2", 'i',
                          HELPCTX(ssh_ciphers),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,ssh2_des_cbc)));
@@ -1600,7 +1656,7 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
        /*
         * The Connection/SSH/Kex panel. (Owing to repeat key
         * exchange, this is all meaningful in mid-session _if_
-        * we're using SSH2 or haven't decided yet.)
+        * we're using SSH-2 or haven't decided yet.)
         */
        if (protcfginfo != 1) {
            ctrl_settitle(b, "Connection/SSH/Kex",
@@ -1608,7 +1664,7 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
 
            s = ctrl_getset(b, "Connection/SSH/Kex", "main",
                            "Key exchange algorithm options");
-           c = ctrl_draglist(s, "Algorithm selection policy", 's',
+           c = ctrl_draglist(s, "Algorithm selection policy:", 's',
                              HELPCTX(ssh_kexlist),
                              kexlist_handler, P(NULL));
            c->listbox.height = 5;
@@ -1640,11 +1696,11 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
 
            s = ctrl_getset(b, "Connection/SSH/Auth", "methods",
                            "Authentication methods");
-           ctrl_checkbox(s, "Attempt TIS or CryptoCard auth (SSH1)", 'm',
+           ctrl_checkbox(s, "Attempt TIS or CryptoCard auth (SSH-1)", 'm',
                          HELPCTX(ssh_auth_tis),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,try_tis_auth)));
-           ctrl_checkbox(s, "Attempt \"keyboard-interactive\" auth (SSH2)",
+           ctrl_checkbox(s, "Attempt \"keyboard-interactive\" auth (SSH-2)",
                          'i', HELPCTX(ssh_auth_ki),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,try_ki_auth)));
@@ -1654,7 +1710,7 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
            ctrl_checkbox(s, "Allow agent forwarding", 'f',
                          HELPCTX(ssh_auth_agentfwd),
                          dlg_stdcheckbox_handler, I(offsetof(Config,agentfwd)));
-           ctrl_checkbox(s, "Allow attempted changes of username in SSH2", 'u',
+           ctrl_checkbox(s, "Allow attempted changes of username in SSH-2", 'u',
                          HELPCTX(ssh_auth_changeuser),
                          dlg_stdcheckbox_handler,
                          I(offsetof(Config,change_username)));
@@ -1664,15 +1720,14 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                         dlg_stdfilesel_handler, I(offsetof(Config, keyfile)));
        }
 
-       /*
-        * The Connection/SSH/Tunnels panel. Some of this _is_
-        * still available in mid-session.
-        */
-       ctrl_settitle(b, "Connection/SSH/Tunnels",
-                     "Options controlling SSH tunnelling");
-
        if (!midsession) {
-           s = ctrl_getset(b, "Connection/SSH/Tunnels", "x11", "X11 forwarding");
+           /*
+            * The Connection/SSH/X11 panel.
+            */
+           ctrl_settitle(b, "Connection/SSH/X11",
+                         "Options controlling SSH X11 forwarding");
+
+           s = ctrl_getset(b, "Connection/SSH/X11", "x11", "X11 forwarding");
            ctrl_checkbox(s, "Enable X11 forwarding", 'e',
                          HELPCTX(ssh_tunnels_x11),
                          dlg_stdcheckbox_handler,I(offsetof(Config,x11_forward)));
@@ -1688,13 +1743,19 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                              "XDM-Authorization-1", I(X11_XDM), NULL);
        }
 
+       /*
+        * The Tunnels panel _is_ still available in mid-session.
+        */
+       ctrl_settitle(b, "Connection/SSH/Tunnels",
+                     "Options controlling SSH port forwarding");
+
        s = ctrl_getset(b, "Connection/SSH/Tunnels", "portfwd",
                        "Port forwarding");
        ctrl_checkbox(s, "Local ports accept connections from other hosts",'t',
                      HELPCTX(ssh_tunnels_portfwd_localhost),
                      dlg_stdcheckbox_handler,
                      I(offsetof(Config,lport_acceptall)));
-       ctrl_checkbox(s, "Remote ports do the same (SSH v2 only)", 'p',
+       ctrl_checkbox(s, "Remote ports do the same (SSH-2 only)", 'p',
                      HELPCTX(ssh_tunnels_portfwd_localhost),
                      dlg_stdcheckbox_handler,
                      I(offsetof(Config,rport_acceptall)));
@@ -1741,6 +1802,16 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
                                           "Remote", 'm', P(NULL),
                                           "Dynamic", 'y', P(NULL),
                                           NULL);
+#ifndef NO_IPV6
+       pfd->addressfamily =
+           ctrl_radiobuttons(s, NULL, NO_SHORTCUT, 3,
+                             HELPCTX(ssh_tunnels_portfwd_ipversion),
+                             portfwd_handler, P(pfd),
+                             "Auto", NO_SHORTCUT, I(ADDRTYPE_UNSPEC),
+                             "IPv4", NO_SHORTCUT, I(ADDRTYPE_IPV4),
+                             "IPv6", NO_SHORTCUT, I(ADDRTYPE_IPV6),
+                             NULL);
+#endif
        ctrl_tabdelay(s, pfd->addbutton);
        ctrl_columns(s, 1, 100);
 
@@ -1753,27 +1824,30 @@ void setup_config_box(struct controlbox *b, struct sesslist *sesslist,
 
            s = ctrl_getset(b, "Connection/SSH/Bugs", "main",
                            "Detection of known bugs in SSH servers");
-           ctrl_droplist(s, "Chokes on SSH1 ignore messages", 'i', 20,
+           ctrl_droplist(s, "Chokes on SSH-1 ignore messages", 'i', 20,
                          HELPCTX(ssh_bugs_ignore1),
                          sshbug_handler, I(offsetof(Config,sshbug_ignore1)));
-           ctrl_droplist(s, "Refuses all SSH1 password camouflage", 's', 20,
+           ctrl_droplist(s, "Refuses all SSH-1 password camouflage", 's', 20,
                          HELPCTX(ssh_bugs_plainpw1),
                          sshbug_handler, I(offsetof(Config,sshbug_plainpw1)));
-           ctrl_droplist(s, "Chokes on SSH1 RSA authentication", 'r', 20,
+           ctrl_droplist(s, "Chokes on SSH-1 RSA authentication", 'r', 20,
                          HELPCTX(ssh_bugs_rsa1),
                          sshbug_handler, I(offsetof(Config,sshbug_rsa1)));
-           ctrl_droplist(s, "Miscomputes SSH2 HMAC keys", 'm', 20,
+           ctrl_droplist(s, "Miscomputes SSH-2 HMAC keys", 'm', 20,
                          HELPCTX(ssh_bugs_hmac2),
                          sshbug_handler, I(offsetof(Config,sshbug_hmac2)));
-           ctrl_droplist(s, "Miscomputes SSH2 encryption keys", 'e', 20,
+           ctrl_droplist(s, "Miscomputes SSH-2 encryption keys", 'e', 20,
                          HELPCTX(ssh_bugs_derivekey2),
                          sshbug_handler, I(offsetof(Config,sshbug_derivekey2)));
-           ctrl_droplist(s, "Requires padding on SSH2 RSA signatures", 'p', 20,
+           ctrl_droplist(s, "Requires padding on SSH-2 RSA signatures", 'p', 20,
                          HELPCTX(ssh_bugs_rsapad2),
                          sshbug_handler, I(offsetof(Config,sshbug_rsapad2)));
-           ctrl_droplist(s, "Misuses the session ID in PK auth", 'n', 20,
+           ctrl_droplist(s, "Misuses the session ID in SSH-2 PK auth", 'n', 20,
                          HELPCTX(ssh_bugs_pksessid2),
                          sshbug_handler, I(offsetof(Config,sshbug_pksessid2)));
+           ctrl_droplist(s, "Handles SSH-2 key re-exchange badly", 'k', 20,
+                         HELPCTX(ssh_bugs_rekey2),
+                         sshbug_handler, I(offsetof(Config,sshbug_rekey2)));
        }
     }
 }