#ifndef NO_IPV6
hints.ai_flags = AI_CANONNAME;
- hints.ai_family = address_family;
- hints.ai_socktype = 0;
+ hints.ai_family = (address_family == ADDRTYPE_IPV4 ? AF_INET :
+ address_family == ADDRTYPE_IPV6 ? AF_INET6 :
+ AF_UNSPEC);
+ hints.ai_socktype = SOCK_STREAM;
hints.ai_protocol = 0;
hints.ai_addrlen = 0;
hints.ai_addr = NULL;
hints.ai_canonname = NULL;
hints.ai_next = NULL;
- err = getaddrinfo(host, NULL, NULL, &ret->ai);
+ err = getaddrinfo(host, NULL, &hints, &ret->ai);
if (err != 0) {
ret->error = gai_strerror(err);
return ret;
else
strncat(realhost, host, sizeof(realhost) - 1);
#else
- if ((a = inet_addr(host)) == (unsigned long) INADDR_NONE) {
+ if ((a = inet_addr(host)) == (unsigned long)(in_addr_t)(-1)) {
/*
* Otherwise use the IPv4-only gethostbyname... (NOTE:
* we don't use gethostbyname as a fallback!)
ret->family = AF_UNSPEC;
strncpy(ret->hostname, host, lenof(ret->hostname));
ret->hostname[lenof(ret->hostname)-1] = '\0';
+#ifndef NO_IPV6
+ ret->ai = NULL;
+#endif
return ret;
}
#ifndef NO_IPV6
struct addrinfo hints, *ai;
char portstr[6];
+ struct sockaddr_in6 a6;
#endif
+ struct sockaddr *addr;
+ int addrlen;
struct sockaddr_in a;
- int err;
Actual_Socket ret;
int retcode;
int on = 1;
address_family = AF_INET;
s = socket(address_family, SOCK_STREAM, 0);
}
- ret->s = s;
if (s < 0) {
ret->error = error_string(errno);
setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (const char *)&on, sizeof(on));
- /* BSD IP stacks need sockaddr_in zeroed before filling in */
- memset(&a,'\0',sizeof(struct sockaddr_in));
+ retcode = -1;
+ addr = NULL; addrlen = -1; /* placate optimiser */
+
+ if (srcaddr != NULL) {
#ifndef NO_IPV6
-#if 0
- memset(&a6,'\0',sizeof(struct sockaddr_in6));
-#endif
- hints.ai_flags = AI_NUMERICHOST;
- hints.ai_family = address_family;
- hints.ai_socktype = 0;
- hints.ai_protocol = 0;
- hints.ai_addrlen = 0;
- hints.ai_addr = NULL;
- hints.ai_canonname = NULL;
- hints.ai_next = NULL;
- sprintf(portstr, "%d", port);
- if (srcaddr != NULL && getaddrinfo(srcaddr, portstr, &hints, &ai) == 0)
- retcode = bind(s, ai->ai_addr, ai->ai_addrlen);
- else
-#if 0
- {
- /*
- * FIXME: Need two listening sockets, in principle, one for v4
- * and one for v6
- */
- if (local_host_only)
- a6.sin6_addr = in6addr_loopback;
- else
- a6.sin6_addr = in6addr_any;
- a6.sin6_port = htons(port);
- } else
-#endif
+ hints.ai_flags = AI_NUMERICHOST;
+ hints.ai_family = address_family;
+ hints.ai_socktype = 0;
+ hints.ai_protocol = 0;
+ hints.ai_addrlen = 0;
+ hints.ai_addr = NULL;
+ hints.ai_canonname = NULL;
+ hints.ai_next = NULL;
+ sprintf(portstr, "%d", port);
+ retcode = getaddrinfo(srcaddr, portstr, &hints, &ai);
+ addr = ai->ai_addr;
+ addrlen = ai->ai_addrlen;
+#else
+ memset(&a,'\0',sizeof(struct sockaddr_in));
+ a.sin_family = AF_INET;
+ a.sin_port = htons(port);
+ a.sin_addr.s_addr = inet_addr(srcaddr);
+ if (a.sin_addr.s_addr != (in_addr_t)(-1)) {
+ /* Override localhost_only with specified listen addr. */
+ ret->localhost_only = ipv4_is_loopback(a.sin_addr);
+ got_addr = 1;
+ }
+ addr = (struct sockaddr *)a;
+ addrlen = sizeof(a);
+ retcode = 0;
#endif
- {
- int got_addr = 0;
- a.sin_family = AF_INET;
-
- /*
- * Bind to source address. First try an explicitly
- * specified one...
- */
- if (srcaddr) {
- a.sin_addr.s_addr = inet_addr(srcaddr);
- if (a.sin_addr.s_addr != INADDR_NONE) {
- /* Override localhost_only with specified listen addr. */
- ret->localhost_only = ipv4_is_loopback(a.sin_addr);
- got_addr = 1;
- }
- }
+ }
- /*
- * ... and failing that, go with one of the standard ones.
- */
- if (!got_addr) {
+ if (retcode != 0) {
+#ifndef NO_IPV6
+ if (address_family == AF_INET6) {
+ memset(&a6,'\0',sizeof(struct sockaddr_in6));
+ a6.sin6_family = AF_INET6;
+ a6.sin6_port = htons(port);
+ if (local_host_only)
+ a6.sin6_addr = in6addr_loopback;
+ else
+ a6.sin6_addr = in6addr_any;
+ addr = (struct sockaddr *)&a6;
+ addrlen = sizeof(a6);
+ } else
+#endif
+ {
+ memset(&a,'\0',sizeof(struct sockaddr_in));
+ a.sin_family = AF_INET;
+ a.sin_port = htons(port);
if (local_host_only)
a.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
else
a.sin_addr.s_addr = htonl(INADDR_ANY);
- }
-
- a.sin_port = htons((short)port);
- retcode = bind(s, (struct sockaddr *) &a, sizeof(a));
- }
-
- if (retcode >= 0) {
- err = 0;
- } else {
- err = errno;
+ addr = (struct sockaddr *)&a;
+ addrlen = sizeof(a);
+ }
}
- if (err) {
- ret->error = error_string(err);
+ retcode = bind(s, addr, addrlen);
+ if (retcode < 0) {
+ close(s);
+ ret->error = error_string(errno);
return (Socket) ret;
}
return (Socket) ret;
}
+ ret->s = s;
+
uxsel_tell(ret);
add234(sktree, ret);