From: Mark Wooding <mdw@distorted.org.uk>
Date: Sat, 25 Feb 2012 23:34:16 +0000 (+0000)
Subject: hashsum.c: Return nonzero from `checkhash' on errors.
X-Git-Url: https://git.distorted.org.uk/u/mdw/catacomb/commitdiff_plain/df8e52c798e925d8d6fc1ec0d43996bebf1092ef

hashsum.c: Return nonzero from `checkhash' on errors.

A serious bug: `checkhash' carefully maintained the `rc' variable -- and
then ignored it and always returned zero anyway.
---

diff --git a/hashsum.c b/hashsum.c
index d12c506..820cfbd 100644
--- a/hashsum.c
+++ b/hashsum.c
@@ -125,7 +125,7 @@ static int checkhash(const gchash *gch, unsigned f,
     moan("%lu of %lu file(s) failed %s check", nfail, n, hfp.gch->name);
   else if (!n)
     moan("no files checked");
-  return (0);
+  return (rc);
 }
 
 static int dohash(const gchash *gch, unsigned f,