From: mdw <mdw>
Date: Sat, 17 Jun 2000 12:10:09 +0000 (+0000)
Subject: Add some argument checking.  Use MP secure memory interface.
X-Git-Url: https://git.distorted.org.uk/u/mdw/catacomb/commitdiff_plain/47566c4d68978741ca85414ba0870d2f1b0d1fd1

Add some argument checking.  Use MP secure memory interface.
---

diff --git a/strongprime.c b/strongprime.c
index a5f6052..cf2ca73 100644
--- a/strongprime.c
+++ b/strongprime.c
@@ -1,6 +1,6 @@
 /* -*-c-*-
  *
- * $Id: strongprime.c,v 1.2 2000/02/12 18:21:03 mdw Exp $
+ * $Id: strongprime.c,v 1.3 2000/06/17 12:10:09 mdw Exp $
  *
  * Generate `strong' prime numbers
  *
@@ -30,6 +30,9 @@
 /*----- Revision history --------------------------------------------------* 
  *
  * $Log: strongprime.c,v $
+ * Revision 1.3  2000/06/17 12:10:09  mdw
+ * Add some argument checking.  Use MP secure memory interface.
+ *
  * Revision 1.2  2000/02/12 18:21:03  mdw
  * Overhaul of key management (again).
  *
@@ -95,22 +98,21 @@ mp *strongprime_setup(const char *name, mp *d, pfilt *f, unsigned nbits,
 
   /* --- Choose two primes %$s$% and %$t$% of half the required size --- */
 
+  assert(((void)"nbits too small in strongprime_setup", nbits/2 > BITSLOP));
   nbits = nbits/2 - BITSLOP;
   c.step = 1;
 
   rr = mprand(rr, nbits, r, 1);
   DRESET(&dn); dstr_putf(&dn, "%s [s]", name);
-  if ((s = pgen(dn.buf, MP_NEW, rr, event, ectx, n, pgen_filter, &c,
+  if ((s = pgen(dn.buf, MP_NEWSEC, rr, event, ectx, n, pgen_filter, &c,
 	   rabin_iters(nbits), pgen_test, &rb)) == 0)
     goto fail_s;
-  mp_burn(s);
 
   rr = mprand(rr, nbits, r, 1);
   DRESET(&dn); dstr_putf(&dn, "%s [t]", name);
-  if ((t = pgen(dn.buf, MP_NEW, rr, event, ectx, n, pgen_filter, &c,
+  if ((t = pgen(dn.buf, MP_NEWSEC, rr, event, ectx, n, pgen_filter, &c,
 		rabin_iters(nbits), pgen_test, &rb)) == 0)
     goto fail_t;
-  mp_burn(t);
 
   /* --- Choose a suitable value for %$r = 2it + 1$% for some %$i$% --- */