From: Mark Wooding <mdw@distorted.org.uk>
Date: Sun, 22 Jan 2012 12:56:34 +0000 (+0000)
Subject: key-attr.c (key_setkeydata): Decref after incref.
X-Git-Url: https://git.distorted.org.uk/u/mdw/catacomb/commitdiff_plain/21dfa64dca27927f112896fd6f625284df858e7d

key-attr.c (key_setkeydata): Decref after incref.

Otherwise we'd crash if someone set the key data to be itself.
---

diff --git a/key-attr.c b/key-attr.c
index ceec2ae..b6a3616 100644
--- a/key-attr.c
+++ b/key-attr.c
@@ -194,8 +194,8 @@ int key_setkeydata(key_file *kf, key *k, key_data *kd)
 {
   if (!(kf->f & KF_WRITE))
     return (KERR_READONLY);
-  key_drop(k->k);
   key_incref(kd);
+  key_drop(k->k);
   k->k = kd;
   kf->f |= KF_MODIFIED;
   return (0);