X-Git-Url: https://git.distorted.org.uk/u/mdw/catacomb/blobdiff_plain/c76161cce326aee7a0835c095cd99b694db3d3d4..ea932d59b3071ce00f9e510aad014ad64a3dc48c:/mp-jacobi.c

diff --git a/mp-jacobi.c b/mp-jacobi.c
index 0e187cf..3674f22 100644
--- a/mp-jacobi.c
+++ b/mp-jacobi.c
@@ -1,13 +1,13 @@
 /* -*-c-*-
  *
- * $Id: mp-jacobi.c,v 1.4 2000/12/06 20:31:33 mdw Exp $
+ * $Id$
  *
  * Compute Jacobi symbol
  *
  * (c) 1999 Straylight/Edgeware
  */
 
-/*----- Licensing notice --------------------------------------------------* 
+/*----- Licensing notice --------------------------------------------------*
  *
  * This file is part of Catacomb.
  *
@@ -15,35 +15,18 @@
  * it under the terms of the GNU Library General Public License as
  * published by the Free Software Foundation; either version 2 of the
  * License, or (at your option) any later version.
- * 
+ *
  * Catacomb is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU Library General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU Library General Public
  * License along with Catacomb; if not, write to the Free
  * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
  * MA 02111-1307, USA.
  */
 
-/*----- Revision history --------------------------------------------------* 
- *
- * $Log: mp-jacobi.c,v $
- * Revision 1.4  2000/12/06 20:31:33  mdw
- * Add assertion to prevent crapness.
- *
- * Revision 1.3  2000/07/20 17:14:34  mdw
- * Simplify by using @mp_odd@.
- *
- * Revision 1.2  1999/12/10 23:19:02  mdw
- * Improve error-checking.
- *
- * Revision 1.1  1999/11/22 20:50:37  mdw
- * Add support for computing Jacobi symbols.
- *
- */
-
 /*----- Header files ------------------------------------------------------*/
 
 #include "mp.h"
@@ -52,27 +35,88 @@
 
 /* --- @mp_jacobi@ --- *
  *
- * Arguments:	@mp *a@ = an integer less than @n@
- *		@mp *n@ = an odd integer
+ * Arguments:	@mp *a@ = an integer
+ *		@mp *n@ = another integer
  *
  * Returns:	@-1@, @0@ or @1@ -- the Jacobi symbol %$J(a, n)$%.
  *
- * Use:		Computes the Jacobi symbol.  If @n@ is prime, this is the
- *		Legendre symbol and is equal to 1 if and only if @a@ is a
- *		quadratic residue mod @n@.  The result is zero if and only if
- *		@a@ and @n@ have a common factor greater than one.
+ * Use:		Computes the Kronecker symbol %$\jacobi{a}{n}$%.  If @n@ is
+ *		prime, this is the Legendre symbol and is equal to 1 if and
+ *		only if @a@ is a quadratic residue mod @n@.  The result is
+ *		zero if and only if @a@ and @n@ have a common factor greater
+ *		than one.
+ *
+ *		If @n@ is composite, then this computes the Kronecker symbol
+ *
+ *		  %$\jacobi{a}{n}=\jacobi{a}{u}\prod_i\jacobi{a}{p_i}^{e_i}$%
+ *
+ *		where %$n = u p_0^{e_0} \ldots p_{n-1}^{e_{n-1}}$% is the
+ *		prime factorization of %$n$%.  The missing bits are:
+ *
+ *		  * %$\jacobi{a}{1} = 1$%;
+ *		  * %$\jacobi{a}{-1} = 1$% if @a@ is negative, or 1 if
+ *		    positive;
+ *		  * %$\jacobi{a}{0} = 0$%;
+ *	          * %$\jacobi{a}{2}$ is 0 if @a@ is even, 1 if @a@ is
+ *		    congruent to 1 or 7 (mod 8), or %$-1$% otherwise.
+ *
+ *		If %$n$% is positive and odd, then this is the Jacobi
+ *		symbol.  (The Kronecker symbol is a consistant domain
+ *		extension; the Jacobi symbol was implemented first, and the
+ *		name stuck.)
  */
 
 int mp_jacobi(mp *a, mp *n)
 {
   int s = 1;
+  size_t p2;
+
+  /* --- Handle zero specially --- *
+   *
+   * I can't find any specific statement for what to do when %$n = 0$%; PARI
+   * opts to set %$\jacobi{\pm1}{0} = \pm 1$% and %$\jacobi{a}{0} = 0$% for
+   * other %$a$%.
+   */
+
+  if (MP_ZEROP(n)) {
+    if (MP_EQ(a, MP_ONE)) return (+1);
+    else if (MP_EQ(a, MP_MONE)) return (-1);
+    else return (0);
+  }
+
+  /* --- Deal with powers of two --- *
+   *
+   * This implicitly takes a copy of %$n$%.  Copy %$a$% at the same time to
+   * make cleanup easier.
+   */
+
+  MP_COPY(a);
+  n = mp_odd(MP_NEW, n, &p2);
+  if (p2) {
+    if (MP_EVENP(a)) {
+      s = 0;
+      goto done;
+    } else if ((p2 & 1) && ((a->v[0] & 7) == 3 || (a->v[0] & 7) == 5))
+      s = -s;
+  }
+
+  /* --- Deal with negative %$n$% --- */
+
+  if (MP_NEGP(n)) {
+    n = mp_neg(n, n);
+    if (MP_NEGP(a))
+      s = -s;
+  }
+
+  /* --- Check for unit %$n$% --- */
 
-  assert(((void)"n must be odd in mp_jacobi", MP_LEN(n) && (n->v[0] & 1)));
+  if (MP_EQ(n, MP_ONE))
+    goto done;
 
-  /* --- Take copies of the arguments --- */
+  /* --- Reduce %$a$% modulo %$n$% --- */
 
-  a = MP_COPY(a);
-  n = MP_COPY(n);
+  if (MP_NEGP(a) || MP_CMP(a, >=, n))
+    mp_div(0, &a, a, n);
 
   /* --- Main recursive mess, flattened out into something nice --- */
 
@@ -83,7 +127,7 @@ int mp_jacobi(mp *a, mp *n)
     /* --- Some simple special cases --- */
 
     MP_SHRINK(a);
-    if (MP_LEN(a) == 0) {
+    if (MP_ZEROP(a)) {
       s = 0;
       goto done;
     }